From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF1313B3880 for ; Thu, 9 Apr 2026 09:30:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775727010; cv=none; b=KuNHquGUE+57CLuFV/e5E7tmekfI7W6K2cNXen/aoeZsW1oDmpQI1ZszFnyRBVOJbIoE0+aMXfAtPam1hDFrWFlu8QEik0iMf9qQ4uwcDHYASrLah5HgQULqppaRs8vwCRrTpRrfMbd1423W+EE1TDMcQlUbz11n+N+Kx9Y8lvg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775727010; c=relaxed/simple; bh=utBpeyHf5B9ahcaUGjVmSVgU73UuCO4p44e+rDod+3Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sUTyWkURSFurdRCrnSjFcON8xIj4/z+VWC33jmnGVAcLmo1Cvxjws+6FlKzSxOZFUNM8XM1YwXRynaO6ng1MbwyD+c7v5wpgkJq5+VKF70nFEcVIpxfKhCAUOeKT/RroDcJMaFrJtEXh0qitkFxzft32bMmFKzJpptvJ4JrJxtw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Pi1MI/En; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=WywTF7/H; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Pi1MI/En"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="WywTF7/H" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775727005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bIlu63YYxk1ewnvHFxHuvTVCREVfM3vbRJ7L4z4Sf6g=; b=Pi1MI/EnMpQVY52juBG8bFisabfHArq2+dpi7L7hc+Rpwi+nB5wmtAM5bvdFUYiINqxTq0 QLl2SKnwmWC9Qzb2g6bRF1nbDWccKg8+Q5bGnt7YCaH4i5Qa3zOrBDK0NLJsJIGpmsdcv0 EkKyDZYmA2x/GLGzhPWOTSlh4wdTRls= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-117-w1KoFo4GP_60hxaT-Fr5lQ-1; Thu, 09 Apr 2026 05:30:04 -0400 X-MC-Unique: w1KoFo4GP_60hxaT-Fr5lQ-1 X-Mimecast-MFC-AGG-ID: w1KoFo4GP_60hxaT-Fr5lQ_1775727003 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-43d177fb157so531422f8f.0 for ; Thu, 09 Apr 2026 02:30:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775727003; x=1776331803; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bIlu63YYxk1ewnvHFxHuvTVCREVfM3vbRJ7L4z4Sf6g=; b=WywTF7/HmZm/umTInvRb5287rh4l6c04+z+5KdDWK7jV7fNCHshJj0gI44oSgTcvT2 1SKo/vzqhVulm5gyf8F5WfRzFtiYDtxwAsI09hx5HZG9dTrtlhr81h3Cy5SkGXaa1g3s 9eOzIzJppNocLtn0YHbm2OOYs9sOQSAtvEIspzZNqXP3afl5HDv2FGpWWaCMK85XAIW5 qB9hblo9XX/ctiaKXrpfO8zc1i4Wz2iVi/mxvFcGLonNXfkGFwMICb33rVk1iLUNkGyG 6UM6eOG2XZs/UJiI8fvLUTBFeHkv5LjTMlymfmt1GKZDl583ayViAFTzI+er67jA18Ik W7Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775727003; x=1776331803; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bIlu63YYxk1ewnvHFxHuvTVCREVfM3vbRJ7L4z4Sf6g=; b=CXNCwo6dT+KomD7/pcZ7Fbj4Z6KQn0iRkKBI/8yyUROkBZc4fvntsMs0T5/sr8b8l+ rjUr8UKTKmwW81GaY/GbUbeeKLmQ5eJGyF36XD4IW6SAveU1kR27pBXPPJx5HMjeip4R taF09PntoGEQBlCTkRq1XkBQ/CisEzIxtxLsMhjZH4/8jDKDrlg7qOC3QaNt5ZCbSeA1 TOagVcRTSuXaK2rftnGG7wKn59FnHn2J/XTewlHR99FQ1qPEJACUatyoFAUgZ2d5cofp O6I9UG3mrBbV13Vw/DARXEeA2bxovQXx6RmMoHDVndIn9qAqTJlrHOeu3ysmUR6XH/6w onLg== X-Forwarded-Encrypted: i=1; AJvYcCXClLuRrHrDzWWHFWRgFq8runT5qRkleYb8EqMOvETleyQ90n9jumD2cMml/QBWFgqpjLLq5B9hRlSOKa0=@vger.kernel.org X-Gm-Message-State: AOJu0YyxJqU7wDRR6NOUtb2WLnfUHiRQ60QjlY6Q/+g1Vf/qNW0o4LQI ZfTk6JeqPf6R7XGgmqCxlJAFD7JEDuz0kEeE+1egmFUlDLWMr8cm8V+cJwOcaw4Qg9vDC8Z6ZCH GPDFXyzY1Nv//atZtr2AIiWW1HDQWdnp3ZBQhW8O+zsE9v54JYB+qgEn4QtNwdvtc+Pb+XbW0Rw == X-Gm-Gg: AeBDieuJNgzrr16FQtzgS3z8/q6g5VQhDdykiMSKWlLCZnxmag+OYsXmw8XbNq5DT7k KBhw6wR/OG4bGjSZs0EikTSpIzxQnUFrPPEgysrQcphUIYnRrr+seMH4X34R90gS5uVcyb1IBcd hRxKJaICVxrbMuW33VNaMX8NHb9qozGvyhYjjZhUmDt5+go9jYTnWtstRjzXf8uexnwQIDay/I+ bUoxmtxK+q+H/V4T8dNaOWSx+BfbnTdMlqRg/0BE6Px/1blqceInInc5lrCg4Q0w/KVA2y2rTth +kv3NTIQZQy4uA9IGcsqZiQhuulD7LyCD8/e/1c5WqGQ2/1AWuFDgfrl/nnU2pzHhagVyLFxbEd c2Wwf1ImyL8O309PYPQoE6STt+XtdA5/1NFpRu1QC8M98iolVvE0GPVsc X-Received: by 2002:a05:6000:4305:b0:43b:50d6:4f04 with SMTP id ffacd0b85a97d-43d5a1a274bmr3681981f8f.38.1775727002727; Thu, 09 Apr 2026 02:30:02 -0700 (PDT) X-Received: by 2002:a05:6000:4305:b0:43b:50d6:4f04 with SMTP id ffacd0b85a97d-43d5a1a274bmr3681929f8f.38.1775727002228; Thu, 09 Apr 2026 02:30:02 -0700 (PDT) Received: from [192.168.88.32] ([150.228.25.243]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d473b8c1esm25684356f8f.12.2026.04.09.02.30.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Apr 2026 02:30:01 -0700 (PDT) Message-ID: <36e86b68-f7d9-4455-a0b5-613f717e670a@redhat.com> Date: Thu, 9 Apr 2026 11:30:00 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 4/5] net/sched: netem: add per-impairment extended statistics To: Stephen Hemminger , netdev@vger.kernel.org Cc: Jamal Hadi Salim , Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , open list References: <20260403225324.476787-1-stephen@networkplumber.org> <20260403225324.476787-5-stephen@networkplumber.org> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260403225324.476787-5-stephen@networkplumber.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/4/26 12:52 AM, Stephen Hemminger wrote: > diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h > index 66e8072f44df..fada10cb9b7b 100644 > --- a/include/uapi/linux/pkt_sched.h > +++ b/include/uapi/linux/pkt_sched.h > @@ -569,6 +569,15 @@ struct tc_netem_gemodel { > #define NETEM_DIST_SCALE 8192 > #define NETEM_DIST_MAX 16384 > > +struct tc_netem_xstats { > + __u32 delayed; /* packets delayed */ > + __u32 dropped; /* packets dropped by loss model */ > + __u32 corrupted; /* packets with bit errors injected */ > + __u32 duplicated; /* duplicate packets generated */ > + __u32 reordered; /* packets sent out of order */ > + __u32 ecn_marked; /* packets ECN CE-marked (not dropped)*/ > +}; Sashiko notes that the counters size will be set in stone by the uAPI, and u32 can wraparound very quickly (especially for unconditional delay). I see other qdiscs generally use __u32, but some have __u64 too, so I assume there are no architectural blocker to larger counter. Could you please move use __u64 above? Thanks, Paolo