From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8F9F307AF0 for ; Wed, 18 Feb 2026 11:21:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771413698; cv=none; b=j0HCYb5MwCuMt+lNh7vxDb/bCB3TOErXbOktHOdLl4bACg8Nf/9BbOuBnfAwRCMYWJZKuxB2HyM26TeGmkfTASshxHDzB7hddSdH6kCHu9GVvyG2u9kwURIMu7QIrXK1iKS4k+CSAVhafiwyKkYuDh2eeqqYlFUTQdURC6ihkhk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771413698; c=relaxed/simple; bh=VkGl5N6Ms1y9C+oUT5Engr5WmryKoI3TONJmWbbRXyI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R7Z6QLOn55004acGc/bt6dsrIWLqwM93ilkhMz6BEH5KrA/LZV6WOG6r1bEAUpw9LhYpqZTc0SCwlkV3JQzY+y2rJYcwqtSFJXMhJuI7Uuow5rZXyKHJKhFafiIvCbZ87iLZAdrlSu5kJ/om5NWiHBFRKNaQrWBuj73KQh8dFAw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WzT2nn+k; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fbPTQPjg; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WzT2nn+k"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fbPTQPjg" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61HN7iov4060336 for ; Wed, 18 Feb 2026 11:21:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ZAQFJVCiVyV/I/cFm2kTpG+fP1ktABWgnDDVKfpvzTY=; b=WzT2nn+kqBIXatBJ IMCp+uSXEhiP5bznuCLEsFAmySxvbifIPmrx4yDQPkP/wYkTe3MdrM76QPOV9zhU vSIxlA6sPl1uuXdcrPO+pOegKZkXB1DFxD2ix5Vbsj8t8DZzVoWrmWgjMnc8T1Do atdW2p0QigIMQLkCS8vfra0p6RvB50zZSoNCZB2pdiyQQjC+cZlC9ps/Lr7LT85g BVRPe92cazLlZh7iIjdOZg8BwXiuve4xq1zKEDut7M+BGPcVB82Bz9ybhmKB2+2k RgZK6R9jXYYqNrpR1Sja9fdlB+RQSLEdVk96mRtL7fzULQqV95iq7v/bI0L/JmKI 2SMQFg== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cd1qx1jky-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Feb 2026 11:21:36 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-896f5c90f07so53867466d6.0 for ; Wed, 18 Feb 2026 03:21:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771413696; x=1772018496; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZAQFJVCiVyV/I/cFm2kTpG+fP1ktABWgnDDVKfpvzTY=; b=fbPTQPjgJT8Er2B+WRbzu4cB8Z8t1UPXrJgptx6oPzqY6Fde5Zjjh3yM5kmqDvu3HI gmE+x3a3cYgYp0/nyo59bSW4w02YMtHNNF4rV7a1gOL/mrKqq9bDoabNfW8H2imBlZZF oWSSUEmTW/PXJG+EoWZ7MUbVEIWPgpr1d572sWwcXgNzJ2bI0OphPJ1V5bdYCTYYnAmQ bx+8Jd8hZjy2gdRR074rOcB8vp/89FTpymIKIBggWXmysAjqbBjkqCPwyzyKsU6KejLb LoBpKCECnuHR5ZTTisC1NtTG8p5CFCAS7GZUe1So84JyFBUUAoh2kbDhc/tLfgfO+uIz +KHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771413696; x=1772018496; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZAQFJVCiVyV/I/cFm2kTpG+fP1ktABWgnDDVKfpvzTY=; b=lIyVvgkTy5n+P5SUYsAMpJ/Mm18j7BQ/qbtb03mKARFbjTXXA8FsftioAMyXAyTIhX a8gAZSGrOLzyfCiVABrHthLMeF+fp7moPIAUNLrY0ht8Chh0N4FVXzMLu13rlyKB0XIS p3Cx2S5ju86nIYBy8+S6AXoM92PO9B/FDFVjOoA31Nit9ggK/85+i3H+mBtXWgXVkGaG dGD33D7WBK1taEvdugCJ2X9YRoYW7lN1Uqbjs+P7Q5j6CpWhTDqhfZJf6ibQKJqCKlaj PXRqOySQHeuEBXjllgY1uEnkARynAmYhIpkU7si2KDiNLsOKNs4b1WtSl1icKTNsYVvg XP+w== X-Forwarded-Encrypted: i=1; AJvYcCUZvPkGz/zMj774jPeUuHk7c5WAjI0Q2R7ziyHdAaGeCUZ+IZFPBuePeRJd9eLoPXtfDUBT6k3vY7WAolo=@vger.kernel.org X-Gm-Message-State: AOJu0YwNBzFIDPpef0AMDFctnDZjGC39T0OaQf6MWwIuen7KEvb7Y3I5 7dEcjr5Oa0MyBi6r9rSMZDOAM0OEv6cy8YIysXJVdwFKiFg76wXseychMZqXP7+IFT+5HZmHi+B 6kd7gpJqe5M5SVhSKkw85yjCZTHHTw6czcebgcbpVxzt9yvjPXq18Hb3w5CFzm8M6108= X-Gm-Gg: AZuq6aJ7M/xzm4mfLy9j8iFRJ9zyibRDjx2IBOqrLRkzYurLApUV398oZ9CtoxaJJeD 7Z7xrPmv5brA2ysBYMWAhExBX7kOkNMgVg50X9mB0IW/POvaXQ4ieH16bswTvJUdpTNemK8RRST f3re/1TEmFvAsC2Xct1EwrbN2olXd4DHx8WOolyliPsizdtxfZJFVUsdmqWGwz5CnRRZYRE1YbL 8j0HPeVJMnQiJLNe7BSQb+y3hLvfd/UFkCvaMXqR68BofAlLmtYYtN+zT5WWdjiQ+NnlbokhjNn oyPGOVPEPP+CAGi3xM+gcPLY8lQ0e+ICVPgNPpHY5uJrkh1GSPPQ1y9kfvrsFEbBvxoe3H8DAsr g4YPDTPm0UilkcaItHMFRI3fNO2jKlJ2ieZP9If3Lwl7syYHPIHPaTiDcXPlHAHeoUujIZ/cD6u 5SBI0= X-Received: by 2002:a05:6214:6105:b0:896:f523:155a with SMTP id 6a1803df08f44-897347f9d2bmr170496666d6.6.1771413696094; Wed, 18 Feb 2026 03:21:36 -0800 (PST) X-Received: by 2002:a05:6214:6105:b0:896:f523:155a with SMTP id 6a1803df08f44-897347f9d2bmr170496376d6.6.1771413695680; Wed, 18 Feb 2026 03:21:35 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8fc76b2580sm437029366b.64.2026.02.18.03.21.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Feb 2026 03:21:35 -0800 (PST) Message-ID: <36f2fe1d-27df-4ca6-9554-72edc9108127@oss.qualcomm.com> Date: Wed, 18 Feb 2026 12:21:32 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [net-next,v3,3/3] net: ipa: Grab IMEM slice base/size from DTS To: Simon Horman , konradybcio@kernel.org Cc: pabeni@redhat.com, marijn.suijten@somainline.org, edumazet@google.com, elder@riscstar.com, andrew+netdev@lunn.ch, dmitry.baryshkov@oss.qualcomm.com, andersson@kernel.org, elder@kernel.org, devicetree@vger.kernel.org, krzk@kernel.org, linux-arm-msm@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, conor+dt@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org References: <20260217-topic-ipa_imem-v3-3-d6d8ed1dfb67@oss.qualcomm.com> <20260218103917.132153-3-horms@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260218103917.132153-3-horms@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: y18cmp1cInDmy593TLE3wKS8GHgdvPvP X-Authority-Analysis: v=2.4 cv=R7oO2NRX c=1 sm=1 tr=0 ts=6995a0c0 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=9R54UkLUAAAA:8 a=PR7fkkLM5UUJJyjF1Z0A:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 a=YTcpBFlVQWkNscrzJ_Dz:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE4MDEwMSBTYWx0ZWRfX7wklWe6DpFY2 4vJ9Sa/Oe5eqEE0CK95aQgpaVxxw0BVLC9bYoyflfcxLDu5AXoB5SRlM5o2rqfqV68NvWpYmG6Q +NzlLWUCIjLfmDnSkCUgY5xLTZzYx89qwAKKVOh6wvGJ3XrLmgw8H27bE55uh+5cKdwhGbT7Tat rSEP2mRhjd5UVmoTr2JIX5KPqDmY1mtmFT5ltAMurBEiCkvzDcP4y6XQ/b3o4T5JKpFEG3SIRLd J7lYeGz7vm0/T2tJeaDfjWrwJht9zBtQS/vL3SDq7aje9uK7LYaM3SRrGtqr0Bb4qxOCuyz2yi8 0uXAV5ITYyIXsA992FCyDAJGhWTc0RMpx4a3XM0MgC2QNEZPUlORpF0hOWskc7Vup0kb7qhtyhG c2+jjwlYNuWXk4pV/h58JjgPF/gF+gHPMlGb1C4NE/ib0fWfVvSVOejt21J8+5IDCTt3czdr47i rQtPTAV+vey+wPkhd1w== X-Proofpoint-ORIG-GUID: y18cmp1cInDmy593TLE3wKS8GHgdvPvP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-18_01,2026-02-16_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 priorityscore=1501 impostorscore=0 phishscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602180101 On 2/18/26 11:39 AM, Simon Horman wrote: > This is an AI-generated review of your patch. The human sending this > email has considered the AI review valid, or at least plausible. > > For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html > --- [...] >> + of_node_put(ipa_slice_np); >> + if (ret) >> + return ret; > ^^^^^^^^^^ > > At this point ipa->mem_virt holds a valid memremap() pointer. Does > this direct return leak the mapping? Every other error path after the > memremap() in this function uses goto err_unmap, which calls > memunmap(ipa->mem_virt). Should this be goto err_unmap instead? > > Simon says: This seems to me to be an actual problem. Yes, the robot proved useful Konrad