From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f97.google.com (mail-yx1-f97.google.com [74.125.224.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C7F43E7BB6 for ; Mon, 13 Jul 2026 10:51:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.97 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783939908; cv=none; b=A8qV3tl4EmGsLdwCB5vU/efIsSVAzMrh37440rYIW1/Gy0mqydYsS7bHczzclzAogSy/dOdo3AFzjp+XJIwsuVOIowvztG/cPuQhh2fj7cIFQjmDw9Sh67Tem5Zu8Ck/iM1Vl8qmdvoJ49nGuuWgln3x45FQJulUSmligjW05IE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783939908; c=relaxed/simple; bh=ztP+Lg5fklMhhuTpaIR9LJ0qNO0Jn8X8jfLGw8P7Y/8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DuLgKczDE4+0ynxWBbEfwk9bCe2ZbMkop9RN01TCtR4pLOI7+SunRoGBT1SOm7hYUBNlAkKuM86ONHSo1Es3//SCEKJHtTIWh36HXIH3pt9T4Gyo+R48ezRT7TvThsYa72qy/b1UoxwSCde1Z/clxlJlTzjlHJWqDf2os9ycQxE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Qu3pxmok; arc=none smtp.client-ip=74.125.224.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Qu3pxmok" Received: by mail-yx1-f97.google.com with SMTP id 956f58d0204a3-66780d9d901so3647347d50.0 for ; Mon, 13 Jul 2026 03:51:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783939905; x=1784544705; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=xAMD//Z3RnvPCQ/mYGTihmrUMMj+M8oLlYOH5HAiHag=; b=ITq6Fn7yJ7aMI9qnaAiR8phiCGo81jvqGOcc9UptxRRxVOwD+f/oeDvb5Xwe+u8om5 GyWvPIiri/iM4x3TBoHL2Zu3S7TxObiftfbLq0cBHhPkU7IBPU2cWzLt5ieH+QFcIlnu uMmmoTN/hhjd09NU7NVQMRgokS4hrOtAHGd/gHpvtliH0I9FsVKnIAey4KHKUL3bcLvw E7HZgnbkOlNQv2UycQC+b9LNbRGPqv6p5HJOVWE6MRQthfDlyZzTdIBNpy4hmNRM34U2 F2sto4Lrx5hdBxICGuhD+IIUF7DLNl7/jNmtAlEU7tSOB/fqgXDDrsiFWuT0VXz/uDWy pdNg== X-Forwarded-Encrypted: i=1; AHgh+RoqQURizCu8SSw7qoFaPQAE8gMfF786buPNi8O6rui+Png2jaMvstW0fQwtkGC3hD2p6sXJXliq0Iqt/Mk=@vger.kernel.org X-Gm-Message-State: AOJu0YwTtTGKZugE70Q1PvoEl0MqzCpwqB5Jntyfz7zt3EKCKqp0oPWx 7IyDjFK9rji27IVN7jP91pzekDhxPGnekE8Zev3wGA9Jc2oq/1wxkbBQVpt8z/IzS8s43TprH1W unR2MlTkr46ZOiEn9pf25OyMprWUnbXexOAdOYCCUyL2B3N9b+/5BPmMcO8TfVE2f9N++bLrYm5 8qMZGf1cUT8Q8dpz8TNIGbyQfICIj2uRh5+muzinSkia10kENiKpOS+4p/M1ySAeF+rhNRQyP+n gsb8jNCyp7OiF15R6yTsXRDTA== X-Gm-Gg: AfdE7cmt76BUmiP99W1/bj7NLnxH7gCGPkXtButqKe/MnQXv4wMIAhchcuxVZUvcAiU 6bDdf+RvLVZBTEdf3mhmnRj9rhPxIyS3gCxPkIalzw4Hwilg3LUrjTyX4pkph96iCQuRroE75pf w494JyGAoxwjTPxRusUc5mTKSNGIozDnrUOjlaenTlHakAc9V/bMqVn0MRLLFZxEom9oTcs9VaV /H/JPUN9J3Zoqp/uHAQs6GgjKV22FKtDvZoaeKXIhqSASPyg7sJJU7ESCVzK/kiaFRn0LSV1kGB 26EhC+MfkkXiORzdMFCtxdHxtWaphR+BvhfGyVQmyKCUWZ/YZ8yTex2cYVmtnBksX6M8m3Ct7P2 9LB5xI7lXezvN+WDPtzvMOCzQ8pLuOQEF9ViwQGJf3kdSh+Ovp7zrWbO9/6i0LhPAQB06aLk69R ondwW2LqgqJOmrYl4C3/3eS/pTJkX79Twi8VF0s7r1LosZvf0= X-Received: by 2002:a05:690e:1447:b0:666:80dc:aa51 with SMTP id 956f58d0204a3-667d7ac1db3mr5915448d50.23.1783939905213; Mon, 13 Jul 2026 03:51:45 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-0.dlp.protect.broadcom.com. [144.49.247.0]) by smtp-relay.gmail.com with ESMTPS id 956f58d0204a3-667fe86fafbsm19547d50.8.2026.07.13.03.51.44 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Jul 2026 03:51:45 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-90410c668adso38813666d6.1 for ; Mon, 13 Jul 2026 03:51:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1783939904; x=1784544704; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=xAMD//Z3RnvPCQ/mYGTihmrUMMj+M8oLlYOH5HAiHag=; b=Qu3pxmokRpr0dUl75Pybfv4F386T9ikvdUa6cDG+5ZmSIJ/J+hV/oqxmpAFWCxmTbS i/1mI20PdWUWHtMV9Szt9UXqUfYxPtB6rPPesJkknaqbYrhRDMa7n7kGA1sVwOPCYKOp TNmEKpbVIHcInRyZ0Q34StMzSHY2vlckNmJHs= X-Forwarded-Encrypted: i=1; AHgh+RqDDR7O2MGtLZmt8TPCRtnEHDgFDHMCg/ehjKM3D1/ibI54TLQG6159M6Rhq+mYM9JYrSx7a5GKMGieqpE=@vger.kernel.org X-Received: by 2002:a05:6214:238d:b0:8f2:67bb:a37d with SMTP id 6a1803df08f44-9040471eca3mr96339696d6.57.1783939904503; Mon, 13 Jul 2026 03:51:44 -0700 (PDT) X-Received: by 2002:a05:6214:238d:b0:8f2:67bb:a37d with SMTP id 6a1803df08f44-9040471eca3mr96339506d6.57.1783939904024; Mon, 13 Jul 2026 03:51:44 -0700 (PDT) Received: from [10.176.2.203] ([192.19.176.250]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ffd7c1d3acsm124246046d6.24.2026.07.13.03.51.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2026 03:51:43 -0700 (PDT) Message-ID: <36f4388a-b856-438c-8ef4-795a7b1eda3e@broadcom.com> Date: Mon, 13 Jul 2026 12:51:45 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: brcmfmac: set F2 blocksize to 256 for BCM43752 To: LiangCheng Wang , Kalle Valo , Angus Ainslie Cc: Wig Cheng , linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260713-b43752-f2-blksz-v1-1-8697fcfeaef4@gmail.com> Content-Language: en-US From: Arend van Spriel In-Reply-To: <20260713-b43752-f2-blksz-v1-1-8697fcfeaef4@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 13/07/2026 10:50, LiangCheng Wang wrote: > The BCM43752 is not reliable with the default 512-byte SDIO function 2 > block size: on an i.MX8MP board with an AMPAK AP6275S module at > SDR104 / 200 MHz, an iperf TX stress test kills WLAN within seconds: > > mmc_submit_one: CMD53 sg block write failed -84 > brcmf_sdio_dpc: failed backplane access over SDIO, halting operation > > Commit d2587c57ffd8 ("brcmfmac: add 43752 SDIO ids and initialization") > set up the 43752 like the 4373 for the F2 watermark but missed the F2 > block size, which the 4373 limits to 256 bytes. The vendor driver > (bcmdhd) also programs a 256-byte F2 block size for this chip and runs > the same hardware without errors. > > Group the 43752 with the 4373, matching the F2 watermark handling. > With this change a 10-minute bidirectional iperf3 soak completes with > zero SDIO errors at ~270 Mbit/s in each direction. > > Fixes: d2587c57ffd8 ("brcmfmac: add 43752 SDIO ids and initialization") > Cc: stable@vger.kernel.org # <= 6.16 needs the CYPRESS_43752 id name Looks good to me but the stable instruction looks confusion. What do you mean. If there is no 43752 support there is no need for this patch, right? Regards, Arend > Signed-off-by: LiangCheng Wang > ---