From: bot+bpf-ci@kernel.org
To: a.s.protopopov@gmail.com,ast@kernel.org,daniel@iogearbox.net,andrii@kernel.org,eddyz87@gmail.com,memxor@gmail.com,almagui@kernel.org,john.fastabend@gmail.com,qmo@kernel.org,brauner@kernel.org,kpsingh@kernel.org,yonghong.song@linux.dev,jolsa@kernel.org,emil@etsalapatis.com,ihor.solodrai@linux.dev,sashal@kernel.org,bpf@vger.kernel.org,linux-kernel@vger.kernel.org
Cc: a.s.protopopov@gmail.com,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,mason@kernel.org,ihor.solodrai@linux.dev
Subject: Re: [PATCH v3 bpf-next 08/18] bpf: Add the bpf_scan_ir LLVM plugin
Date: Wed, 11 Nov 2026 08:21:47 +0000 (UTC) [thread overview]
Message-ID: <36f85a8b94e7329f1afbb7d5eef1eb2e4dd197b1fe5e46e1cb2f7ce7fb8b4912@mail.kernel.org> (raw)
In-Reply-To: <20261110164046.454431-9-a.s.protopopov@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1563 bytes --]
> bpf: Add the bpf_scan_ir LLVM plugin
TL;DR: Nit only: with the plugin enabled, link-vmlinux.sh adds --emit-relocs
to the .tmp_vmlinux1 link, so two existing comments (top-level Makefile,
vmlinux_link()) now say the opposite; they should be updated.
> diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
> index d5710e900bd4..f39e2d1f1400 100755
> --- a/scripts/link-vmlinux.sh
> +++ b/scripts/link-vmlinux.sh
[ ... ]
> @@ -89,6 +89,13 @@ vmlinux_link()
> ldlibs=
> fi
>
> + if is_enabled CONFIG_CLANG_PLUGIN_BPF_SCAN_IR; then
> + if [ "${output}" = ".tmp_vmlinux1" ]; then
> + ldflags="${ldflags} ${wl}--emit-relocs"
This isn't a bug, but two existing comments now say the opposite of what
happens here.
The top-level Makefile says:
# --emit-relocs is added by scripts/link-vmlinux.sh, for the final link only.
and a few lines below this block, vmlinux_link() says:
# Only the final link actually requires the relocations.
With the plugin enabled, the .tmp_vmlinux1 link also gets --emit-relocs, and
on arm64 it gets it without --discard-none.
Could both comments be updated to mention the .tmp_vmlinux1 case?
> + else
> + ldflags="${ldflags} ${wl}--script=${srctree}/scripts/bpf/fmodret.lds"
> + fi
> + fi
> ldflags="${ldflags} ${wl}--script=${objtree}/${KBUILD_LDS}"
>
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/42981885558
next prev parent reply other threads:[~2026-11-11 8:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 16:40 [PATCH v3 bpf-next 00/18] Auto-detect BPF fmodret targets Anton Protopopov
2026-11-10 16:40 ` [PATCH v3 bpf-next 01/18] bpf: Add BTF ID sets for fmod_ret targets Anton Protopopov
2026-11-11 8:01 ` bot+bpf-ci
2026-11-10 16:40 ` [PATCH v3 bpf-next 02/18] bpf: Add a btf_id_set8_entry helper Anton Protopopov
2026-11-10 16:40 ` [PATCH v3 bpf-next 03/18] bpf: Build fmod_ret target sets from BTF decl tags Anton Protopopov
2026-11-10 16:40 ` [PATCH v3 bpf-next 04/18] selftests/bpf: Declare bpf_fentry_test1 in tracing tests Anton Protopopov
2026-11-10 16:40 ` [PATCH v3 bpf-next 05/18] bpf: Declare fmod_ret targets with BTF_FMODRET sets Anton Protopopov
2026-11-10 16:40 ` [PATCH v3 bpf-next 06/18] selftests/bpf: Test fmod_ret BTF decl tags and attach permission Anton Protopopov
2026-11-10 16:40 ` [PATCH v3 bpf-next 07/18] scripts: Add LLVM plugin infrastructure Anton Protopopov
2026-11-10 16:40 ` [PATCH v3 bpf-next 08/18] bpf: Add the bpf_scan_ir LLVM plugin Anton Protopopov
2026-11-11 8:21 ` bot+bpf-ci [this message]
2026-11-10 16:40 ` [PATCH v3 bpf-next 09/18] bpf: Find fmod_ret candidates in bpf_scan_ir Anton Protopopov
2026-11-10 16:40 ` [PATCH v3 bpf-next 10/18] bpf: Allow writes to private stack objects " Anton Protopopov
2026-11-10 16:40 ` [PATCH v3 bpf-next 11/18] bpf: Follow PHIs " Anton Protopopov
2026-11-10 16:40 ` [PATCH v3 bpf-next 12/18] bpf: Follow integer casts " Anton Protopopov
2026-11-10 16:40 ` [PATCH v3 bpf-next 13/18] bpf: Check the return values of fmod_ret programs on found targets Anton Protopopov
2026-11-11 8:21 ` bot+bpf-ci
2026-11-10 16:40 ` [PATCH v3 bpf-next 14/18] bpf: Require the JIT for fmod_ret programs on found 64-bit targets Anton Protopopov
2026-11-10 16:40 ` [PATCH v3 bpf-next 15/18] resolve_btfids: Tag fmod_ret candidates as targets Anton Protopopov
2026-11-11 8:21 ` bot+bpf-ci
2026-11-10 16:40 ` [PATCH v3 bpf-next 16/18] selftests/bpf: Test fmod_ret candidates found by bpf_scan_ir Anton Protopopov
2026-11-10 16:40 ` [PATCH v3 bpf-next 17/18] selftests/bpf: Enable bpf_scan_ir in the config Anton Protopopov
2026-11-10 16:40 ` [PATCH v3 bpf-next 18/18] bpftool: List and show fmod_ret targets Anton Protopopov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36f85a8b94e7329f1afbb7d5eef1eb2e4dd197b1fe5e46e1cb2f7ce7fb8b4912@mail.kernel.org \
--to=bot+bpf-ci@kernel.org \
--cc=a.s.protopopov@gmail.com \
--cc=almagui@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=ihor.solodrai@linux.dev \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=mason@kernel.org \
--cc=memxor@gmail.com \
--cc=qmo@kernel.org \
--cc=sashal@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®