Re: [PATCH] staging: rtl8723bs: Rename variables

[Julia Lawall <julia.lawall@inria.fr>]

On Tue, 25 Mar 2025, Erick Karanja wrote:

> Rename the variable `mediaStatus` to `media_status` and variable
> `lpsVal` to `lps_val` to adhere to Linux kernel coding
> standards by using snake_case instead of CamelCase.
>
> Fixes checkpatch.pl warning:
> 	CHECK: Avoid CamelCase: <mediaStatus>
> 	CHECK: Avoid CamelCase: <lpsVal>
>
> Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_btcoex.c | 14 ++++++--------
>  1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_btcoex.c b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> index d54095f50113..27dfd00b4249 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> @@ -8,14 +8,14 @@
>  #include <rtw_btcoex.h>
>  #include <hal_btcoex.h>
>
> -void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 mediaStatus)
> +void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 media_status)
>  {
> -	if ((mediaStatus == RT_MEDIA_CONNECT)
> +	if ((media_status == RT_MEDIA_CONNECT)
>  		&& (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) == true)) {
>  		rtw_hal_set_hwreg(padapter, HW_VAR_DL_RSVD_PAGE, NULL);
>  	}
>
> -	hal_btcoex_MediaStatusNotify(padapter, mediaStatus);
> +	hal_btcoex_MediaStatusNotify(padapter, media_status);
>  }
>
>  void rtw_btcoex_HaltNotify(struct adapter *padapter)
> @@ -52,21 +52,19 @@ void rtw_btcoex_RejectApAggregatedPacket(struct adapter *padapter, u8 enable)
>  void rtw_btcoex_LPS_Enter(struct adapter *padapter)
>  {
>  	struct pwrctrl_priv *pwrpriv;
> -	u8 lpsVal;
> -
> +	u8 lps_val;
>
>  	pwrpriv = adapter_to_pwrctl(padapter);
>
>  	pwrpriv->bpower_saving = true;
> -	lpsVal = hal_btcoex_LpsVal(padapter);
> -	rtw_set_ps_mode(padapter, PS_MODE_MIN, 0, lpsVal, "BTCOEX");
> +	lps_val = hal_btcoex_LpsVal(padapter);
> +	rtw_set_ps_mode(padapter, PS_MODE_MIN, 0, lps_val, "BTCOEX");
>  }
>
>  void rtw_btcoex_LPS_Leave(struct adapter *padapter)
>  {
>  	struct pwrctrl_priv *pwrpriv;
>
> -

You seem to have done something else here.

Were there two blank lines in the original code?

julia

>  	pwrpriv = adapter_to_pwrctl(padapter);
>
>  	if (pwrpriv->pwr_mode != PS_MODE_ACTIVE) {
> --
> 2.43.0
>
>
>