From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.bix.bg (mail.bix.bg [193.105.196.21]) by smtp.subspace.kernel.org (Postfix) with SMTP id 78A3638C434 for ; Mon, 2 Mar 2026 20:34:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.105.196.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772483684; cv=none; b=QSNxp+c09g0pz4S2F2jTtu0xuAf8undhAeWytnOsa2lwgFsDN/Cv6c5esiDiCnCt1i9CF+Acn3z/8Z06yBCwIe0tXPDjkRWM8ah+iWj349chAiGc5jqofb3QustfK74/CUv3ox5FpCHrRLiXDVZaIcG7L3Jct7/UvvhQOWKCGUk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772483684; c=relaxed/simple; bh=MSNT+vzSoz8JEVbz1InyC14pAK5t6L7YnAyF9maZEtQ=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=M2IyJdOJO4D1IhoW/BOXFmGwsyvpf3MNdlnLHnuu6cbswYTOl8ARKwPGYxeWbUKX9sk2qHF/uBiv1Mv2gg+vTGyR9LhJ+z0rZnyBD1RpxcrB+PuuCGmXIkiqgjXwlnGMDz6oZUEeDFafTMh9Pm0ASvN+tuuSo0feH8kJfheY51A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=declera.com; spf=pass smtp.mailfrom=declera.com; arc=none smtp.client-ip=193.105.196.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=declera.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=declera.com Received: (qmail 19022 invoked from network); 2 Mar 2026 20:34:33 -0000 Received: from d2.declera.com (HELO ?212.116.131.122?) (212.116.131.122) by indigo.declera.com with SMTP; 2 Mar 2026 20:34:33 -0000 Message-ID: <36f8df695463e5ff3eaaffbac357fc73026f7373.camel@declera.com> Subject: Re: [PATCH v5 2/2] mfd: simple-mfd-i2c: add a reboot cell for the SpacemiT P1 chip From: Yanko Kaneti To: Aurelien Jarno , linux-kernel@vger.kernel.org, Lee Jones , Sebastian Reichel , Troy Mitchell , Yixun Lan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , "open list:RISC-V ARCHITECTURE:Keyword:riscv" , "open list:RISC-V SPACEMIT SoC Support:Keyword:spacemit" , "open list:SYSTEM RESET/SHUTDOWN DRIVERS" Date: Mon, 02 Mar 2026 22:34:33 +0200 In-Reply-To: References: <20251102230352.914421-1-aurelien@aurel32.net> <20251102230352.914421-3-aurelien@aurel32.net> <990bc03ed2baa05e619f0aa9cc6a23acadd66ea6.camel@declera.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.59.3 (3.59.3-1.fc45) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hello, On Mon, 2026-03-02 at 21:08 +0100, Aurelien Jarno wrote: > On 2026-03-01 23:16, Aurelien Jarno wrote: > > On 2026-02-27 13:29, Yanko Kaneti wrote: > > > On Thu, 2026-02-26 at 22:32 +0100, Aurelien Jarno wrote: > > > > Hi, > > > >=20 > > > > On 2026-02-26 16:32, Yanko Kaneti wrote: > > > > > Hello, > > > > >=20 > > > > > On Mon, 2025-11-03 at 00:02 +0100, Aurelien Jarno wrote: > > > > > > Add a "spacemit-p1-reboot" cell for the SpacemiT P1 chip. > > > > > >=20 > > > > > > Signed-off-by: Aurelien Jarno > > > > > > --- > > > > > > v5: no changes > > > > > >=20 > > > > > > drivers/mfd/simple-mfd-i2c.c | 1 + > > > > > > 1 file changed, 1 insertion(+) > > > > > >=20 > > > > > > diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-= mfd-i2c.c > > > > > > index 0a607a1e3ca1d..542d378cdcd1f 100644 > > > > > > --- a/drivers/mfd/simple-mfd-i2c.c > > > > > > +++ b/drivers/mfd/simple-mfd-i2c.c > > > > > > @@ -99,6 +99,7 @@ static const struct regmap_config spacemit_p1= _regmap_config =3D { > > > > > > }; > > > > > > =20 > > > > > > static const struct mfd_cell spacemit_p1_cells[] =3D { > > > > > > + { .name =3D "spacemit-p1-reboot", }, > > > > > > { .name =3D "spacemit-p1-regulator", }, > > > > > > { .name =3D "spacemit-p1-rtc", }, > > > > > > }; > > > > >=20 > > > > > Perhaps its safe to merge this one now that everything P1 and I2C= is > > > > > already in linus tip ? > > > >=20 > > > > Unfortunately, this patchset is still missing: > > > > https://lore.kernel.org/all/20260207-b4-k3-i2c-pio-v7-0-626942d94d9= 1@linux.spacemit.com/ > > > >=20 > > > > This means the reboots work most of the time, but are not 100% reli= able,=20 > > > > and that's the reason why this patch got blocked from merging. > > >=20 > > > I see. Thanks. Sounds to me like sometimes working compared to never > > > working is better , but anyway.. > >=20 > > I agree with that, but the decision was to hold on this patch until the= =20 > > I2C PIO part got merged. > >=20 > > > FWIW with this patch and the pio patcheset I get this rcu splat on > > > reboot (which is still working). Similar splat is there without the p= io > > > patcheset. > >=20 > > I haven't been able to reproduce the issue here after 10+ reboots on a= =20 > > BPI-F3 board, but I tried the patch on top of 6.19. I'll try to build a= =20 > > 7.0.0-rc2 kernel and report back. >=20 > I have tried that, and I am still unable to reproduce the issue with a= =20 > 7.0.0-rc2 kernel and a BPI-F3 board. I can still see it on every reboot (with the patches that allow reboot to work). Do you have CONFIG_PREEMPT_RCU in your config ? its default on when anything PREEMPT is selected. In Fedora its CONFIG_PREEMPT_DYNAMIC that flips it. Regards Yanko