From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BE60C433EF for ; Tue, 14 Sep 2021 04:15:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 38E5E610A2 for ; Tue, 14 Sep 2021 04:15:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232256AbhINEQu (ORCPT ); Tue, 14 Sep 2021 00:16:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229478AbhINEQt (ORCPT ); Tue, 14 Sep 2021 00:16:49 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81872C061574 for ; Mon, 13 Sep 2021 21:15:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=kkVnv6BuGX82Yh9Od+36FMPLZ2st+Pigxo8qEI4xegw=; b=B/+snexSizUZY+3Xpfrz8dHjjK mQn+1RQcpDlZlh99+n35Cy6Uc/KhRt0ncLcjnn5FyQabcc4DWQfeIOeaM6loQOYoZd4o+bvfUKqn3 BjG3aqAkRIkhcEWKDQz1Q9dwtZaUKeuNtrWsVkDhjWfdUw7S/i17vDh8B0wGywuDh17ePhrbsQIrZ OoaeOr5vKvr6hWSzHjpNpr61Awj0wSY6FTkE19t/lpUHR02+766HDtTGV3GRnO+pXpZ8rV3PY3rFY C/KxKdgOySM/DchDRyxBP8A8V/u9vAZmUluK57U2eI8cwzIxvpBRMDPLhxGLOsuiyDaf6r2oRjUDb R76AktDw==; Received: from [2601:1c0:6280:3f0::aa0b] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPzqz-0049pw-Pq; Tue, 14 Sep 2021 04:15:29 +0000 Subject: Re: [PATCH] drm/rockchip: cdn-dp-core: Fix cdn_dp_resume unused warning To: Palmer Dabbelt , heiko@sntech.de Cc: hjc@rock-chips.com, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Palmer Dabbelt References: <20210115074043.2944-1-palmer@dabbelt.com> From: Randy Dunlap Message-ID: <36ff9f69-2c77-90ca-e2b5-f237f94a95a0@infradead.org> Date: Mon, 13 Sep 2021 21:15:29 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210115074043.2944-1-palmer@dabbelt.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/14/21 11:40 PM, Palmer Dabbelt wrote: > From: Palmer Dabbelt > > cdn_dp_resume is only used under PM_SLEEP, and now that it's static an > unused function warning is triggered undner !PM_SLEEP. This > conditionally enables the function to avoid the warning. > > Fixes: 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static") > Signed-off-by: Palmer Dabbelt > --- > drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c > index a4a45daf93f2..063a60d213ba 100644 > --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c > +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c > @@ -1121,6 +1121,7 @@ static int cdn_dp_suspend(struct device *dev) > return ret; > } > > +#ifdef CONFIG_PM_SLEEP > static int cdn_dp_resume(struct device *dev) > { > struct cdn_dp_device *dp = dev_get_drvdata(dev); > @@ -1133,6 +1134,7 @@ static int cdn_dp_resume(struct device *dev) > > return 0; > } > +#endif > > static int cdn_dp_probe(struct platform_device *pdev) > { > Acked-by: Randy Dunlap # build-tested Is someone going to merge this patch from January? thanks. -- ~Randy