From: David Howells <dhowells@redhat.com>
To: Sun Ke <sunke32@huawei.com>
Cc: dhowells@redhat.com, linux-cachefs@redhat.com,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-fsdevel@vger.kernel.org, jefflexu@linux.alibaba.com
Subject: Re: [PATCH v3] cachefiles: fix error return code in cachefiles_ondemand_copen()
Date: Wed, 24 Aug 2022 11:19:23 +0100 [thread overview]
Message-ID: <3700079.1661336363@warthog.procyon.org.uk> (raw)
In-Reply-To: <20220818125038.2247720-1-sunke32@huawei.com>
/* fail OPEN request if copen format is invalid */
ret = kstrtol(psize, 0, &size);
if (ret) {
req->error = ret;
goto out;
}
/* fail OPEN request if daemon reports an error */
if (size < 0) {
if (!IS_ERR_VALUE(size))
ret = size = -EINVAL;
req->error = size;
goto out;
}
Should ret get set to the error in size?
David
next prev parent reply other threads:[~2022-08-24 10:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 12:50 Sun Ke
2022-08-19 9:18 ` [Linux-cachefs] " Gao Xiang
2022-08-20 9:22 ` JeffleXu
2022-08-24 10:19 ` David Howells [this message]
2022-08-24 11:33 ` JeffleXu
2022-08-25 13:36 ` Dan Carpenter
2022-08-25 13:58 ` [Linux-cachefs] " Gao Xiang
2022-08-26 1:11 ` Sun Ke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3700079.1661336363@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=jefflexu@linux.alibaba.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sunke32@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®