From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4159BC2BA19 for ; Tue, 21 Apr 2020 09:12:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 278F820857 for ; Tue, 21 Apr 2020 09:12:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728373AbgDUJMq (ORCPT ); Tue, 21 Apr 2020 05:12:46 -0400 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]:48645 "EHLO out30-43.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726018AbgDUJMq (ORCPT ); Tue, 21 Apr 2020 05:12:46 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R711e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01419;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0TwDj0Hd_1587460361; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0TwDj0Hd_1587460361) by smtp.aliyun-inc.com(127.0.0.1); Tue, 21 Apr 2020 17:12:42 +0800 Subject: Re: [PATCH 04/18] mm: memcontrol: move out cgroup swaprate throttling To: Johannes Weiner , Joonsoo Kim Cc: Shakeel Butt , Hugh Dickins , Michal Hocko , "Kirill A. Shutemov" , Roman Gushchin , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com References: <20200420221126.341272-1-hannes@cmpxchg.org> <20200420221126.341272-5-hannes@cmpxchg.org> From: Alex Shi Message-ID: <37002d8a-1711-4ec7-af57-1072a397ced3@linux.alibaba.com> Date: Tue, 21 Apr 2020 17:11:35 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200420221126.341272-5-hannes@cmpxchg.org> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2020/4/21 ÉÏÎç6:11, Johannes Weiner дµÀ: > The cgroup swaprate throttling is about matching new anon allocations > to the rate of available IO when that is being throttled. It's the io > controller hooking into the VM, rather than a memory controller thing. > > Rename mem_cgroup_throttle_swaprate() to cgroup_throttle_swaprate(), > and drop the @memcg argument which is only used to check whether the > preceding page charge has succeeded and the fault is proceeding. > > We could decouple the call from mem_cgroup_try_charge() here as well, > but that would cause unnecessary churn: the following patches convert > all callsites to a new charge API and we'll decouple as we go along. > > Signed-off-by: Johannes Weiner Reviewed-by: Alex Shi