From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5278CC4167B for ; Tue, 5 Dec 2023 10:22:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344952AbjLEKWt (ORCPT ); Tue, 5 Dec 2023 05:22:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235028AbjLEKWr (ORCPT ); Tue, 5 Dec 2023 05:22:47 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B54790; Tue, 5 Dec 2023 02:22:53 -0800 (PST) Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id C34556602F1E; Tue, 5 Dec 2023 10:22:49 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701771771; bh=3U+2S6yFT5IinHlDHOnGowPBFs7ClJzaLOhopmK8tJk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=OYuCQ8kwdLnWkv1MfHToaXZ587QswHOutjKlfKfVYjCnU/s92pr8c3o9SnFkhf9BG Ji4lDYcYURVmRno7WIM+Ij42lFOpJD6ckjLuX6BZkwXXXUZ7cM5ErLHx/gOOJ3zwRR lLAdVr5MwcRSd96WdScV8w+5+I8XbztbTAMbi9Qlgou0pRMfrT50bHtA66RFzozoSI 1TwY5RvAbJBq78cU+3pbZR+kXl2hc3VhM6d9tly282icyqWUOqGDNRUKOPZhQzer3u gftavexdPt6RBGhr1ej4AKrch5TdmIjafkGQ2o6HvEUgPjXiD2JNSK5Ydr5172HmNn 7unW/WF969rzw== Message-ID: <3700f05f-2411-4422-972f-f3df690efb84@collabora.com> Date: Tue, 5 Dec 2023 11:22:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v3 4/5] arm64: dts: mediatek: mt8173-elm-hana: Mark touchscreens and trackpads as fail To: Doug Anderson , Chen-Yu Tsai Cc: Rob Herring , Frank Rowand , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , Wolfram Sang , Benson Leung , Tzung-Bi Shih , chrome-platform@lists.linux.dev, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold , Hsin-Yi Wang , Dmitry Torokhov , andriy.shevchenko@linux.intel.com, Jiri Kosina , linus.walleij@linaro.org, broonie@kernel.org, gregkh@linuxfoundation.org, hdegoede@redhat.com, james.clark@arm.com, james@equiv.tech, keescook@chromium.org, rafael@kernel.org, tglx@linutronix.de, Jeff LaBundy , linux-input@vger.kernel.org, linux-i2c@vger.kernel.org References: <20231128084236.157152-1-wenst@chromium.org> <20231128084236.157152-5-wenst@chromium.org> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 04/12/23 17:50, Doug Anderson ha scritto: > Hi, > > On Sun, Dec 3, 2023 at 10:59 PM Chen-Yu Tsai wrote: >> >> On Sat, Dec 2, 2023 at 8:58 AM Doug Anderson wrote: >>> >>> Hi, >>> >>> On Tue, Nov 28, 2023 at 12:45 AM Chen-Yu Tsai wrote: >>>> >>>> @@ -44,6 +46,7 @@ trackpad2: trackpad@2c { >>>> reg = <0x2c>; >>>> hid-descr-addr = <0x0020>; >>>> wakeup-source; >>>> + status = "fail-needs-probe"; >>> >>> While doing this, you could also remove the hack where the trackpad >>> IRQ pinctrl is listed under i2c4. >> >> Sure. I do think we can do away with it though. According to at least one >> schematic, the interrupt line has pull-ups on both sides of the voltage >> shifter. >> >> BTW, The touchscreen doesn't have pinctrl entries. This has pull-ups on >> both sides of the voltage shifter as well. > > I dunno if the convention is different on Mediatek boards, but at > least on boards I've been involved with in the past we've always put > pinctrl entries just to make things explicit. This meant that we > didn't rely on the firmware/bootrom/defaults to leave pulls in any > particular state. ...otherwise those external pull-ups could be > fighting with internal pull-downs, right? > MediaTek boards aren't special and there's no good reason for those to rely on firmware/bootrom/defaults - so there is no good reason to avoid declaring any relevant pinctrl entry. Cheers, Angelo