From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9FD1340A52 for ; Tue, 23 Jun 2026 08:54:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782204857; cv=none; b=skti3C7vAXqLRj1an/1JnQxx1M6moL2SY12tiiU5mOFKW9nV+3vFweQfWIvm1xU9DS4uEILZWfADVoQIQx2tDc/4xQrKc2c+kskUEoQ9yxo6WtF8UjbjRqsFAp4gCVfTEMhM2hOLN7OcaL58UamSsCk9lX8D0TEx3OiOnQoQ9jA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782204857; c=relaxed/simple; bh=UKPeFZkVjoN1f5cOoU9zC8RjUtGvrmqD0t/+VYvZqs4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=g8h6Fla7HGcEuIX6D0wPSRVllNUIDir0wRghf7zb5ZVfISQL5JdDXz4s7hgCSNcl/KzNl4TX1gelAV9+WW09szGk0q1jMB4aPUbwdNyU2zYSvUVdY4JWj+mrrQsKsfPUgItM/GHX7VaOMqeoV2jmlgan9pvXQ9XliTLsGxb97hw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dY63+Hl7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ETmjHYrd; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dY63+Hl7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ETmjHYrd" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65N6cW5X3338321 for ; Tue, 23 Jun 2026 08:54:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CSmLihCC6mZQWr5AxByQaYexpwIz57mc1SOGzHGUD3E=; b=dY63+Hl7lHY6DDfC wbdVJO8lUv0CVAgrHUtRCtn+WuBd0LqrsjAQDdXv+cp0eOIjIwxqQQRO6ivV97iC 3ZOp9wLemg5Cw36x+SiD6jpaDWK5jSkTB4LH5z9DaOuE5LEsJ/W9ZM3EowrqVp// FAPITVA8wPafSijfp+99umvyxWXKXYSymRrlwtOrWgC6oymjv0cATCTZvWNq+YJF SO0VLF+QqrkCYrQeArb964o80WCM2pwV3DsJwawV3CebamRh8Z2NgBfXG0I/5AlZ nMxoOYaWRgB+oUyGeFUAnMWf9Jrt5SM19hZHpCkdvL+qukrXda8DJ6JW1cM9RXpM PRoYyQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eygkjhdgg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 08:54:13 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-37d4eede8ccso2344697a91.0 for ; Tue, 23 Jun 2026 01:54:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782204853; x=1782809653; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CSmLihCC6mZQWr5AxByQaYexpwIz57mc1SOGzHGUD3E=; b=ETmjHYrdQIX7/8mmi8lrTVZYWBEtbc/1PhypjlslEMfOogmlUMMjiNRV5QMaFbv5LR 36dkbfx4X3LLYI9yEhMzBfFC3iRf6uGpxmHOGJKzgXy0jfKfcHAsAuNUmmFbzPfcJEz9 nwHUmzeWUAedWXJieXBJOrKx2QXDO319P6tDSNXgmC31RKuzdTDpHTawD43NllesG/jw NYOYQqMFBhM6SclMwTv3FrZ35pG6uctsF6VwLo90Rio0EfFUmdRhhNp++ieSTPBKL8Nw njCwVKPqYc+afKs/LIHQylLl5L0B29+Yb5Kpcjl33vXxErofTBYVizxWjfzZewdUD86m 8qwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782204853; x=1782809653; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CSmLihCC6mZQWr5AxByQaYexpwIz57mc1SOGzHGUD3E=; b=L4wF2NedqdTjtcIimNW38S8MrH5zCQcv69QxKr3vGGF4R2IJq7oTNg8Q6XqMi1VYP7 WLrFrgtcH5dwige8VX5prQ3Aazzx/M4ZV6HdkmhyVbcXt7EY3MWYUmB9mJ4RkM85ZXjy vXefER+FM+0yibzt3dqrx66SAH5rMOknoZ5jKB2qX1eVu4cu0bc/KVD1hJzTzSG6aCmO MM/I+S0QT4leiCxCPbIWzVsBgygAX9FYf98mko+xTbtMGgLA5vBwPKi83ZBx7wq/tTYh KNQgWzQW9SlNUW+0OVrPrsn3qAzLSe+ZMaaep1Zvzg6IPvMmHtyc9a78Ruz6drGpub2n hYWQ== X-Forwarded-Encrypted: i=1; AHgh+Rpcdrbrfr6RBJ235gpBa9AiB39qyyLnJmz6aW7fx8cwspUvAa89EJ7biiDhOD0YgLtMqYGoeVliZFDfCCA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxo2FE4fA99XDACjb6nQjOm6P5GxzZRj0qJxRHibjQ904zsSN4M DyIODykLf9fDEphD64uW3KIX9Q/V9PIc/xlKPi3jOfVsOBTpjV6D6ONaeFMcOrUrW5pxSQrbkcQ ubJPcRbPKGvYmWWOpizkypL6JLj7JcRbq/XB2BkDYL1FI7EbjOCWphQvYQxkgwCUJvkE= X-Gm-Gg: AfdE7cl+XrdTCUZ9L1R862N+ViYCRCZ2kJfy7pRj3cen3ue4u09N3A6xVwhG9+hdrcd odzk27yiDBaUjYDiFBR+83VXg4htOSBXmhuPbKMGsQ7rfcYGYQDcguffFXUmOCB0ceFL6iqgPn1 VVlc6gXEtd9Q5V/IR1YAni1VtZfjF3+KmTueCWaLB55P5vEAOyckyV/bJtZhdqOJ7YnX4Y6LaV3 dfQO68AA2qrUm5Z8DV4ebU/jCYQIPwht5IelKTDDSB2KMdr6JXkl9D8HGLfVGysR0IY64wHLzsv BmNp2ZoauDCpad3WN/hJZl0POCsEMkvPEJJ3RYlPsHqlBOD3rnNtU3dMz2AHc6PgzgIXoK2VOkP YqTc84ylqk8HlRPHnbnK5AsZbALjtzZ3jo90iDMqGDInq X-Received: by 2002:a17:90b:35cf:b0:36b:8baa:a683 with SMTP id 98e67ed59e1d1-37dd176c01dmr1791510a91.19.1782204853000; Tue, 23 Jun 2026 01:54:13 -0700 (PDT) X-Received: by 2002:a17:90b:35cf:b0:36b:8baa:a683 with SMTP id 98e67ed59e1d1-37dd176c01dmr1791480a91.19.1782204852457; Tue, 23 Jun 2026 01:54:12 -0700 (PDT) Received: from [172.20.10.7] ([106.192.20.130]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37d15de53ffsm12654566a91.12.2026.06.23.01.54.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 01:54:12 -0700 (PDT) Message-ID: <3705ac5e-7e9c-43ec-bd1f-9757445984b3@oss.qualcomm.com> Date: Tue, 23 Jun 2026 14:24:01 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] dt-bindings: sound: add qcom,wsa885x-i2c To: Linus Walleij Cc: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , Bartosz Golaszewski , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org References: <20260610155708.151067-1-prasad.kumpatla@oss.qualcomm.com> <20260610155708.151067-2-prasad.kumpatla@oss.qualcomm.com> Content-Language: en-US From: Prasad Kumpatla In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA3MSBTYWx0ZWRfX2oYWKQ5HUoTw WueAhMBwtFJ/Y34g8ttFYF33Lqv1uMjkThOe+Ib+jYB/51KO5ZRkG8ERTd70FGnwwKBJOoJOj55 JU02Yq51M43+d+vxOW7+UVJzNP0Wv9A= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA3MSBTYWx0ZWRfXzMen/H8osldc PxlU2DtUPmwVmKvrMbCUas3n4MGfR19dY5ihare/PFPxHvaWBLtBIgkPq57DA5LbSnC1TQIub4e YqxrOX6KYCtfypwmoFawdP/F1BGH1s2gxfQ7UNtTyvbh4thGLp1Xye+JjqoEAJ8UrAcZJh+uiWS JSG4Nby9A1Lz04wYkrEuYPUlO1D0qO9SHrJBuf68otENGlOkVHFFHLsLFbg5bqG0L4+hvc3QFV3 vcK+VIanf71OkHKxP64KXfr3vIG6VApChehMnrscBrKGmrIPkx1K06PLj+acLh8dSPd6tie/FDi G22EATf8kOB/D811oAcDOgQ49m+z52Fe5gekMdUeOVMXWn8qJEMjzTetghn+9SZ9brw6voID6lE ekA3OSG6FGV9oEBKw+WSDvFYELKOjQ== X-Proofpoint-GUID: WdDtId7Sc7uTNV6Vt7DRN1u4X23gYwyQ X-Authority-Analysis: v=2.4 cv=SoKgLvO0 c=1 sm=1 tr=0 ts=6a3a49b5 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=GtHFPjVsJ1z6j8OeKiQY1g==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=gEfo2CItAAAA:8 a=K5i35rRROUDlzIanDXoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 a=sptkURWiP4Gy88Gu7hUp:22 X-Proofpoint-ORIG-GUID: WdDtId7Sc7uTNV6Vt7DRN1u4X23gYwyQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_02,2026-06-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230071 On 6/11/2026 2:50 AM, Linus Walleij wrote: > Hi Prasad, > > thanks for your patch! Hi Linus Walleij, Thanks for reviewing the patch and for the feedback. > > On Wed, Jun 10, 2026 at 5:57 PM Prasad Kumpatla > wrote: > >> Document the Qualcomm WSA885X I2C smart amplifier binding. > Skip I2C? We don't need to tell e.g. "PCI" in some device on PCI and > there is no reason to mention I2C for this device, the fact that it sits > on an I2C bus will be apparent later. Ack, Will rename the file name. > >> Describe the required supplies, powerdown and interrupt GPIOs, the >> optional battery configuration, and the optional init-table property >> used to program the device during codec initialization. >> >> This matches the driver programming model and documents the DT data >> needed to use the codec on platforms with Audio IF playback. >> >> Signed-off-by: Prasad Kumpatla > Perhaps add > Link: https://www.qualcomm.com/audio/applications/compute-and-mobile-audio/products/wsa8815 > > (...) Checking internal to get product Doc to publish. >> --- >> .../bindings/sound/qcom,wsa885x-i2c.yaml | 89 +++++++++++++++++++ >> 1 file changed, 89 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/qcom,wsa885x-i2c.yaml >> >> diff --git a/Documentation/devicetree/bindings/sound/qcom,wsa885x-i2c.yaml b/Documentation/devicetree/bindings/sound/qcom,wsa885x-i2c.yaml > Drop the -i2c suffix on the files. Ack, Will update. > >> new file mode 100644 >> index 000000000..1069f470d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/qcom,wsa885x-i2c.yaml >> @@ -0,0 +1,89 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/sound/qcom,wsa885x-i2c.yaml# > Drop the -i2c suffix. Ack, Will update. > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm WSA885x I2C smart speaker amplifier > Drop I2C. Ack, Will update. > >> +maintainers: >> + - Srinivas Kandagatla >> + - Prasad Kumpatla >> + >> +description: | >> + WSA885x is a Qualcomm Aqstic smart speaker amplifier with an I2C control >> + interface and a digital audio interface exposed through ASoC DAI callbacks. >> + >> +allOf: >> + - $ref: dai-common.yaml# >> + >> +properties: >> + compatible: >> + const: qcom,wsa885x-i2c > Drop -i2c Ack, Will update. > >> + reg: >> + maxItems: 1 >> + >> + '#sound-dai-cells': >> + const: 0 >> + >> + powerdown-gpios: >> + description: GPIO controlling the SD_N powerdown pin. >> + maxItems: 1 >> + >> + interrupt-gpios: >> + description: GPIO used for the codec interrupt output. >> + maxItems: 1 >> + >> + vdd-1p8-supply: true >> + >> + vdd-io-supply: true >> + >> + qcom,battery-config: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: Speaker battery configuration, 1 for 1S and 2 for 2S. > What is a "1S" and a "2S"? Include description here. Ack, Will Update more details for 1s and 2s in next version. > >> + default: 1 >> + enum: [1, 2] >> + >> + qcom,wsa885x-init-table: >> + $ref: /schemas/types.yaml#/definitions/uint32-array >> + minItems: 2 >> + maxItems: 256 >> + description: | >> + Sequence of register/value pairs applied during codec hardware >> + initialization. Entries are encoded as alternating register address and >> + register value cells. The number of entries must be even (register/value >> + pairs); maxItems is 256 (128 pairs). > Can this just be a table inside the driver, if it will be the same > array for every user? If this is board-unique then it needs to describe > what each value is actually doing well enough so engineers can use this > documentation right here to configure their board without looking through > register maps and what not. > > Something more abstract using SI units etc is probably needed here. These values are part of a fixed hardware initialization sequence and are not board-specific. I'll move them into the driver as a register table, making them easier to maintain and avoiding opaque DT data. Thanks, Prasad > > Yours, > Linus Walleij