From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755564AbcIMKda (ORCPT ); Tue, 13 Sep 2016 06:33:30 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:64982 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbcIMKd3 (ORCPT ); Tue, 13 Sep 2016 06:33:29 -0400 From: Arnd Bergmann To: Peter Chen Cc: Greg Kroah-Hartman , Peter Chen , Felipe Balbi , Heikki Krogerus , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON Date: Tue, 13 Sep 2016 12:32:54 +0200 Message-ID: <3708710.f6PqhfJbOg@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20160913085005.GA30760@b29397-desktop> References: <20160912153649.3163096-1-arnd@arndb.de> <21754633.f6gFxZW7VA@wuerfel> <20160913085005.GA30760@b29397-desktop> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:CCy0Q90JtWjhqWwxzH27X6pBIqGkXiQeurOWqUMNN3VAxv1txEt V8EVWTAY3UMsaAUVaSUJXsiv+nq4TC66zZVRzEeRYHBuKXVHt/P5qKnvA4KKfPZR0Il9IF5 QeRyELuxGhXK07FHfMSMkiSolAJoPaOCdH9uZ6bqvai0/P8Z/33voT3EbrSy9h0DLaLldZZ w42npqDmzSX3hkHeLQ8Hw== X-UI-Out-Filterresults: notjunk:1;V01:K0:VnzRS8a7gzk=:81qkPvTWPafwlEvo6LUp6a eiluiCPmxLv0RNEFMa+0h2efSyg/V/olxDITf5FZUfHQXIn0H8+VFxMLRh2x8MqfcnrTF/m9B kuWJCdQZ8eRqtu5raNDC9ZCp8q+yjAXIdcC1oEcrMa8sxX1i2f+EegDMxNZGPpCHkYyXo5zLE 9qDeudCCcG3fqfuBt7g+gtWqGOQ7hM+kuwoXQK6LL3YRxHvsLuWDXP2mTSr2QLU7kidhummqw 6NEtrEWNt6JCGwYZ4yGPm0LlrVa0E0fmZBi4VijE0QCSa4SYchTema5icCPSiUT+DWbvbq+yS 28bbwfQhS3xzkCS3r6uIRQsAApWWaKF/GjPkYUVNZip4+b2cXNscNifnh7ukxmvf3XD409iG4 seLHpI4vk2itozdJVslFrqcaz5aBFXNMpgzKbcXLPYU+xJoHakWcvbOj5GcYcOUduV1sJZnbu xYEBZzMCnjwa0AWY8mWxJinwBPGygQ1ibSP2p9TBmuVxgZ1VY7RAnxPIepUs0Khu4CbEZF6U3 3dbVASKwYH2uHyjza4JeSUnXkSNRS8gxhZ87jK8Sf0zsySJcpD/HayP3DShWfrfJQhb43rKCj Emzi7NCJTJZzUJnD64045AaMlD4iPaULVzpXdGHcD4Slz7gQ1j4jK6kfYcsdlTiKX0iNkuVei 1RsbUmPLt+8Ri/tAG1JTHU40RBSekGcun+azyZ3ytcPrCrFild9PyakIh2zxQWzLnV2P9mBbS wEpgb2UnCeYkLrsM Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, September 13, 2016 4:50:05 PM CEST Peter Chen wrote: > On Tue, Sep 13, 2016 at 09:36:39AM +0200, Arnd Bergmann wrote: > > On Tuesday, September 13, 2016 3:19:42 PM CEST Peter Chen wrote: > > > > > > I just see below Kconfig entry at the same Kconfig > > > (drivers/usb/Kconfig), and forget your changes. > > > > > > config USB_LED_TRIG > > > bool "USB LED Triggers" > > > depends on LEDS_CLASS && USB_COMMON && LEDS_TRIGGERS > > > help > > > This option adds LED triggers for USB host and/or gadget activity. > > > > > > Say Y here if you are working on a system with led-class supported > > > LEDs and you want to use them as activity indicators for USB host or > > > gadget. > > > > > > Just grep it, some Kconfig still uses depends on for USB_COMMON, let me > > > change it together. > > > > > > > I suspect this one above should instead depend on "USB_SUPPORT". > > > > No, it is embraced by "if USB_SUPPORT", so we don't need to add it > additionally. Right, makes sense. > Even USB_SUPPORT is chosen, the USB_COMMON may still > not be chosen, so we need let USB_LET_TRIG select USB_COMMON > explicitly. My thought was that all users that could possibly call the USB_LED_TRIG interfaces already rely on USB_COMMON to be present. There is probably no real downside in having the 'select USB_COMMON', but it shouldn't actually be needed. It would be somewhat unusual though to enable USB_LED_TRIG and not build the file because we don't enter the directory, so maybe it's better to have it after all. Arnd