From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
To: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
Cc: gregkh@linuxfoundation.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, davidm@egauge.net,
~lkcamp/patches@lists.sr.ht, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: usb: maxim,max3421: convert to DT schema
Date: Mon, 8 Dec 2025 03:59:50 +0100 [thread overview]
Message-ID: <370bde1d-75f1-4ae2-a720-07fac8afaf5d@oss.qualcomm.com> (raw)
In-Reply-To: <de0b9059-30c0-4704-b0b8-9f4f5abfaa04@gmail.com>
On 06/12/2025 14:38, Rodrigo Gobbi wrote:
> On 11/7/25 05:03, Krzysztof Kozlowski wrote:
>>
>> You commit msg explain any unusual changes - like modifying binding
>> while ONLY converting it - and WHY you are doing the unusual changes.
>>
>> Best regards,
>> Krzysztof
>>
>
> Hi, Krzysztof,
> I was wondering about this again and I need to clarify the expectations here.
> So my v2 patch is only doing the conversion from txt to yaml without any additional
> changes. That being said, at v2, there are no new properties and no unusual changes.
>
> What happened was that under the ---, in order to save the lore and the previous discussion
> from v1, I`ve quoted the sentence about the "maxim,vbus-en-pin" prop from v1. Here, at v2,
> what I meant under the --- was that the "maxim,vbus-en-pin" was not new and it already existed
> in .txt file and the driver is already expecting that.
>
> So, even if I send a v3, it will be exactly the same direct conversion with the same commit msg
> because nothing was changed from txt.
> Maybe my intention was not right, my idea was to just save the lore/"answer" a previous point
> raised inside ---.
>
> Tks and best regards.
Indeed, I think I misread or went too fast through your changelog.
Everything looks correct, thanks for clarification.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-08 2:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 0:06 Rodrigo Gobbi
2025-11-07 8:03 ` Krzysztof Kozlowski
2025-12-06 13:38 ` Rodrigo Gobbi
2025-12-08 2:59 ` Krzysztof Kozlowski [this message]
2025-12-08 3:00 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=370bde1d-75f1-4ae2-a720-07fac8afaf5d@oss.qualcomm.com \
--to=krzysztof.kozlowski@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=davidm@egauge.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rodrigo.gobbi.7@gmail.com \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®