From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753250AbbKMMmp (ORCPT ); Fri, 13 Nov 2015 07:42:45 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:51366 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750760AbbKMMmn (ORCPT ); Fri, 13 Nov 2015 07:42:43 -0500 From: Arnd Bergmann To: Jisheng Zhang Cc: daniel.lezcano@linaro.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] clocksource/drivers/dw_apb_timer: Use {readl|writel}_relaxed Date: Fri, 13 Nov 2015 13:42:09 +0100 Message-ID: <3713227.4t0cg6qNF9@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1447417883-7881-1-git-send-email-jszhang@marvell.com> References: <1447417883-7881-1-git-send-email-jszhang@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:+iqcecFcHKNlZauvCIiNPBNGK/q0pPFtfcK0dMSmPtNR01THKOc rz9b2ifdqxUq0fHDQRxrELFudxJIyEUYQKBfeBCLnavBqavA9t8jRD+LKe1cvfIKhv4NQAm a6aP5bn0wXJpKUMRxVtQDhLBrCNSSRvPJu/qHTIhlkddIY3F7EH26v9Rb9aZwlxjCNpFnhm VsWShElMIhNKvKkhVYDmg== X-UI-Out-Filterresults: notjunk:1;V01:K0:j7QfIkvcz88=:N0Ap8Ne529arnsASRUaW9e KECAwOlfF9W16O45JIJwCn2vtMALpEnhuUEp9LsX9ygdg+axpzuW30SxKF2L+8IDfD6wCnHd/ S1JC1PWo0yF0+Rp4xqoWzDHCW8KUvnnWd0rn8tvZzqSKWDL1U9bp9sCXAjmnr/0tubG5qfOny iuTOur7jyW/mLnLzuJTGlHdyN/kaUlLgm2/Pm8sYGqU1iz6b2GMu22YoKWthA8e6srj6TGM3H 2sYvgo2Drb2dqiwzdNpmQaCnLV7IOdvYjpMD3l8NRAgeo7P/HGw6txSHRDNUeBURVXZ5fCG+T RrhfFtOc1ToGMlDt8Gk7hva1pcoIesNExqkK6bzEbihyOBU87u+O9NbWTVkWAxDs9B381aCTr lFUrAkrzEUMqjAjvDFr1qui7I8Ga2Gf8qhKowi+jB8e3GsJA9+8tS15XCwWfrfbSS5VKIvXfA +oI1QJ+TtHnuYqwu8VNvTIFylj1H6WgpcyUAXUNAon2Fu7Esf6W7eGwTXyMrOGjbytT5P7LpO 4y4gUcod5OcFLGMOPli3jycN29fX+XQMUomTjLGtWOuE6lJorciJI3pE5AOa7wt0YfDB7ZCHm vTyYcGwV7CIiwqJ3Lj1mTOuZYG4Eraq/EQ8pLbXsOcAsxmc6Wg+eldsdL7aa391/7gq9pzMvR OhGZRLYpf9y38pi97I81e2kKhpCc1M7Rdc+mpDX6NYMQZAUkDDXKu70tBLbnATqCmGD+7au9O y5WAkdnCIZvnrlXD Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 13 November 2015 20:31:23 Jisheng Zhang wrote: > diff --git a/drivers/clocksource/dw_apb_timer.c b/drivers/clocksource/dw_apb_timer.c > index c76c750..04282ee 100644 > --- a/drivers/clocksource/dw_apb_timer.c > +++ b/drivers/clocksource/dw_apb_timer.c > @@ -51,13 +51,13 @@ clocksource_to_dw_apb_clocksource(struct clocksource *cs) > > static unsigned long apbt_readl(struct dw_apb_timer *timer, unsigned long offs) > { > - return readl(timer->base + offs); > + return readl_relaxed(timer->base + offs); > } > > static void apbt_writel(struct dw_apb_timer *timer, unsigned long val, > unsigned long offs) > { > - writel(val, timer->base + offs); > + writel_relaxed(val, timer->base + offs); > } > > As with the other patch, I think it would be nicer to only change the functions that benefit from the change, to make it easier to prove that the conversion is correct. You could introduce apbt_readl_releaxed() etc functions and call them from __apbt_read_clocksource() and apbt_next_event(). Arnd