From: Valdis.Kletnieks@vt.edu
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Alan Cox <alan@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] HID: fix tty<->hid deadlock
Date: Thu, 04 Sep 2008 20:03:26 -0400 [thread overview]
Message-ID: <3717.1220573006@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Thu, 04 Sep 2008 17:16:07 +0200." <1220541367-10984-1-git-send-email-jirislaby@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 924 bytes --]
On Thu, 04 Sep 2008 17:16:07 +0200, Jiri Slaby said:
> hid_compat_load() runs on the default workqueue, it request_module(), it
> execs modprobe, it exits, tty flushes default workqueue, it hangs, because
> we are still in it.
>
> I haven't run into it since there always was at least one opener of the tty,
> I guess. Could you try the patch below?
>
> --
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> ---
> drivers/hid/hid-core.c | 11 ++++++++++-
> 1 files changed, 10 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 92c16e1..18d952a 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
With this patch applied, the kernel behaves as expected for my config: it
requests a 'modprobe hid_dummy', which prints a nasty message about being
unable to find it on the initrd, and then we continue with the boot.
Thanks for the quick fix...
[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]
next prev parent reply other threads:[~2008-09-05 0:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <48BFFAE0.5010001@gmail.com>
2008-09-04 15:16 ` Jiri Slaby
2008-09-05 0:03 ` Valdis.Kletnieks [this message]
2008-09-26 11:03 ` Jiri Slaby
2008-10-16 10:32 ` hidraw_exit in discarded section (was: Re: [PATCH 1/1] HID: fix tty<->hid deadlock) Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3717.1220573006@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=alan@redhat.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®