From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0503C43387 for ; Tue, 15 Jan 2019 18:41:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 960F620657 for ; Tue, 15 Jan 2019 18:41:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388887AbfAOSlk (ORCPT ); Tue, 15 Jan 2019 13:41:40 -0500 Received: from cloudserver094114.home.pl ([79.96.170.134]:50548 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728911AbfAOSlk (ORCPT ); Tue, 15 Jan 2019 13:41:40 -0500 Received: from 79.184.255.239.ipv4.supernova.orange.pl (79.184.255.239) (HELO aspire.rjw.lan) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83.183) id 96e725beedf4c253; Tue, 15 Jan 2019 19:41:37 +0100 From: "Rafael J. Wysocki" To: Andy Shevchenko Cc: Sinan Kaya , Andy Shevchenko , linux-next , ACPI Devel Maling List , Darren Hart , "open list:X86 PLATFORM DRIVERS" , open list Subject: Re: [PATCH v6 05/11] platform/x86: intel_pmc: Make PCI dependency explicit Date: Tue, 15 Jan 2019 19:40:45 +0100 Message-ID: <3717479.LUAfB5gYd9@aspire.rjw.lan> In-Reply-To: References: <20190105100606.6673-1-okaya@kernel.org> <3184241.VH7flF4h5P@aspire.rjw.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, January 9, 2019 12:10:45 PM CET Andy Shevchenko wrote: > On Wed, Jan 9, 2019 at 12:48 PM Rafael J. Wysocki wrote: > > > > On Saturday, January 5, 2019 11:06:00 AM CET Sinan Kaya wrote: > > > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without > > > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were > > > satisfied implicitly through dependencies on CONFIG_ACPI have to be > > > specified directly. Code relies on PCI for execution. Specify this > > > in the Kconfig. > > > > > > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") > > > Signed-off-by: Sinan Kaya > > > --- > > > drivers/platform/x86/Kconfig | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > > > index b36ea14b41ad..7afb96cb1cd6 100644 > > > --- a/drivers/platform/x86/Kconfig > > > +++ b/drivers/platform/x86/Kconfig > > > @@ -1174,7 +1174,7 @@ config INTEL_SMARTCONNECT > > > > > > config INTEL_PMC_IPC > > > tristate "Intel PMC IPC Driver" > > > - depends on ACPI > > > + depends on ACPI && PCI > > > ---help--- > > > This driver provides support for PMC control on some Intel platforms. > > > The PMC is an ARC processor which defines IPC commands for communication > > > > Andy, you had some reservations regarding this patch IIRC. > > > > Should I apply it? > > Let's do it as a quick fix with something like below being added to > the commit message: > > "For sake of a quick fix this introduces a new mandatory dependency to > the driver which may survive without it. Otherwise we need to revisit > the driver architecture to address this properly." Done, thanks!