mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Alex Williamson <alex.williamson@redhat.com>,
	Kirti Wankhede <kwankhede@nvidia.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] vfio-mdev: add MODULE_DESCRIPTION() macros
Date: Mon, 15 Jul 2024 09:17:41 -0700	[thread overview]
Message-ID: <3717c990-ac93-4a43-a33c-bce02a066dfd@quicinc.com> (raw)
In-Reply-To: <20240712163621.6f34ae98.alex.williamson@redhat.com>

On 7/12/2024 3:36 PM, Alex Williamson wrote:>>>>   MODULE_LICENSE("GPL v2");
>>>>   MODULE_INFO(supported, "Test driver that simulate serial port over PCI");
>>>> +MODULE_DESCRIPTION("Test driver that simulate serial port over PCI");
> 
> Seems the preceding MODULE_INFO needs to be removed here.  At best the
> added MODULE_DESCRIPTION is redundant, but "supported" is not a
> standard tag, so it's not clear what the purpose of that tag was meant
> to be anyway.  Thanks,
> 
> Alex

My preference would be to just add the missing MODULE_DESCRIPTION() with this
patch since that fixes the existing warning. Removing an existing macro
invocation is out of scope for what I'm trying to accomplish.

Out of almost 300 patches treewide that add missing MODULE_DESCRIPTION()
macros, this is one of 13 that is still pending for the 6.11 merge window.

/jeff


  reply	other threads:[~2024-07-15 16:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-24  0:12 Jeff Johnson
2024-07-11 18:30 ` Jeff Johnson
2024-07-12  7:27   ` Kirti Wankhede
2024-07-12 22:36     ` Alex Williamson
2024-07-15 16:17       ` Jeff Johnson [this message]
2024-07-15 16:35         ` Alex Williamson
2024-07-15 17:32           ` Jeff Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3717c990-ac93-4a43-a33c-bce02a066dfd@quicinc.com \
    --to=quic_jjohnson@quicinc.com \
    --cc=alex.williamson@redhat.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=kwankhede@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®