mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	perex@perex.cz, tiwai@suse.com, alexander.deucher@amd.com,
	Akshu Agrawal <akshu.agrawal@amd.com>,
	jclinton@chromium.org, Guenter Roeck <linux@roeck-us.net>,
	kuninori.morimoto.gx@renesas.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] ASoC: amd: dma driver changes for BT I2S instance
Date: Thu, 19 Apr 2018 10:07:18 +0530	[thread overview]
Message-ID: <371ba4c4-2917-4250-31ed-8da121d1409f@amd.com> (raw)
In-Reply-To: <CAGS+omBzuC75-pbROzwhQ9WqPQpKywZKEYMYGhdjvDNdZu2j=Q@mail.gmail.com>



On Thursday 19 April 2018 05:57 AM, Daniel Kurtz wrote:
> Hi Vijendar,
> 
> On Wed, Apr 18, 2018 at 5:02 AM Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> wrote:
> 
>> With in ACP, There are three I2S controllers can be
>> configured/enabled ( I2S SP, I2S MICSP, I2S BT).
>> Default enabled I2S controller instance is I2S SP.
>> This patch provides required changes to support I2S BT
>> controller Instance.
> 
> I like the direction this patch is taking, but I think it would be easier
> to review if you could split it into 2 parts:
>    (1) the cleanup of the existing driver to use a simplified flow for
> playback vs capture paths.
>    (2) adding the BT I2S channel.
> 
> 
> Thanks,
> -Dan
> 

Hi Dan,

I am fine with splitting the patch into two parts.

Thanks,
Vijendar

  reply	other threads:[~2018-04-19  4:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1524049494-19526-1-git-send-email-Vijendar.Mukunda@amd.com>
2018-04-18 11:04 ` [PATCH v2 1/3] ASoC: dwc: I2S Controller instance param added Vijendar Mukunda
2018-04-18 11:24   ` Mark Brown
2018-04-18 12:48     ` Mukunda,Vijendar
2018-04-18 17:00       ` Mark Brown
2018-04-18 11:04 ` [PATCH v2 2/3] ASoC: amd: dma driver changes for BT I2S instance Vijendar Mukunda
2018-04-19  0:27   ` Daniel Kurtz
2018-04-19  4:37     ` Mukunda,Vijendar [this message]
2018-04-18 11:04 ` [PATCH v2 3/3] ASoC: amd: enabling bt i2s config after acp reset Vijendar Mukunda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=371ba4c4-2917-4250-31ed-8da121d1409f@amd.com \
    --to=vijendar.mukunda@amd.com \
    --cc=akshu.agrawal@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=djkurtz@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jclinton@chromium.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®