From: Michael Krufky <mkrufky@gmail.com>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: Diego Calleja <diegocg@gmail.com>,
Alistair John Strachan <s0348365@sms.ed.ac.uk>,
mkrufky@m1k.net, webmaster@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [KORG] GITWEB doesn't show any DIFF's
Date: Tue, 17 Jan 2006 13:15:02 -0500 [thread overview]
Message-ID: <37219a840601171015jb973b2ex95485891c1db0157@mail.gmail.com> (raw)
In-Reply-To: <9a8748490601171007y426a02baq786d07a86f1632f7@mail.gmail.com>
On 1/17/06, Jesper Juhl <jesper.juhl@gmail.com> wrote:
> On 1/17/06, Diego Calleja <diegocg@gmail.com> wrote:
> > El Tue, 17 Jan 2006 17:39:17 +0000,
> > Alistair John Strachan <s0348365@sms.ed.ac.uk> escribió:
> >
> > > Seems to work for me right _now_, could you verify that this is still
> > > happening?
> >
> >
> > It happens for me, too - instead of showing me the diff, diffstat
> > shows me just:
> >
> >
> > file:844a6c9fb9490e585fc5371d759840b9e7ae327c -> file:21965e5ef25e8c1c86bd59da0f40350d4f821702
> > file:9a96f05883935a32955b216fcc3184bf162b0a85 -> file:63dd184ec808e7129efc3a355abdba4a21bf2c81
> >
> > With this commitdiff link, for example:
> > http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=7fab773de16ccaeb249acdc6e956a9759c68225d;hp=0046b06a367cd853efd3223ce60143f3a7952522
>
> Seems to work just fine for me.
> With that link I get this :
>
>
>
> [PATCH] ide: AMD Geode GX/LX support
> From: "Jordan Crouse" <jordan.crouse@amd.com>
>
> The core IDE engine on the CS5536 is the same as the other AMD southbridges,
> so unlike the CS5535, we can simply add the appropriate PCI headers to
> the existing amd74xx code.
>
>
> file:844a6c9fb9490e585fc5371d759840b9e7ae327c ->
> file:21965e5ef25e8c1c86bd59da0f40350d4f821702
> --- a/drivers/ide/pci/amd74xx.c
> +++ b/drivers/ide/pci/amd74xx.c
> @@ -74,6 +74,7 @@ static struct amd_ide_chip {
> { PCI_DEVICE_ID_NVIDIA_NFORCE_MCP04_IDE, 0x50, AMD_UDMA_133 },
> { PCI_DEVICE_ID_NVIDIA_NFORCE_MCP51_IDE, 0x50, AMD_UDMA_133 },
> { PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_IDE, 0x50, AMD_UDMA_133 },
> + { PCI_DEVICE_ID_AMD_CS5536_IDE, 0x40, AMD_UDMA_100 },
> { 0 }
> };
> @@ -491,6 +492,7 @@ static ide_pci_device_t amd74xx_chipsets
> /* 14 */ DECLARE_NV_DEV("NFORCE-MCP04"),
> /* 15 */ DECLARE_NV_DEV("NFORCE-MCP51"),
> /* 16 */ DECLARE_NV_DEV("NFORCE-MCP55"),
> + /* 17 */ DECLARE_AMD_DEV("AMD5536"),
> };
> static int __devinit amd74xx_probe(struct pci_dev *dev, const struct
> pci_device_id *id)
> @@ -527,6 +529,7 @@ static struct pci_device_id amd74xx_pci_
> { PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP04_IDE,
> PCI_ANY_ID, PCI_ANY_ID, 0, 0, 14 },
> { PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP51_IDE,
> PCI_ANY_ID, PCI_ANY_ID, 0, 0, 15 },
> { PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_IDE,
> PCI_ANY_ID, PCI_ANY_ID, 0, 0, 16 },
> + { PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_CS5536_IDE, PCI_ANY_ID,
> PCI_ANY_ID, 0, 0, 17 },
> { 0, },
> };
> MODULE_DEVICE_TABLE(pci, amd74xx_pci_tbl);
> file:9a96f05883935a32955b216fcc3184bf162b0a85 ->
> file:63dd184ec808e7129efc3a355abdba4a21bf2c81
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -487,6 +487,8 @@
> #define PCI_DEVICE_ID_AMD_8151_0 0x7454
> #define PCI_DEVICE_ID_AMD_8131_APIC 0x7450
> +#define PCI_DEVICE_ID_AMD_CS5536_IDE 0x209A
> +
> #define PCI_VENDOR_ID_TRIDENT 0x1023
> #define PCI_DEVICE_ID_TRIDENT_4DWAVE_DX 0x2000
> #define PCI_DEVICE_ID_TRIDENT_4DWAVE_NX 0x2001
Hmmm... very strange... It seems to be working fine for Jesper and
Alistair, but Diego Calleja confirms the same problem that I'm seeing.
Could it be a problem on one of the two KORG servers, and not the
other? Maybe thats why it works for some people but not everyone??
If that were the case, I would assume that it should work for me
SOMETIMES, but no.... It used to always show me a diff, and now it
never does. :-(
-Michael
next prev parent reply other threads:[~2006-01-17 18:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-17 14:01 Michael Krufky
2006-01-17 17:39 ` Alistair John Strachan
2006-01-17 17:52 ` Diego Calleja
2006-01-17 18:07 ` Jesper Juhl
2006-01-17 18:15 ` Michael Krufky [this message]
2006-01-17 17:59 ` Michael Krufky
2006-01-17 18:17 ` Alistair John Strachan
2006-01-17 18:27 ` Michael Krufky
2006-01-17 18:53 ` Nathan Laredo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37219a840601171015jb973b2ex95485891c1db0157@mail.gmail.com \
--to=mkrufky@gmail.com \
--cc=diegocg@gmail.com \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrufky@m1k.net \
--cc=s0348365@sms.ed.ac.uk \
--cc=webmaster@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®