From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EED7921D3F2 for ; Sun, 4 Jan 2026 12:38:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767530300; cv=none; b=jrUOhxKO8+MqcBTJyLccuP84ggDAgEX6g8znA4lNs0gTUln9G1g95vtIojEwpbxpU9tQtiqFCo5e1AufkhdkYovEeRpz88H6oEQLPwhV6K4uxcT1NrktYlTE7hH87f043j608+QuTuU7W3eHO5Va+E/HENbFj6k2YPcEHoll+dk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767530300; c=relaxed/simple; bh=4ltGoLV6XvG6h58jG2rIgCu9GjLnXZY93BkPUi3hseA=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=NRa8r9kz9epO3LgbWn0bJ6XmIvya9daJCPJTBXQVdYFaLMs4fJKq+1U/ljdjw8Da0kffg5Mynr3j9ACtEg/in3KjwxQcfOlHc58YX1tGqCxvHNKVWu15tkgEcE18VtZ4S7Nps11Sqi76a0ctyOKe1AJgag3THtQIouFc5NIzKR4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=RuO1joZu; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="RuO1joZu" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 603CsCKZ030720; Sun, 4 Jan 2026 12:37:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=WAg212 2s546P/Txi/Id5clhHybKTowJ5UCJPn/ClCvw=; b=RuO1joZu8kn1HGrD2CAyql xzXPE5svMnXV99M/vWCN4vV25MV4KzYOpAqU/1Zky7jixxBOxE2fr8miUcBcW5dc GmKdFDruDvvXL3oC3OSQbY7y1woYTXFDUenseEtr0NDRuOEQLr+bQt6bRxhZP0s7 tpS905sX/ST6iQJBS49KRpgldoh35KbRpVwWuxvNVNdaiTlSl+vSNa/CULMooJmm 1r9Wn0uWy/BsPHwwAnb89dZBGheGdTal+kEQbOkgStkg7kq4sHw8RDJHyUqNCVWs 34zH9DMEbvyMXtZ5+duB9DP8DTWzXE01PR4h5BmfC/GY3HFCYFKcCCYtgFiJJHTQ == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4beshekcns-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 04 Jan 2026 12:37:20 +0000 (GMT) Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 604CbK7d005216; Sun, 4 Jan 2026 12:37:20 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4beshekcnm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 04 Jan 2026 12:37:20 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 6048F8Xh005250; Sun, 4 Jan 2026 12:37:19 GMT Received: from smtprelay02.dal12v.mail.ibm.com ([172.16.1.4]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4bfexjsdyn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 04 Jan 2026 12:37:19 +0000 Received: from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com [10.39.53.233]) by smtprelay02.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 604CbHUI21758614 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 4 Jan 2026 12:37:18 GMT Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AB04D5804E; Sun, 4 Jan 2026 12:37:17 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DF2EF5803F; Sun, 4 Jan 2026 12:36:33 +0000 (GMT) Received: from [9.61.253.45] (unknown [9.61.253.45]) by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP; Sun, 4 Jan 2026 12:36:32 +0000 (GMT) Message-ID: <3722b203-0c96-4609-9c9a-a7651a1745ff@linux.ibm.com> Date: Sun, 4 Jan 2026 18:06:28 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/8] Generic IRQ entry/exit support for powerpc To: Mukesh Kumar Chaurasiya , maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, oleg@redhat.com, kees@kernel.org, luto@amacapital.net, wad@chromium.org, mchauras@linux.ibm.com, thuth@redhat.com, sshegde@linux.ibm.com, charlie@rivosinc.com, macro@orcam.me.uk, akpm@linux-foundation.org, ldv@strace.io, deller@gmx.de, ankur.a.arora@oracle.com, segher@kernel.crashing.org, tglx@linutronix.de, thomas.weissschuh@linutronix.de, peterz@infradead.org, menglong8.dong@gmail.com, bigeasy@linutronix.de, namcao@linutronix.de, kan.liang@linux.intel.com, mingo@kernel.org, atrajeev@linux.vnet.ibm.com, mark.barnett@arm.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20251214130245.43664-1-mkchauras@linux.ibm.com> Content-Language: en-US From: Samir M In-Reply-To: <20251214130245.43664-1-mkchauras@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA0MDExMyBTYWx0ZWRfXxtFSzlZ91o5G odm+OZeg8dYUCPadsZT03Eu1OM0Ao+1wsNOgEVs5ItHh+SZ7rardfnnOqRi3ytYgyDD528SNag6 8P09wjXOC7IFbVM0ajw6+Irc4fQ60a7XWC6m8MJi6lQt2MaTP4B1nbXkYwpQXNjWkoTi4xaqUlt tdXucOIcL+t+v9Vwn94hvkdcOuX8J26s0375usWOuJQaMGg3cIsigK0gpYlD7yScNZKKqRsXL+O likTzYl9beG0xHzqdK8kUm0tEU0bfUE+IRiXcu/nfmFj0LONU0yCoD4cPc+8XsnCIwlvWsspWQK u1dk5YSdJ8YxJZh/5XpGrW9eJ1rxwvXZnaMXC9WuMGZrLy3LFjhJfhGXDhN+mg7wDS9XSJ9T3EQ LAvF1Ffr8LShEtfuKDlWnJBFUtSxkw/UwABR9GCuYCmGweFtQCGH27igXVuNxUS4t5bcQD2jrW7 ou6cW6Wm3N7e05KccrA== X-Proofpoint-GUID: ZW8lJorZQ6AYYnx9xFzXahKG4gl7fZYH X-Proofpoint-ORIG-GUID: 7WjAyvfPsjy2AgCyh3bJAOsMltFfIPCt X-Authority-Analysis: v=2.4 cv=AOkvhdoa c=1 sm=1 tr=0 ts=695a5f00 cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=Bpi_U_enSnNp422sU5QA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-04_04,2025-12-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 adultscore=0 malwarescore=0 impostorscore=0 clxscore=1015 suspectscore=0 bulkscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2512120000 definitions=main-2601040113 On 14/12/25 6:32 pm, Mukesh Kumar Chaurasiya wrote: > Adding support for the generic irq entry/exit handling for PowerPC. The > goal is to bring PowerPC in line with other architectures that already > use the common irq entry infrastructure, reducing duplicated code and > making it easier to share future changes in entry/exit paths. > > This is slightly tested of ppc64le and ppc32. > > The performance benchmarks are below: > > perf bench syscall usec/op > > | Test | With Patch | Without Patch | % Change | > | --------------- | ---------- | ------------- | -------- | > | getppid usec/op | 0.207795 | 0.210373 | -1.22% | > | getpgid usec/op | 0.206282 | 0.211676 | -2.55% | > | fork usec/op | 833.986 | 814.809 | +2.35% | > | execve usec/op | 360.939 | 365.168 | -1.16% | > > > perf bench syscall ops/sec > > | Test | With Patch | Without Patch | % Change | > | --------------- | ---------- | ------------- | -------- | > | getppid ops/sec | 48,12,433 | 47,53,459 | +1.24% | > | getpgid ops/sec | 48,47,744 | 47,24,192 | +2.61% | > | fork ops/sec | 1,199 | 1,227 | -2.28% | > | execve ops/sec | 2,770 | 2,738 | +1.16% | > > IPI latency benchmark > > | Metric | With Patch | Without Patch | % Change | > | ----------------------- | ---------------- | ---------------- | -------- | > | Dry-run (ns) | 206,675.81 | 206,719.36 | -0.02% | > | Self-IPI avg (ns) | 1,939,991.00 | 1,976,116.15 | -1.83% | > | Self-IPI max (ns) | 3,533,718.93 | 3,582,650.33 | -1.37% | > | Normal IPI avg (ns) | 111,110,034.23 | 110,513,373.51 | +0.54% | > | Normal IPI max (ns) | 150,393,442.64 | 149,669,477.89 | +0.48% | > | Broadcast IPI max (ns) | 3,978,231,022.96 | 4,359,916,859.46 | -8.73% | > | Broadcast lock max (ns) | 4,025,425,714.49 | 4,384,956,730.83 | -8.20% | > > Thats very close to performance earlier with arch specific handling. > > Tests done: > - Build and boot on ppc64le pseries. > - Build and boot on ppc64le powernv8 powernv9 powernv10. > - Build and boot on ppc32. > - Performance benchmark done with perf syscall basic on pseries. > > Changelog: > > V1 -> V2 > - Fix an issue where context tracking was showing warnings for > incorrect context > V1: https://lore.kernel.org/all/20251102115358.1744304-1-mkchauras@linux.ibm.com/ > > RFC -> PATCH V1 > - Fix for ppc32 spitting out kuap lock warnings. > - ppc64le powernv8 crash fix. > - Review comments incorporated from previous RFC. > RFC https://lore.kernel.org/all/20250908210235.137300-2-mchauras@linux.ibm.com/ > > Mukesh Kumar Chaurasiya (8): > powerpc: rename arch_irq_disabled_regs > powerpc: Prepare to build with generic entry/exit framework > powerpc: introduce arch_enter_from_user_mode > powerpc: Introduce syscall exit arch functions > powerpc: add exit_flags field in pt_regs > powerpc: Prepare for IRQ entry exit > powerpc: Enable IRQ generic entry/exit path. > powerpc: Enable Generic Entry/Exit for syscalls. > > arch/powerpc/Kconfig | 2 + > arch/powerpc/include/asm/entry-common.h | 536 ++++++++++++++++++++++++ > arch/powerpc/include/asm/hw_irq.h | 4 +- > arch/powerpc/include/asm/interrupt.h | 401 +++--------------- > arch/powerpc/include/asm/ptrace.h | 3 + > arch/powerpc/include/asm/stacktrace.h | 6 + > arch/powerpc/include/asm/syscall.h | 5 + > arch/powerpc/include/asm/thread_info.h | 1 + > arch/powerpc/include/uapi/asm/ptrace.h | 14 +- > arch/powerpc/kernel/asm-offsets.c | 1 + > arch/powerpc/kernel/interrupt.c | 255 ++--------- > arch/powerpc/kernel/ptrace/ptrace.c | 142 +------ > arch/powerpc/kernel/signal.c | 8 + > arch/powerpc/kernel/syscall.c | 119 +----- > arch/powerpc/kernel/traps.c | 2 +- > arch/powerpc/kernel/watchdog.c | 2 +- > arch/powerpc/perf/core-book3s.c | 2 +- > 17 files changed, 685 insertions(+), 818 deletions(-) > create mode 100644 arch/powerpc/include/asm/entry-common.h Hi, I have reviewed and tested the generic IRQ entry/exist patch series. Below are my observations: Test Coverage Successfully ran LTP (specially syscall) and entire LTP test suite, without observing any regressions or issues related to the implementation. Successfully ran kernel self test and no regressions are observed. System Configuration • CPUs: 80 • Kernel: 6.19.0-rc1 • Processor mode: Dedicated Performance Evaluation • Conducted bench marking using "perf bench syscall usec/ops". • No functional regressions observed, and results were consistent with expectations. | Test                   |  With Patch   | Without Patch  | % Change | | -------------  |  —————   | ——————    | -------- | | getppid ops/sec | 9,901,942    | 10,066,131     | -1.63%     | | getpgid ops/sec | 9,886,533    | 9,978,781       | -0.92%     | | fork ops/sec       | 2,571           | 2,601             | -1.15%    | | execve ops/sec   | 2,567           | 2,542             | +0.98% | Please add below tag: Tested-by: Samir M Thanks, Samir