From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751247AbdE3XeC (ORCPT ); Tue, 30 May 2017 19:34:02 -0400 Received: from mail-qt0-f172.google.com ([209.85.216.172]:35158 "EHLO mail-qt0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750913AbdE3XeB (ORCPT ); Tue, 30 May 2017 19:34:01 -0400 Subject: Re: [PATCH] staging: android: uapi: drop definitions of removed ION_IOC_{FREE,SHARE} ioctls To: Gleb Fotengauer-Malinovskiy , linux-kernel@vger.kernel.org Cc: Sumit Semwal , Greg Kroah-Hartman , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Riley Andrews , devel@driverdev.osuosl.org, "Dmitry V. Levin" References: <20170530141128.GA1469@glebfm.cloud.tilaa.com> From: Laura Abbott Message-ID: <3725e052-5e57-3455-01e2-76ee33eeb15b@redhat.com> Date: Tue, 30 May 2017 16:33:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <20170530141128.GA1469@glebfm.cloud.tilaa.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/30/2017 07:11 AM, Gleb Fotengauer-Malinovskiy wrote: > This problem was found by strace ioctl list generator. > > Fixes: 15c6098cfec5 ("staging: android: ion: Remove ion_handle and ion_client") > Signed-off-by: Gleb Fotengauer-Malinovskiy > --- > drivers/staging/android/uapi/ion.h | 18 ------------------ > 1 file changed, 18 deletions(-) > > diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h > index b76db1b..a291b12 100644 > --- a/drivers/staging/android/uapi/ion.h > +++ b/drivers/staging/android/uapi/ion.h > @@ -131,24 +131,6 @@ struct ion_heap_query { > struct ion_allocation_data) > > /** > - * DOC: ION_IOC_FREE - free memory > - * > - * Takes an ion_handle_data struct and frees the handle. > - */ > -#define ION_IOC_FREE _IOWR(ION_IOC_MAGIC, 1, struct ion_handle_data) > - > -/** > - * DOC: ION_IOC_SHARE - creates a file descriptor to use to share an allocation > - * > - * Takes an ion_fd_data struct with the handle field populated with a valid > - * opaque handle. Returns the struct with the fd field set to a file > - * descriptor open in the current address space. This file descriptor > - * can then be passed to another process. The corresponding opaque handle can > - * be retrieved via ION_IOC_IMPORT. > - */ > -#define ION_IOC_SHARE _IOWR(ION_IOC_MAGIC, 4, struct ion_fd_data) > - > -/** > * DOC: ION_IOC_HEAP_QUERY - information about available heaps > * > * Takes an ion_heap_query structure and populates information about > Acked-by: Laura Abbott