From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "Markus.Elfring@web.de" <Markus.Elfring@web.de>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Cc: "jic23@kernel.org" <jic23@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] iio: core: move 'indio_dev->info' null check first
Date: Tue, 7 Apr 2020 08:45:58 +0000 [thread overview]
Message-ID: <3725f882accda683815f04c0eff0bb36c285fe62.camel@analog.com> (raw)
In-Reply-To: <cb300eeb-6045-bd91-3e0e-902dd3b5d5d8@web.de>
On Tue, 2020-04-07 at 10:20 +0200, Markus Elfring wrote:
> [External]
>
> > Doesn't fix anything.
>
> Would the change description be nicer without this sentence?
>
That part is slightly debate-able.
I've had my fair-share of comments [during reviews], where others were
asking/saying "is this fixing anything? please state if this is fixing
anything".
So, over time I got the habit of mentioning 'Doesn't fix anything.' if the patch
doesn't fix anything.
So, I'd leave it as-is [if that's possible].
>
> > Just moves this …
>
> I suggest to choose an imperative wording.
> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=7e63420847ae5f1036e4f7c42f0b3282e73efbc2*n151__;Iw!!A3Ni8CS0y2Y!pMoqZILvWyu87fkNe16Sua0jMrZZK81oQOHENUhyTWZz9UrY4CisyKWSRCPFws0WTm50iQ$
>
I admit, I didn't read that document too much in-depth.
And I probably won't, because I am lazy.
Personally, what I try to do, is guess the maintainer's/community's preferences
over time via interactions.
Things differ slightly from community to community.
Of course, there is some common ground across all communities, and I try to
apply that first.
Then, depending on the flexibility/past-comments from other sent-patches I try
to apply those on top [unless I forget; which I kinda do].
> Regards,
> Markus
next prev parent reply other threads:[~2020-04-07 8:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 8:20 Markus Elfring
2020-04-07 8:45 ` Ardelean, Alexandru [this message]
2020-04-07 10:42 ` [v2] " Markus Elfring
2020-04-07 11:01 ` Ardelean, Alexandru
2020-04-07 11:29 ` Ardelean, Alexandru
2020-04-07 12:12 ` Markus Elfring
-- strict thread matches above, loose matches on Subject: below --
2020-04-06 12:32 [PATCH] " Alexandru Ardelean
2020-04-07 6:21 ` [PATCH v2] " Alexandru Ardelean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3725f882accda683815f04c0eff0bb36c285fe62.camel@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=Markus.Elfring@web.de \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®