From: bot+bpf-ci@kernel.org
To: anilkaushikwireless@gmail.com,ast@kernel.org,daniel@iogearbox.net,davem@davemloft.net,kuba@kernel.org,hawk@kernel.org,john.fastabend@gmail.com,andrii@kernel.org,eddyz87@gmail.com,memxor@gmail.com,shuah@kernel.org
Cc: sdf@fomichev.me,martin.lau@linux.dev,song@kernel.org,yonghong.song@linux.dev,jolsa@kernel.org,emil@etsalapatis.com,ihor.solodrai@linux.dev,linux-kernel@vger.kernel.org,netdev@vger.kernel.org,bpf@vger.kernel.org,linux-kselftest@vger.kernel.org,anilkaushikwireless@gmail.com,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,mason@kernel.org,ihor.solodrai@linux.dev
Subject: Re: [PATCH bpf-next v3] selftests/bpf: add XDP test for per-flow LRU_HASH window updates
Date: Fri, 2 Oct 2026 06:13:52 +0000 (UTC) [thread overview]
Message-ID: <37328eed3277cd2e4ce990db3029d5e626f896011ee344943011726d70b1bcd8@mail.kernel.org> (raw)
In-Reply-To: <20261002053837.3494918-1-anilkaushikwireless@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1814 bytes --]
> selftests/bpf: add XDP test for per-flow LRU_HASH window updates
TL;DR: Nit only: the comment in the new xdp_lru_window.h is overlong, repeats
the commit message, and calls the shared header an "ABI"; suggests trimming it
to one line.
> diff --git a/tools/testing/selftests/bpf/xdp_lru_window.h b/tools/testing/selftests/bpf/xdp_lru_window.h
> new file mode 100644
> index 000000000000..78434045cf11
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/xdp_lru_window.h
> @@ -0,0 +1,28 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef __XDP_LRU_WINDOW_H
> +#define __XDP_LRU_WINDOW_H
> +
> +/*
> + * ABI for the XDP LRU rolling-window selftest. Existing test_lru_map
> + * coverage never enters XDP; XDP parse tests do not store a modulo
> + * index into an LRU map value.
> + */
> +
> +#define AGGREGATION_WINDOW 50
> +#define XDP_LRU_WINDOW_FLOWS 64
This isn't a bug, but could this header comment be trimmed down?
Most of it restates the first paragraph of the commit message and describes
what other selftests do and do not cover, rather than what this header
defines. A statement like "Existing test_lru_map coverage never enters XDP"
can go stale when another test adds similar coverage.
It also calls a struct shared between one BPF object and one test_progs file
an "ABI". The neighbouring shared headers (test_tcpbpf.h, test_tcpnotify.h,
xdp_metadata.h) do not carry a comment like this.
Could the coverage reasoning stay in the commit message only, leaving at most
a one-line note about what is shared between the BPF program and the test
runner?
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/36971050072
next prev parent reply other threads:[~2026-10-02 6:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 5:38 Anil Kaushik
2026-10-02 6:13 ` bot+bpf-ci [this message]
2026-10-02 11:52 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37328eed3277cd2e4ce990db3029d5e626f896011ee344943011726d70b1bcd8@mail.kernel.org \
--to=bot+bpf-ci@kernel.org \
--cc=andrii@kernel.org \
--cc=anilkaushikwireless@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=hawk@kernel.org \
--cc=ihor.solodrai@linux.dev \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=martin.lau@linux.dev \
--cc=mason@kernel.org \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®