From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C4DBB3B4E9B; Mon, 30 Mar 2026 10:50:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774867823; cv=none; b=PkJrOfKyxqoVfAjkM60ghFzOcrc5LV2fh9L3gdxELxch4NIpywTqBURJsshhO4WDC4dxc90XI1yGfO1Meo/T+mhiHge3Bq7PIF39J2cuhPBIKj0utgo7ielpOHY5xRfWVue1d0LE17bYIsMnVqlB34jMRi4TDQNgIN1Xmq94/nI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774867823; c=relaxed/simple; bh=JI+Xuu/ybqlMVDvJDayiXhKnKGzuD+x/x059NYtE0K4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KSx7KZC0DTh1lB24yOLbZkrSWSl2rKbm49/Lc3Uhyuo7UyBvhaZgOGHpUx8VkUMHCoEothswPQ7G5u9u71CsGAmDzHG+q+kkCDeG7vrl20lVuD3O7EXvdcFAVcqTcUyMRTjWJ4ZkAt3Lzlvyh5PwNS7xYhSKaxdUtBjJ+CElI5w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=AtqvQXHG; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="AtqvQXHG" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 43A281C01; Mon, 30 Mar 2026 03:50:15 -0700 (PDT) Received: from [10.57.13.56] (unknown [10.57.13.56]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D3B523F915; Mon, 30 Mar 2026 03:50:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1774867821; bh=JI+Xuu/ybqlMVDvJDayiXhKnKGzuD+x/x059NYtE0K4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=AtqvQXHGQ0cYw7a5kMc3gYXiQ0LRluMyI1zMzz1VOPAemVVgba0xZpdkOtfYPk4iH prrXMbY/8EYtsiMt0NdvPSWOnmxQnebEgquF8UBiwF/Tsfm8h9EkfK+bbB4WPHk6oQ tJGR6wIJ7Q8j8U4rrOJD7SFu/IaVCGLONdrjYcms= Message-ID: <37360a1f-4cc6-4a7b-967e-41ef9707cae4@arm.com> Date: Mon, 30 Mar 2026 11:50:16 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 31/48] KVM: arm64: WARN on injected undef exceptions Content-Language: en-GB To: Steven Price , kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Gavin Shan , Shanker Donthineni , Alper Gun , "Aneesh Kumar K . V" , Emi Kisanuki , Vishal Annapurve References: <20260318155413.793430-1-steven.price@arm.com> <20260318155413.793430-32-steven.price@arm.com> From: Suzuki K Poulose In-Reply-To: <20260318155413.793430-32-steven.price@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 18/03/2026 15:53, Steven Price wrote: > The RMM doesn't allow injection of a undefined exception into a realm > guest. Add a WARN to catch if this ever happens. > > Signed-off-by: Steven Price > Reviewed-by: Gavin Shan Reviewed-by: Suzuki K Poulose > --- > Changes since v6: > * if (x) WARN(1, ...) makes no sense, just WARN(x, ...)! > --- > arch/arm64/kvm/inject_fault.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/kvm/inject_fault.c b/arch/arm64/kvm/inject_fault.c > index 6492397b73d7..613f223bc7a3 100644 > --- a/arch/arm64/kvm/inject_fault.c > +++ b/arch/arm64/kvm/inject_fault.c > @@ -327,6 +327,7 @@ void kvm_inject_size_fault(struct kvm_vcpu *vcpu) > */ > void kvm_inject_undefined(struct kvm_vcpu *vcpu) > { > + WARN(vcpu_is_rec(vcpu), "Unexpected undefined exception injection to REC"); > if (vcpu_el1_is_32bit(vcpu)) > inject_undef32(vcpu); > else