From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CBCA330328 for ; Tue, 5 May 2026 09:43:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777974241; cv=none; b=S/REGmtT6PucsR1BqfP/NDhrVExU0/5EkScSDhFsECMV1xFeGAqGwu+b4R2lUFAswc+U34zG5Yr2oKKLvvCWOdonQsF9zaivoXjQG5s/kenYirVU4DJVbkKw2SnIDp4Nd585ygnWNaMK8QBN1bUA3ksVVCIGzodPyUXxW734Zlo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777974241; c=relaxed/simple; bh=GB2zSiCiH2B2MkSpdmM8X1Yz2rkioSL551rkMUaheIg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NlY8HVjvpQipnQ6NeuqziRpfivuXNxY0jRvCluWF3OVnZsv1yZ8KGlSqqE8Fy6Wh45YMrka1brcbc5Jo1ycVSfnIz9wHJJYUJZi+bNmaauWoh7hMrJXrEVKYgQXy+0KLi3MGVQr+zo4YIUYe5CnJ8IDw3byahZgVd327fMm9p2c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dmaJ5jtd; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=FQYWJjS3; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dmaJ5jtd"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="FQYWJjS3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777974237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kmyJRtAdai9pCgAp5lRpf5bBAJMr8C8LzYPKP+rHxUU=; b=dmaJ5jtdLJSdH9PZjrm+u5GTvfAiIM5WnJ5pZV7AxMxDAp13oCSR8MJ4clZAMBaG11nIxF V8XMZmIbxNu7zOPnMlIOHDZK7ycUwLxFzLNaCnf7FSzL37NXYkdnocz5I9Li2F5gCgDaou iKWnxA73AGYgd16jh6XY0Wxns1UJyno= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-599-svl4N_D7PIWu2I1JUGNgJQ-1; Tue, 05 May 2026 05:43:55 -0400 X-MC-Unique: svl4N_D7PIWu2I1JUGNgJQ-1 X-Mimecast-MFC-AGG-ID: svl4N_D7PIWu2I1JUGNgJQ_1777974235 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-48d035e8593so13286195e9.0 for ; Tue, 05 May 2026 02:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1777974234; x=1778579034; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kmyJRtAdai9pCgAp5lRpf5bBAJMr8C8LzYPKP+rHxUU=; b=FQYWJjS3v2WEH+plSmUPAOCpl+CPb17MvLD/Gv0ckl1+pqCH/mlb39gPruKPAZz3Ki EOkg3OzbKDqzpN+doqBiKtDsRNgROu+AtR2tOY3XlKTaZNxlGnVXQ43jsG/sYYwoagvZ SUtXK13rv0xonDZ5RAtdfv3m6aXoyuWaOM/UhTBf3WJekWwzzOgFAK71+xKy/UGT0wU0 8f7Y0rRtjQ6eEI+PSiS+cyu58DaPXVt9bn7o/GwUFgZESq4Po5KGslIGbVCu+7yamyy/ 1SnA1iaIC12NXgVJ6n2BF1WOx5HHM3YclgMDF8TEOPL8IVm6t9/L0bOlc9tNmUvRyqpG inOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777974234; x=1778579034; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kmyJRtAdai9pCgAp5lRpf5bBAJMr8C8LzYPKP+rHxUU=; b=baNixf2ccXcmDaSkVu4zbiWPcZxg5y3++0xCiHp9pAznYQvi3pxAxp8dQ6x0fT6mCC TTe2Yi6uRxxO8SjrHtC2kvs/OSczH5Az30dK67PD6YALuZyNrzZtamkO8IXYtiZu/SnV 6shgNCKe03QEhYnWtd7tHFlp+dDEZFmMNh5DD8Lxh0kkLGVu8abqQhXLM6yFjrpxwVDf A1IYW0tM+Jk7L3ty0bNTKcZEDjTqdv+3jlMxfRrOGpg/q75VG5h3fPmvQju6aJ6yaT/D Qa/AlZ6/9oB1aHdkysvILtXm3W7acic0f2muGwxCbA8e16Yk/JrXvJdRx9hFH5dlC2om yMOA== X-Forwarded-Encrypted: i=1; AFNElJ99FYW28kPjpnIhoMeFGzDTIiKdK4yOIMC2Ssd8vCCnNSrQjV2/uV+04pu7AI/o+TsJJS+oJLFHq2BHtF0=@vger.kernel.org X-Gm-Message-State: AOJu0YwR/iDWGkcLL4GNhOhXhSWGVlftqlZMx73Y0A3OTtYedBWlbeDI iwXDSjeRuECCuEZgNvXvRx0iwbLEYOTKIhknyYfifxZli228q2AiXOM6BzYnpC5KDNMF2qREhkE ib51bMqa/Tl+tOwj3oqZE53E+cV72gQpCX0OtN9N0Ba8e8rUh3Lm9Y8FngjwbaZojiA== X-Gm-Gg: AeBDietfHsEtbDfSrvUrGADxu8Qe6/aRjc4X5Ggm96XjGKJFuf9gfYAXicJSGPbrZg0 z/XyZNpWpswd+0jrahYU4S5BfdXup+kru9d8LI67nioWoNgG5mvGIWnXsPxDGRFHYtaUQk0k6L7 3u3to6+WJ9EKtA4dcYnd2ECxdPBDdWIKg+jBOKgd6zTl0BlSRc7SxqdveAtY/n5jdKG7MLNLhgj 4CBfyCHJv4CRtBr8NcGflMFUK6GeIURYQfABhYelC5pue1mm1O7BIZnYO2MM/vSYxTCkmT2xWk9 XTMRZG5DkB/42dRTGKlxITkrmVzpO5RQv8f3p9Jq0kMGN+29HBex35y5AGdfviSiCm+hd0YRmlt yz0N2DHl2zlyIe8uUL1OlJ1aUR2KFnMU5RQEygdLTP2WJJLdobxWKqJ/+1UzPATLikDY= X-Received: by 2002:a05:600c:46d1:b0:489:1d74:56d with SMTP id 5b1f17b1804b1-48a988ca441mr218126995e9.29.1777974234592; Tue, 05 May 2026 02:43:54 -0700 (PDT) X-Received: by 2002:a05:600c:46d1:b0:489:1d74:56d with SMTP id 5b1f17b1804b1-48a988ca441mr218126385e9.29.1777974234170; Tue, 05 May 2026 02:43:54 -0700 (PDT) Received: from [192.168.88.32] ([212.105.155.47]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a8eb69698sm603894855e9.1.2026.05.05.02.43.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 May 2026 02:43:53 -0700 (PDT) Message-ID: <37382811-ba47-4432-9911-6c39acea4f86@redhat.com> Date: Tue, 5 May 2026 11:43:51 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 net-next 15/15] net: dsa: netc: add support for ethtool private statistics To: Wei Fang , claudiu.manoil@nxp.com, vladimir.oltean@nxp.com, xiaoning.wang@nxp.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, f.fainelli@gmail.com, frank.li@nxp.com, chleroy@kernel.org, horms@kernel.org, linux@armlinux.org.uk Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev References: <20260430024945.3413973-1-wei.fang@nxp.com> <20260430024945.3413973-16-wei.fang@nxp.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260430024945.3413973-16-wei.fang@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/30/26 4:49 AM, Wei Fang wrote: > Implement the ethtool private statistics interface to expose additional > port-level and MAC-level counters that are not covered by the standard > IEEE 802.3 statistics. The pMAC counters are only reported when the port > supports Frame Preemption (802.1Qbu/802.3br). > > Signed-off-by: Wei Fang > --- > drivers/net/dsa/netc/netc_ethtool.c | 107 ++++++++++++++++++++++++++ > drivers/net/dsa/netc/netc_main.c | 3 + > drivers/net/dsa/netc/netc_switch.h | 9 +++ > drivers/net/dsa/netc/netc_switch_hw.h | 58 ++++++++++++++ > 4 files changed, 177 insertions(+) > > diff --git a/drivers/net/dsa/netc/netc_ethtool.c b/drivers/net/dsa/netc/netc_ethtool.c > index ac8940b5a85c..8d04db534347 100644 > --- a/drivers/net/dsa/netc/netc_ethtool.c > +++ b/drivers/net/dsa/netc/netc_ethtool.c > @@ -19,6 +19,56 @@ static const struct ethtool_rmon_hist_range netc_rmon_ranges[] = { > { } > }; > > +static const struct netc_port_stat netc_port_counters[] = { > + { NETC_PTGSLACR, "port gate late arrival frames" }, > + { NETC_PSDFTCR, "port SDF transmit frames" }, > + { NETC_PSDFDDCR, "port SDF drop duplicate frames" }, > + { NETC_PRXDCR, "port rx discard frames" }, > + { NETC_PRXDCRRR, "port rx discard read-reset" }, > + { NETC_PRXDCRR0, "port rx discard reason 0" }, > + { NETC_PRXDCRR1, "port rx discard reason 1" }, > + { NETC_PTXDCR, "port tx discard frames" }, > + { NETC_PTXDCRRR, "port tx discard read-reset" }, > + { NETC_PTXDCRR0, "port tx discard reason 0" }, > + { NETC_PTXDCRR1, "port tx discard reason 1" }, > + { NETC_BPDCR, "bridge port discard frames" }, > + { NETC_BPDCRRR, "bridge port discard read-reset" }, > + { NETC_BPDCRR0, "bridge port discard reason 0" }, > + { NETC_BPDCRR1, "bridge port discard reason 1" }, > +}; > + > +static const struct netc_port_stat netc_emac_counters[] = { > + { NETC_PM_ROCT(0), "eMAC rx octets" }, > + { NETC_PM_RVLAN(0), "eMAC rx VLAN frames" }, > + { NETC_PM_RERR(0), "eMAC rx frame errors" }, > + { NETC_PM_RUCA(0), "eMAC rx unicast frames" }, > + { NETC_PM_RDRP(0), "eMAC rx dropped packets" }, > + { NETC_PM_RPKT(0), "eMAC rx packets" }, > + { NETC_PM_TOCT(0), "eMAC tx octets" }, > + { NETC_PM_TVLAN(0), "eMAC tx VLAN frames" }, > + { NETC_PM_TFCS(0), "eMAC tx FCS errors" }, > + { NETC_PM_TUCA(0), "eMAC tx unicast frames" }, > + { NETC_PM_TPKT(0), "eMAC tx packets" }, > + { NETC_PM_TUND(0), "eMAC tx undersized packets" }, > + { NETC_PM_TIOCT(0), "eMAC tx invalid octets" }, > +}; > + > +static const struct netc_port_stat netc_pmac_counters[] = { > + { NETC_PM_ROCT(1), "pMAC rx octets" }, > + { NETC_PM_RVLAN(1), "pMAC rx VLAN frames" }, > + { NETC_PM_RERR(1), "pMAC rx frame errors" }, > + { NETC_PM_RUCA(1), "pMAC rx unicast frames" }, > + { NETC_PM_RDRP(1), "pMAC rx dropped packets" }, > + { NETC_PM_RPKT(1), "pMAC rx packets" }, > + { NETC_PM_TOCT(1), "pMAC tx octets" }, > + { NETC_PM_TVLAN(1), "pMAC tx VLAN frames" }, > + { NETC_PM_TFCS(1), "pMAC tx FCS errors" }, > + { NETC_PM_TUCA(1), "pMAC tx unicast frames" }, > + { NETC_PM_TPKT(1), "pMAC tx packets" }, > + { NETC_PM_TUND(1), "pMAC tx undersized packets" }, > + { NETC_PM_TIOCT(1), "pMAC tx invalid octets" }, > +}; Sashiko says: Are these standard MAC and interface statistics being duplicated in the driver-private ethtool strings? The networking subsystem guidelines indicate that statistics which have a standard uAPI must not be duplicated in ethtool -S. Standard interfaces like struct rtnl_link_stats64 or struct ethtool_eth_mac_stats already exist for counters such as rx octets, rx packets, dropped packets, and FCS errors. Could these metrics be exposed through the standardized interfaces rather than adding them to the private string sets? Other comments are AFAICS false positives. /P