From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753862AbbIHH70 (ORCPT ); Tue, 8 Sep 2015 03:59:26 -0400 Received: from mout.gmx.net ([212.227.15.15]:63402 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753042AbbIHH7X (ORCPT ); Tue, 8 Sep 2015 03:59:23 -0400 From: Marc Dietrich To: Dmitry Osipenko Cc: Stephen Warren , Thierry Reding , Alexandre Courbot , Mika Westerberg , "Rafael J. Wysocki" , stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ARM: tegra: paz00: use con_id's to refer GPIO's ingpiod_lookup table Date: Tue, 08 Sep 2015 09:59:11 +0200 Message-ID: <3738507.JjVW9EvTJ3@fb07-iapwap2> User-Agent: KMail/4.14.10 (Linux/4.1.6-3-desktop; KDE/4.14.10; x86_64; ; ) In-Reply-To: <55ED5721.80508@gmail.com> References: <1435673759-11996-1-git-send-email-digetx@gmail.com> <55ED5721.80508@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3403769.ohlsyk9j4l"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-Provags-ID: V03:K0:LHbajF46xIZ8KDBLFbVbtx+WcavYFiy8xPOUonKEcS/bj6V51Cy Er1mSc4KW3a68QFng/LIyPTKTtJzzTBtEzGpLsty+XlJK1b3Is4K8vONbq7GHQL4esDBCRo ebmGsJR3GmgyOQhn4A0BZAxTZWIElwIOtfWvCRbdhHOVYbDO2nDctJQq/QbRyiLlWHboxoD 5YU6dix9hYVZfX1LH6+DQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:xEs0AYYqaxo=:kS341r98I0qbm3+dYZqO7H 5wXEFJ41V7Jz0lup/QpO+Zo45YvUzc16FLpjUcvoMkYfWvpEy1ffGSrYZvquF2U3AAlN+7X+k fKcNCLQpRJIflYM/+0a7SQZ5XlqIMCWTz5YfJ8zLYm3d5CiC99XSrn9FUv2fTERIs+ubOul7k kXjBoNy/LHLQx1W16QaKsapQpb8EYAGBfit9wZnVDHLKGAVsMKnhMow6m2fW6nvReXxV9enxo o9SU+uiAI0eULj6vOIiIgUWhjo3/RQg3fPcVUIoV9q2xUIraUspf548CAQoxaD4/eFYRdqKsF Bvv9ryX3H5D78gkUpEookO7jsmcnFZHhNgd17qrW5GVVFEcU1dqGn3rEsYW0DFc3tZIq2Mxlc vCWcswK16WU+Jinfdj1jiZu4iTC8t0qv8td/VYZ+gV/mIhzpWAmobDJyFKm6xKbztzCeffTYb IuQOWjPDnSEfJtjLMtYJZTNRO2kf0fyYAUO/MVwyfwYO8kj53oh616vEFx4pYviHMaNpyzmqG EqfsltNC14c6wf8He8kFP2VVm0Qn6CYGNVWLF+7X/oVo7gN9cU9d5RgVuou/ik3VlnFkscvh3 Y3TKgqgTe6tzK5YxP2wyIQiPD7mXPp9p1HUY+aV2lg1lUdiiho1HeOjDu7f5XUX5iZ5LPO3S7 nEkJZqsKKdI0ctIvCzhRqj8X+ELhe4E4vNKIMVbfiT+P07uwCf6o7TBbwPtcZOYuj+eyZueZf 8ipz5wRWzhfVoI7R Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart3403769.ohlsyk9j4l Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Am Montag, 7. September 2015, 12:21:37 schrieb Dmitry Osipenko: > 30.06.2015 17:15, Dmitry Osipenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver ma= ppings > > for ACPI") removed possibility to request GPIO by table index for n= on-ACPI > > platforms without changing it users. As result "shutdown" GPIO requ= est > > will fail if request for "reset" GPIO succeeded or "reset" will be > > requested instead of "shutdown" if "reset" wasn't defined. Fix it b= y > > making gpiod_lookup_table use con_id's instead of indexes. > >=20 > > Signed-off-by: Dmitry Osipenko > > Fixes: 72daceb (net: rfkill: gpio: Add default GPIO driver mappings= for > > ACPI) Cc: # v3.19+ > > Acked-by: Alexandre Courbot > > --- > >=20 > > v2: s/GPIO_LOOKUP_IDX/GPIO_LOOKUP/, otherwise "shutdown" GPIO won't= be > > requested>=20 > > arch/arm/mach-tegra/board-paz00.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > >=20 > > diff --git a/arch/arm/mach-tegra/board-paz00.c > > b/arch/arm/mach-tegra/board-paz00.c index fbe74c6..49d1110 100644 > > --- a/arch/arm/mach-tegra/board-paz00.c > > +++ b/arch/arm/mach-tegra/board-paz00.c > > @@ -39,8 +39,8 @@ static struct platform_device wifi_rfkill_device = =3D { > >=20 > > static struct gpiod_lookup_table wifi_gpio_lookup =3D { > > =20 > > =09.dev_id =3D "rfkill_gpio", > > =09.table =3D { > >=20 > > -=09=09GPIO_LOOKUP_IDX("tegra-gpio", 25, NULL, 0, 0), > > -=09=09GPIO_LOOKUP_IDX("tegra-gpio", 85, NULL, 1, 0), > > +=09=09GPIO_LOOKUP("tegra-gpio", 25, "reset", 0), > > +=09=09GPIO_LOOKUP("tegra-gpio", 85, "shutdown", 0), > >=20 > > =09=09{ }, > > =09 > > =09}, > > =20 > > }; >=20 > Ping also=20 Tested-by: Marc Dietrich I thing this should go through the tegra-soc tree. Thierry? Stephen? Marc --nextPart3403769.ohlsyk9j4l Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAABCAAGBQJV7pVPAAoJEKyeR39HFBtoP2cH/jnfj3sd5sheORZnC76uTj+I g6koeh2Ezv3OjLiTbWeIBgQD20BDN7qQl53jNa8XXIWpjwKZ/Dqqu7NLEQpmVreg dNxZJ+GC8ACkDDjdd36HIMCFbsllVM1RYot0Mtk/eid8v3V6WYKopERDDke8qLrh nGGzSZKNRqMVkqPAeOAkPaWnliJ8IwlXypuy/NjqoQf3EHo0Cvs02DQJc4jNEAGu zfULvN8laXWuQBV4K+wZlrS2jUSd/MnFeX1DQcLZRGYLijezjrArqIFnnyxHNYuC lLTPoaGbejlBORCqFqCCmOOC985jXB6IOrsjjV+ihfXn1vGqeQNi/Sayrj3HK3c= =xKHl -----END PGP SIGNATURE----- --nextPart3403769.ohlsyk9j4l--