From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752549AbdFLJRR (ORCPT ); Mon, 12 Jun 2017 05:17:17 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:48351 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751970AbdFLJRP (ORCPT ); Mon, 12 Jun 2017 05:17:15 -0400 Subject: Re: [PATCH v4] mfd: lp87565: Add lp87565 PMIC support To: Lee Jones References: <1496894894-6969-1-git-send-email-j-keerthy@ti.com> <20170609142855.tfixhw3cb5qjkcne@rob-hp-laptop> <7596b39a-3135-7cca-e3dc-18c05cf54a8b@ti.com> <7e352aa3-4483-1fa4-e424-cc90f62cdf46@ti.com> <20170612091133.kt2doom32bun6ujp@dell> CC: Rob Herring , , , , , From: Keerthy Message-ID: <373e82d1-39fb-9cbb-300a-aa8a99544cdc@ti.com> Date: Mon, 12 Jun 2017 14:47:03 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170612091133.kt2doom32bun6ujp@dell> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 12 June 2017 02:41 PM, Lee Jones wrote: > On Sun, 11 Jun 2017, Keerthy wrote: > >> >> >> On Sunday 11 June 2017 10:36 AM, Keerthy wrote: >>> >>> >>> On Friday 09 June 2017 07:58 PM, Rob Herring wrote: >>>> On Thu, Jun 08, 2017 at 09:38:14AM +0530, Keerthy wrote: >>>>> The LP87565 chip is a power management IC for Portable Navigation Systems >>>>> and Tablet Computing devices. It contains the following components: >>>>> >>>>> - Configurable Bucks(Single and multi-phase). >>>>> - Configurable General Purpose Output Signals (GPO). >>>>> >>>>> The LP87565-Q1 variant device uses two 2-phase outputs configuration, >>>>> Buck0 is master for Buck0/1 output and Buck2 is master for Buck2/3 >>>>> output. >>>>> >> >> Lee Jones, >> >> Shall i add back i2c_device_id as pointed here: >> http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1417316.html > > Hasn't that been fixed yet? > > I guess so then. :( Okay. So with that i assume i should reintroduce probe instead of probe_new. > >>>>> Signed-off-by: Keerthy >>>>> --- >>>>> >>>>> The other patches are already pulled by Mark. Hence posting >>>>> the remaining patch. >>>>> >>>>> Changes in v4: >>>>> >>>>> * Fixed device tree comments from Rob on the pmic node name. >>>>> * removed regulators from properties list as it is a node. >>>>> >>>>> Changes in v3: >>>>> >>>>> * Fixed License to GPL v2. >>>>> * Fixed an indentation issue. >>>>> >>>>> Changes in v2: >>>>> >>>>> * Fixed a bunch of whitespace errors. >>>>> * Changed the License to short form. >>>>> * Added the generic compatible lp87565 >>>>> * Removed i2c_device_id table. >>>>> * Introduced probe_new function in place of probe. >>>>> >>>>> Documentation/devicetree/bindings/mfd/lp87565.txt | 43 ++++ >>>> >>>> Acked-by: Rob Herring >>> >>> Thanks Rob. >>> >>>> >>>>> drivers/mfd/Kconfig | 14 ++ >>>>> drivers/mfd/Makefile | 1 + >>>>> drivers/mfd/lp87565.c | 92 ++++++++ >>>>> include/linux/mfd/lp87565.h | 270 ++++++++++++++++++++++ >>>>> 5 files changed, 420 insertions(+) >>>>> create mode 100644 Documentation/devicetree/bindings/mfd/lp87565.txt >>>>> create mode 100644 drivers/mfd/lp87565.c >>>>> create mode 100644 include/linux/mfd/lp87565.h >