From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751689AbdL2Rxh (ORCPT ); Fri, 29 Dec 2017 12:53:37 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:42270 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432AbdL2Rxf (ORCPT ); Fri, 29 Dec 2017 12:53:35 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20171229175332epoutp015725022caf5f735989ba2c45314feb88~E1Wb7ziDl3161531615epoutp01u X-AuditID: b6c32a37-42bff70000001041-c1-5a46811cc8bc From: Bartlomiej Zolnierkiewicz To: SF Markus Elfring Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, Tony Prisk , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] video/fbdev/vt8500lcdfb: Delete an error message for a failed memory allocation in vt8500lcd_probe() Date: Fri, 29 Dec 2017 18:53:29 +0100 Message-id: <3740850.4D0mjicDMo@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBIsWRmVeSWpSXmKPExsWy7bCmga5Mo1uUwYQFqhZXvr5nszjfuZzZ YustaYtNj6+xWpzo+8BqcXnXHDaLlssrmB3YPe53H2fy2Lyk3uP8/xZ2j6ZT7awenzfJBbBG cdmkpOZklqUW6dslcGX8fz+JsWArV8Xct+fZGhiPcHQxcnJICJhI9NzYzQJiCwnsYJR4/8K8 i5ELyP7OKLGnYR0rTNHPJ68YIYo2MEpcXhcHUfSVUeLd4rlsIAk2ASuJie2rgIo4OEQETCX+ nAgBqWEWuMIoMeHHbGaQGmGBaolpyw6BbWMRUJV4d/s0E4jNK6ApMbf9A5gtKuAlsWVfO5jN KeAp0di7HKpGUOLH5HtgvcwC8hL79k9lhbB1JM4eW8cIskxCYA+bxIN3q9khrnaROLjjDiOE LSzx6vgWdpDjJASkJS4dtYUIT2eU2P5bAqJ3M6PEqt0ToHqtJQ4fvwi1gE/i3dceVoheXomO NiGIEg+JJV+mQI13lPj16jAbJFDmAENuxmTWCYyys5DcPQvJ3bOQ3L2AkXkVo1hqQXFuemqx YYGxXnFibnFpXrpecn7uJkZwetAy38G44ZzPIUYBDkYlHt6ETNcoIdbEsuLK3EOMEhzMSiK8 1jVuUUK8KYmVValF+fFFpTmpxYcYpTlYlMR5AwJcooQE0hNLUrNTUwtSi2CyTBycUg2MMTWZ F+L3lb0v0f9T/+uv/7dTEZM///v8dd6N6n7TDq3uxN/vHD7s8ijyKtg06+te1+fL8n74FAg8 N2B8K6w6XaRPekvBgfcxR5ceE23qmGvCI9Xp59eZvNi3YbPR0ucTz3/tPRWsvTvZfsOcR7d3 ZMZc0ZTZ9TGq/+uf9vtWi7yOnjscpvD7hRJLcUaioRZzUXEiAAjTIawLAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrELMWRmVeSWpSXmKPExsVy+t9jQV3pRrcogym3FS2ufH3PZnG+czmz xdZb0habHl9jtTjR94HV4vKuOWwWLZdXMDuwe9zvPs7ksXlJvcf5/y3sHk2n2lk9Pm+SC2CN 4rJJSc3JLEst0rdL4Mr4/34SY8FWroq5b8+zNTAe4ehi5OSQEDCR+PnkFSOILSSwjlFi/gyn LkYuIPsro8S25v8sIAk2ASuJie2rgIo4OEQETCX+nAgBqWEWuMIosX/ieXaQGmGBaolpyw6B 1bMIqEq8u32aCcTmFdCUmNv+AcwWFfCS2LKvHczmFPCUaOxdzgSxbB6jxI+OlYwQDYISPybf AxvELCAvsW//VFYIW0ti/c7jTBMY+WchKZuFpGwWkrIFjMyrGCVTC4pz03OLjQoM81LL9YoT c4tL89L1kvNzNzECQ3rbYa2+HYz3l8QfYhTgYFTi4eVId40SYk0sK67MPcQowcGsJMJrXeMW JcSbklhZlVqUH19UmpNafIhRmoNFSZz3dt6xSCGB9MSS1OzU1ILUIpgsEwenVAOja57UhPda /x/dCfov0niTwY5NWmDu0dZNV7wCsudP/uf/VP7Hufdr7HSLl97Nf2+pcanMcYvDkuuqMQlC ecKNd5zPvlx4d0PcqtuuK89dS47XdIrXs3GuPbjv155thnFhc1ZmdnMka044uaCLZ1aK2K8F dkeVVi6dV1WsfPnW1GmbzJ7PqDrTpsRSnJFoqMVcVJwIAOjcEMllAgAA X-CMS-MailID: 20171229175331epcas1p368c28f6550ba147bd8aecff6aff303c1 X-Msg-Generator: CA CMS-TYPE: 101P X-CMS-RootMailID: 20171124195318epcas2p1b030ce8d47da92659b3c6068c0810778 X-RootMTR: 20171124195318epcas2p1b030ce8d47da92659b3c6068c0810778 References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, November 24, 2017 08:53:02 PM SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 24 Nov 2017 20:42:08 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/video/fbdev/vt8500lcdfb.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/video/fbdev/vt8500lcdfb.c b/drivers/video/fbdev/vt8500lcdfb.c > index 1a1176bf0906..5c5cd2923041 100644 > --- a/drivers/video/fbdev/vt8500lcdfb.c > +++ b/drivers/video/fbdev/vt8500lcdfb.c > @@ -289,10 +289,8 @@ static int vt8500lcd_probe(struct platform_device *pdev) > > fbi = devm_kzalloc(&pdev->dev, sizeof(struct vt8500lcd_info) > + sizeof(u32) * 16, GFP_KERNEL); > - if (!fbi) { > - dev_err(&pdev->dev, "Failed to initialize framebuffer device\n"); > + if (!fbi) > return -ENOMEM; > - } > This removes the information about the device for which the allocation fails (but as there can be only one vt8500lcdfb device in the system this change is okay). Patch queued for 4.16, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics