From: Tom St Denis <tom.stdenis@amd.com>
To: Corentin Labbe <clabbe@baylibre.com>,
David1.Zhou@amd.com, airlied@linux.ie, alexander.deucher@amd.com,
christian.koenig@amd.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 00/13] gpu: drm: amd: remove unused headers
Date: Wed, 14 Feb 2018 14:35:58 -0500 [thread overview]
Message-ID: <3746a404-0811-0529-1e6a-faab5aaffe2e@amd.com> (raw)
In-Reply-To: <1518619577-19771-1-git-send-email-clabbe@baylibre.com>
This will break umr since we source the headers from the kernel. The
kernel might not use them but the different IP blocks have deltas that
umr is aware of.
One might argue that we should then publish the headers somewhere else
that is public but the kernel is our vehicle right now.
Thoughts Alex/Christian?
Tom
On 14/02/18 09:46 AM, Corentin Labbe wrote:
> Hello
>
> This patchset remove several headers which are not used by any source
> file.
>
> Regards
>
> Change since v1:
> - splited in multiple patchs
>
> Change since v2
> - Use --irreversible-delete for format-patch
>
> Corentin Labbe (13):
> drm/amd/include: remove unused asic_reg/oss headers
> drm/amd/include: remove unused asic_reg/bif headers
> drm/amd/include: remove unused asic_reg/dce headers
> drm/amd/include: remove unused asic_reg/gca headers
> drm/amd/include: remove unused asic_reg/gmc headers
> drm/amd/include: remove unused asic_reg/smu headers
> drm/amd/include: remove unused asic_reg/umc headers
> drm/amd/include: remove unused asic_reg/uvd headers
> drm/amd/include: remove unused asic_reg/vce headers
> drm/amd/include: remove unused asic_reg/sdma headers
> drm/amd/include: remove unused asic_reg/nbif headers
> drm/amd/include: remove unused displayobject.h header
> drm/amd/powerplay: remove unused headers
>
> .../drm/amd/include/asic_reg/bif/bif_5_0_enum.h | 1198 --
> .../drm/amd/include/asic_reg/bif/bif_5_1_enum.h | 1068 -
> .../drm/amd/include/asic_reg/dce/dce_11_2_enum.h | 6813 ------
> .../drm/amd/include/asic_reg/dce/dce_8_0_enum.h | 1117 -
> .../gpu/drm/amd/include/asic_reg/gca/gfx_8_1_d.h | 2791 ---
> .../drm/amd/include/asic_reg/gca/gfx_8_1_enum.h | 6808 ------
> .../drm/amd/include/asic_reg/gca/gfx_8_1_sh_mask.h | 21368 -------------------
> .../drm/amd/include/asic_reg/gmc/gmc_8_1_enum.h | 1198 --
> .../drm/amd/include/asic_reg/gmc/gmc_8_2_enum.h | 1068 -
> .../amd/include/asic_reg/nbif/nbif_6_1_sh_mask.h | 10281 ---------
> .../drm/amd/include/asic_reg/oss/oss_2_4_enum.h | 1340 --
> .../drm/amd/include/asic_reg/oss/oss_3_0_1_enum.h | 1464 --
> .../drm/amd/include/asic_reg/oss/oss_3_0_enum.h | 1497 --
> .../amd/include/asic_reg/sdma0/sdma0_4_0_default.h | 286 -
> .../amd/include/asic_reg/sdma1/sdma1_4_0_default.h | 282 -
> .../gpu/drm/amd/include/asic_reg/smu/smu_6_0_d.h | 148 -
> .../drm/amd/include/asic_reg/smu/smu_6_0_sh_mask.h | 715 -
> .../gpu/drm/amd/include/asic_reg/smu/smu_7_1_0_d.h | 1344 --
> .../drm/amd/include/asic_reg/smu/smu_7_1_0_enum.h | 1191 --
> .../amd/include/asic_reg/smu/smu_7_1_0_sh_mask.h | 5648 -----
> .../drm/amd/include/asic_reg/smu/smu_7_1_1_enum.h | 1205 --
> .../drm/amd/include/asic_reg/smu/smu_7_1_2_enum.h | 1246 --
> .../drm/amd/include/asic_reg/smu/smu_7_1_3_enum.h | 1282 --
> .../drm/amd/include/asic_reg/smu/smu_8_0_enum.h | 1072 -
> .../drm/amd/include/asic_reg/umc/umc_6_0_default.h | 31 -
> .../drm/amd/include/asic_reg/umc/umc_6_0_offset.h | 52 -
> .../drm/amd/include/asic_reg/uvd/uvd_4_0_sh_mask.h | 795 -
> .../drm/amd/include/asic_reg/uvd/uvd_5_0_enum.h | 1211 --
> .../drm/amd/include/asic_reg/uvd/uvd_6_0_enum.h | 1081 -
> .../gpu/drm/amd/include/asic_reg/vce/vce_1_0_d.h | 64 -
> .../drm/amd/include/asic_reg/vce/vce_1_0_sh_mask.h | 99 -
> drivers/gpu/drm/amd/include/displayobject.h | 249 -
> .../gpu/drm/amd/powerplay/inc/polaris10_ppsmc.h | 412 -
> drivers/gpu/drm/amd/powerplay/inc/pp_feature.h | 67 -
> 34 files changed, 76491 deletions(-)
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/bif/bif_5_0_enum.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/bif/bif_5_1_enum.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/dce/dce_11_2_enum.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/dce/dce_8_0_enum.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/gca/gfx_8_1_d.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/gca/gfx_8_1_enum.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/gca/gfx_8_1_sh_mask.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/gmc/gmc_8_1_enum.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/gmc/gmc_8_2_enum.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/nbif/nbif_6_1_sh_mask.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/oss/oss_2_4_enum.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/oss/oss_3_0_1_enum.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/oss/oss_3_0_enum.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/sdma0/sdma0_4_0_default.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/sdma1/sdma1_4_0_default.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/smu/smu_6_0_d.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/smu/smu_6_0_sh_mask.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/smu/smu_7_1_0_d.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/smu/smu_7_1_0_enum.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/smu/smu_7_1_0_sh_mask.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/smu/smu_7_1_1_enum.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/smu/smu_7_1_2_enum.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/smu/smu_7_1_3_enum.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/smu/smu_8_0_enum.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/umc/umc_6_0_default.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/umc/umc_6_0_offset.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/uvd/uvd_4_0_sh_mask.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/uvd/uvd_5_0_enum.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/uvd/uvd_6_0_enum.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/vce/vce_1_0_d.h
> delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/vce/vce_1_0_sh_mask.h
> delete mode 100644 drivers/gpu/drm/amd/include/displayobject.h
> delete mode 100644 drivers/gpu/drm/amd/powerplay/inc/polaris10_ppsmc.h
> delete mode 100644 drivers/gpu/drm/amd/powerplay/inc/pp_feature.h
>
next prev parent reply other threads:[~2018-02-14 19:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 14:46 Corentin Labbe
2018-02-14 14:46 ` [PATCH v3 01/13] drm/amd/include: remove unused asic_reg/oss headers Corentin Labbe
2018-02-14 14:46 ` [PATCH v3 02/13] drm/amd/include: remove unused asic_reg/bif headers Corentin Labbe
2018-02-14 14:46 ` [PATCH v3 03/13] drm/amd/include: remove unused asic_reg/dce headers Corentin Labbe
2018-02-14 14:46 ` [PATCH v3 04/13] drm/amd/include: remove unused asic_reg/gca headers Corentin Labbe
2018-02-14 14:46 ` [PATCH v3 05/13] drm/amd/include: remove unused asic_reg/gmc headers Corentin Labbe
2018-02-14 14:46 ` [PATCH v3 06/13] drm/amd/include: remove unused asic_reg/smu headers Corentin Labbe
2018-02-14 14:46 ` [PATCH v3 07/13] drm/amd/include: remove unused asic_reg/umc headers Corentin Labbe
2018-02-14 14:46 ` [PATCH v3 08/13] drm/amd/include: remove unused asic_reg/uvd headers Corentin Labbe
2018-02-14 14:46 ` [PATCH v3 09/13] drm/amd/include: remove unused asic_reg/vce headers Corentin Labbe
2018-02-14 14:46 ` [PATCH v3 10/13] drm/amd/include: remove unused asic_reg/sdma headers Corentin Labbe
2018-02-14 14:46 ` [PATCH v3 11/13] drm/amd/include: remove unused asic_reg/nbif headers Corentin Labbe
2018-02-14 14:46 ` [PATCH v3 12/13] drm/amd/include: remove unused displayobject.h header Corentin Labbe
2018-02-14 14:46 ` [PATCH v3 13/13] drm/amd/powerplay: remove unused headers Corentin Labbe
2018-02-19 17:03 ` Alex Deucher
2018-02-14 19:35 ` Tom St Denis [this message]
2018-02-14 19:48 ` [PATCH v3 00/13] gpu: drm: amd: " Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3746a404-0811-0529-1e6a-faab5aaffe2e@amd.com \
--to=tom.stdenis@amd.com \
--cc=David1.Zhou@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=clabbe@baylibre.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®