From: "Arnd Bergmann" <arnd@arndb.de>
To: "Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Randy Dunlap" <rdunlap@infradead.org>,
"kernel test robot" <lkp@intel.com>,
"Masahiro Yamada" <masahiroy@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
"Nicolas Schier" <nicolas@fjasle.eu>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>
Subject: Re: pm.c:undefined reference to `i8042_command'
Date: Thu, 14 Dec 2023 19:54:18 +0000 [thread overview]
Message-ID: <374978b4-9bed-4d5c-90e2-344e46dedaf8@app.fastmail.com> (raw)
In-Reply-To: <40b5e438-22f4-43e5-9663-db44dd402a35@app.fastmail.com>
On Thu, Dec 7, 2023, at 01:21, Jiaxun Yang wrote:
> 在2023年12月6日十二月 下午5:26，Randy Dunlap写道：
>> On 12/5/23 22:52, Arnd Bergmann wrote:
>>> On Wed, Dec 6, 2023, at 06:24, Randy Dunlap wrote:
>>> I think it's bad style to force-select an optional subsystem.
>>> How about making the entire file optional? It seems that there
>>> are already __weak functions in its place.
>>
>> Yes, I agree in general.
>>
>> Hopefully the maintainer will opine your suggestion.
>> Jiaxun?
>
> LGTM, PM is not an essential function here.
> Arnd, do you mind making it a patch?
>
I just tried it out and my version doesn't actually work since
we still end up building the file with SERIO_I82042=m.
We could still make it work by checking for serio being
built-in here, but in the end I think that's worse than
Randy's patch, so let's just go with his original version.
Arnd
next prev parent reply other threads:[~2023-12-14 19:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 12:02 kernel test robot
2023-12-06 5:24 ` Randy Dunlap
2023-12-06 6:52 ` Arnd Bergmann
2023-12-06 17:26 ` Randy Dunlap
2023-12-07 1:21 ` Jiaxun Yang
2023-12-14 19:54 ` Arnd Bergmann [this message]
2023-12-14 23:57 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=374978b4-9bed-4d5c-90e2-344e46dedaf8@app.fastmail.com \
--to=arnd@arndb.de \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lkp@intel.com \
--cc=masahiroy@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®