From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65D244DC54F for ; Wed, 3 Jun 2026 23:58:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780531135; cv=none; b=AMFI3ubad6h5JVHO9vXPcZwP7PzJpbzes/X/VwcA5rupiuS8/quTtsHnfEAZF6nWglKk/UsRS9gDTHSfz+XcZj+Fzwpd9mo8InAMNTWRr9dOCNFDa09nqZNFrbt/I0YyW7Yc1xu87t5Rp70Nj+j7ju5P2pL3SHgG5O8c+abvF1U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780531135; c=relaxed/simple; bh=kWMiMYyYTblMdxaqUykMu540IEbsJMH91t9UFLHf35E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iUy+xolPp6AXd719NF3wfbmCUqjCgRwhg6DVCaPJjpxeO9CxxOrdm7g8qzeohaZt5w7eZzPOaQo7YebB9TD16c4yducLe5gX3q1ToZ5w+wcGxiSDCt0NTC6XM+gkleRHNWxPYRytHXsni8+2Al83zMlDBiOQTvpl7S9njphRzsM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AEHtQGbs; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AEHtQGbs" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-5aa65757ef4so9530e87.2 for ; Wed, 03 Jun 2026 16:58:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1780531133; x=1781135933; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=+1SCC74DIXhE8DyDejW1+bo9tsnjHROThMMbJp6vt8s=; b=AEHtQGbsoAYiTKBciyB26ntjRTa3U/5vlurTZQ6MIivjc6Hd6LFg1VJ68Mpj1eazeG DINJTnIyYpFSwLbd2boAPf/73wVDZ/I+7V/c6GUBh8bo9xUsXJb70PWSFzEXwrqKXaRv 6Ww3A5tTfp3FdRv12Xyjbe187WGD+bhK3tffQxh43xAtWxWqysaJ6CHf8iijuQspl2EW a5fmQPW9/W1GHEsFXeIJj+8Z0pvHIKEQHGGwJTNBecV7laCHgGsGvhXJNKVWlzHu3oNx SBQk9yAnFuy8QWjpOopiIZ0QFpjMl9HtYGKGFNBwdtvgEffZIOJFtaYsf8isGt+7NsE5 X1Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780531133; x=1781135933; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+1SCC74DIXhE8DyDejW1+bo9tsnjHROThMMbJp6vt8s=; b=tO1ulkZv6zqbrJK9TGtJt/nixrY3+98eC1DU7ytbcNOTjcYFcFL9QcmLBZNCqYtMue xTEUTKZzlf9OeqP8rK+ifZ6dBkc+xgLkn3EVYWBLkl1XDxmmpJMK4nRQx9sZB3mSVp5a wQtte1Y9lJXorxYdPoFtzVaRyLCWzvP14FE97YzI2eQw3gmH16495gX/6IoqIrUMrrNB uwjqsEVVvTcWXzQrjllKDfxZCCfSX0eXoq6WN5trzJupLU25iubP5I6WotjYgobEI0Z1 nrcSkk5eWZcI91NXZwpiBiuFiwaYl1zzAxQOaItlemdqdH7xsXTvhkOEQEaRU1/pghiM qoxw== X-Forwarded-Encrypted: i=1; AFNElJ9UKx/8zILAWg3xNi+W65IHtq5JiuzFkvnJhqImTfk6zSRrQ6yT3ISEUzvY88hacSLl02iszXSNJCvkYSE=@vger.kernel.org X-Gm-Message-State: AOJu0YwYg+sTbvY+7wRw5GgbYdsmOkM2SKosusq6VQnNV5G2dqBhjMi5 F4msrmNUqKDKMyP+MS6LI5YVcbJ9qxfRmdSLReHNEs8JTO9YrvmIFz1mLo2SR6tl7nBQHnMdeEz Y+UGYQpc= X-Gm-Gg: Acq92OEsXgF2vWel7kmDy+48ML0qpJI9YM2MQ1SP8DgzebaXH5RchkycdI9Sm/tof/n GOOn1MMU/PVTn8etWP+RJSNE7F/g38hiseKqJ63lArrYz9VL+jhxagGM3Fwsq3OfmpS4H5bJMs1 LIgsPRI68aadWPx7WwXDMY2XMq1wtAy0+lsmVcJMkRe3CJUOQl8MBB7bi1GcAI3r2t2TbrgZegb uJsZlcwVTSqH4rWw1mj4YbCBoR0uWvnHhAi0CztSL+XJ7Gil9Y4cX+L3xO2eBVPfH4o7+MjGo6Q gadqPo+pfJF1m97mIcsMcCKXHyb0g9FcCd9oyPOihCDKf8P4zGyx+/j2TXGI2qvu5DlLimLk32m MOunBCMCzIOqvkjCP4LjV6T1d8sv2L3Dz/i0wObTvf68Rws1snTjHvQtdJKVXjOsOejg7JXL/FZ 1kwbexBSX75WPN603n+FknCSsSUHq7srrSEam0KlUDKnxVsyhHgKUHsJo6vFvMDTFmFy280/cYK ZXz5pv9Wgs+DHHF X-Received: by 2002:a05:6512:6404:b0:5aa:635f:7c08 with SMTP id 2adb3069b0e04-5aa7bf5279dmr878301e87.7.1780531132531; Wed, 03 Jun 2026 16:58:52 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aa7b8ed659sm899338e87.12.2026.06.03.16.58.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jun 2026 16:58:51 -0700 (PDT) Message-ID: <374f17c6-f08e-4f4b-a6c1-ef2cd1b87631@linaro.org> Date: Thu, 4 Jun 2026 02:58:50 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 2/2] phy: qcom-mipi-csi2: Add a CSI2 MIPI DPHY driver To: Bryan O'Donoghue , Bryan O'Donoghue , Dmitry Baryshkov Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260523-x1e-csi2-phy-v8-0-a85668459521@linaro.org> <20260523-x1e-csi2-phy-v8-2-a85668459521@linaro.org> <54904b61-222d-4600-ad4c-c03a9952d337@linaro.org> <8eb709ce-3469-4303-9c3d-8d1a221cb8de@linaro.org> <4QKRXnKlt962x7eipKO1dLr9tzEF6a3M65FZXI8PNsXwx_RhKzJtEfQKOOwI8synBSe0GtUZxWVFFeD1qVlGnA==@protonmail.internalid> <6e962010-8097-4b52-9369-0727c0d5a31a@linaro.org> <41ab1685-3d0a-4c8b-b7a9-6e9299c48400@kernel.org> From: Vladimir Zapolskiy In-Reply-To: <41ab1685-3d0a-4c8b-b7a9-6e9299c48400@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/4/26 00:12, Bryan O'Donoghue wrote: > On 03/06/2026 21:42, Vladimir Zapolskiy wrote: >>>> Split configurations explicitly use other lanes for clocks. E.g. check >>>> the RB5 Navigation schematics, CAM0B connector. >>> Can you please check: >>> >>> CSI_3PHASE_COMMON.CSI_COMMON_CTRL5 >>> >>> 0 LN0_PWRDN_B Lane 0 >>> ... >>> 7 LNCK_PWRDN_B Clock Lane >> Please note that media devices have a numeration scheme of lanes starting >> from 1 (it'd be easy to check/confirm it), for instance today CAMSS has >> lane numeration starting from 0 is out of the accepted scheme, and here >> it'd be better to correct it and not enter the same pit. > > Yes fair point CAMSS has done this wrong since forever. data-lanes = <1 > 2 3 4> => LN0, LN1, LN2, LN3> >> I don't have access to the IP spec, anyway I do not grasp it, where are >> 8 lanes on the CSIPHY found? Each CSIPHY IP has 4+1 D-PHY lanes, not 8. > > Max CSI2 data-lanes is 8 > > #define V4L2_MBUS_CSI2_MAX_DATA_LANES 8 > Judging by the name that's something V4L2 or in other words software specific, while I do reference to the actual pads of Qualcomm SoCs, and I do not see 8 differential pairs per a CSIPHY, but only 5 lanes. If that's correct, the data/clock lane numbers should lay in 1 to 5 range. > That doesn't really explain why this register has seven data-lanes and > one-clock lane. > > It just is what it is. > -- Best wishes, Vladimir