From: "Alex G." <mr.nuke.me@gmail.com>
To: Sinan Kaya <okaya@kernel.org>,
bhelgaas@google.com, keith.busch@intel.com
Cc: alex_gagniuc@dellteam.com, austin_bolen@dell.com,
shyam_iyer@dell.com, Frederick Lawler <fred@fredlawl.com>,
Oza Pawandeep <poza@codeaurora.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI/AER: Do not clear AER bits if we don't own AER
Date: Thu, 19 Jul 2018 10:55:06 -0500 [thread overview]
Message-ID: <37509c44-64fe-4140-c776-53c3346cbfe5@gmail.com> (raw)
In-Reply-To: <494a5df8-0987-3a6c-30a4-a3c9ef4ed1f3@kernel.org>
On 07/17/2018 10:41 AM, Sinan Kaya wrote:
>
> On 7/17/2018 8:31 AM, Alexandru Gagniuc wrote:
>> + if (pcie_aer_get_firmware_first(dev))
>> + return -EIO;
>
> Can you move this to closer to the caller pci_aer_init()?
I could move it there. although pci_cleanup_aer_error_status_regs() is
called directly from pci_restore_state. Of course, aer_cap should be
zero in this case, and we'd still bail out.
I find the intent clearer if we check it here rather than having to do
the mental parsing of the state of aer_cap.
Alex
next prev parent reply other threads:[~2018-07-19 15:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 15:31 Alexandru Gagniuc
2018-07-17 15:41 ` Sinan Kaya
2018-07-19 15:55 ` Alex G. [this message]
2018-07-19 16:58 ` Sinan Kaya
2018-07-19 19:56 ` Alex G.
2018-07-23 16:52 ` [PATCH v2] " Alexandru Gagniuc
2018-07-24 15:59 ` Alex G.
2018-07-30 23:35 ` [PATCH v3] " Alexandru Gagniuc
2018-08-08 1:14 ` Bjorn Helgaas
2018-08-08 3:46 ` Alex G.
2018-07-24 17:08 ` [PATCH v2] " kbuild test robot
2018-07-25 1:03 ` kbuild test robot
2018-08-09 14:15 ` [PATCH] " Bjorn Helgaas
2018-08-09 16:46 ` Alex_Gagniuc
2018-08-09 18:29 ` Bjorn Helgaas
2018-08-09 19:00 ` Alex G.
2018-08-09 19:18 ` Bjorn Helgaas
2018-08-09 19:42 ` Alex G.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37509c44-64fe-4140-c776-53c3346cbfe5@gmail.com \
--to=mr.nuke.me@gmail.com \
--cc=alex_gagniuc@dellteam.com \
--cc=austin_bolen@dell.com \
--cc=bhelgaas@google.com \
--cc=fred@fredlawl.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=okaya@kernel.org \
--cc=poza@codeaurora.org \
--cc=shyam_iyer@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®