From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752211AbcGAI4e (ORCPT ); Fri, 1 Jul 2016 04:56:34 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35726 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752014AbcGAI4a (ORCPT ); Fri, 1 Jul 2016 04:56:30 -0400 Subject: Re: [PATCH v1 07/11] KVM: VMX: optimize APIC ID read with APICv To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <20160630205429.16480-1-rkrcmar@redhat.com> <20160630205429.16480-8-rkrcmar@redhat.com> Cc: "Lan, Tianyu" , Igor Mammedov , Jan Kiszka , Peter Xu From: Paolo Bonzini Message-ID: <37522ab8-1af8-b7a1-320d-66622e89197b@redhat.com> Date: Fri, 1 Jul 2016 10:42:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160630205429.16480-8-rkrcmar@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/06/2016 22:54, Radim Krčmář wrote: > The register is in hardware-compatible format now, so there is not need > to intercept. > > Signed-off-by: Radim Krčmář > --- > v1: new, split from the previous patch > > arch/x86/kvm/vmx.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index 85e2f0a882ca..a10038258b80 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -6447,9 +6447,6 @@ static __init int hardware_setup(void) > for (msr = 0x800; msr <= 0x8ff; msr++) > vmx_disable_intercept_msr_read_x2apic(msr); > > - /* According SDM, in x2apic mode, the whole id reg is used. But in > - * KVM, it only use the highest eight bits. Need to intercept it */ > - vmx_enable_intercept_msr_read_x2apic(0x802); > /* TMCCT */ > vmx_enable_intercept_msr_read_x2apic(0x839); > /* TPR */ > Reviewed-by: Paolo Bonzini