From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Michael Ellerman <mpe@ellerman.id.au>,
Zhouyi Zhou <zhouzhouyi@gmail.com>,
npiggin@gmail.com, atrajeev@linux.vnet.ibm.com,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
lance@osuosl.org, paulmck@kernel.org, rcu@vger.kernel.org
Subject: Re: [PATCH linux-next] powerpc: disable sanitizer in irq_soft_mask_set
Date: Tue, 23 Aug 2022 18:50:54 +0200 [thread overview]
Message-ID: <3756ad84-a5b0-b404-7962-86f77d6f38b3@csgroup.eu> (raw)
In-Reply-To: <0d7b55bc-4dd2-7de1-8ca5-353b1a044caf@csgroup.eu>
Le 23/08/2022 à 10:47, Christophe Leroy a écrit :
>
>
> Le 23/08/2022 à 10:33, Michael Ellerman a écrit :
>> Zhouyi Zhou <zhouzhouyi@gmail.com> writes:
>>
>> My worry is that this will force irq_soft_mask_set() out of line, which
>> we would rather avoid. It's meant to be a fast path.
>>
>> In fact with this applied I see nearly 300 out-of-line copies of the
>> function when building a defconfig, and ~1700 calls to it.
>>
>> Normally it is inlined at every call site.
>>
>>
>> So I think I'm inclined to revert ef5b570d3700 ("powerpc/irq: Don't open
>> code irq_soft_mask helpers").
>
> Could you revert it only partially ? In extenso, revert the
> READ/WRITE_ONCE and bring back the inline asm in irq_soft_mask_return()
> and irq_soft_mask_set(), but keep other changes.
I sent a patch doing that.
Christophe
next prev parent reply other threads:[~2022-08-23 18:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-21 1:00 Zhouyi Zhou
2022-08-22 6:04 ` Christophe Leroy
2022-08-23 1:43 ` Zhouyi Zhou
2022-08-23 5:53 ` Christophe Leroy
2022-08-23 8:33 ` Michael Ellerman
2022-08-23 8:47 ` Christophe Leroy
2022-08-23 16:50 ` Christophe Leroy [this message]
2022-08-24 1:25 ` Zhouyi Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3756ad84-a5b0-b404-7962-86f77d6f38b3@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=lance@osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=zhouzhouyi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®