From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013050.outbound.protection.outlook.com [40.107.201.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90556259CB2 for ; Fri, 22 May 2026 04:14:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.50 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779423274; cv=fail; b=aAcyH+tEdcHawCUDcaIL2BB9N096059hgm9UZfDXvYZACkNrcXRBvQR2mNYiim5kuZBXTsLyWbmfuLVQ13lSTYgkWRjhTTUqYUWNiddfastfeDI0CJ3q7MBBPGY4pYYxcXJDTBOugQpKol70BaftCfyOkhVqzLpUPIn3NE5E3Sc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779423274; c=relaxed/simple; bh=y+tjj4/TKRwLIRpa6WZuHibLxtmv1E0eC8Z2uOH5ml0=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=YLep42DeNiBX6hKndLk088WDSd+RIzzLYpaVAJob5h0Io/KPvOuMCD0oj6OGSgH+f/T6GwPgZMpzUEfcA6bqVu/x73ekJHOBo4TQrC99AvTuCgAA7iP+t19SrjHyt8i7DCnPoLE1cvM4wK1UuXXTLcIaCAsTABt5QX1WVSHcNjY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=EwYWGY4+; arc=fail smtp.client-ip=40.107.201.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="EwYWGY4+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VDKZOYPJTeuKqwFPd8sgOKQUALkWudLxSlW+s08/42RA56GIeFLv19yhHcyDkaFCvX1hUaHWfUxRt+AfeJ+d24GxfcvKIuwrSLeeYm7181lEfiffW9ZvU1DgCttcIG1FoLtgifg3w+JU5r8784q/yda5FnusLr0GxejQWVJfovIl4h08n3uBseXRI4m8lViVXh/oz8FSPbf/7EeCvxaCWGM39/ID1V2rH846GITQARbWqfyepbHDF5WqQcbh1l/8+hJQG9BI5apbao/z3fNSPH2GgfIAgY54irxj8PlE03dfQlncfxIIYrorHTzSWvUkJpDJht3eoDYBbFV51J4YNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MHd763xBWW3uZp6HZNQ83kRFtA0dzqlVIWUDIwOcthc=; b=ZnNHcJpwk1Wu1q6FC89JyuS66Bv8WtHNRryXhX3DqRAqCuQQHbQ2NDcIdi3Qvrox/d8KufqDkE7ob9G69QBtl+a3Xi+s+EXlDbuFNDCSetO31pDQtJtD1RI8mLogvnvKEUB6yD8aoiXQRX4BbZ49Ygv5wl/SziAVW91OmL2jqf7ryacUu4cjDeO98SHzzJ3XvaIhHRluMbdmwNPb+WCI5qmaQed8k2hUumiN4nOOiqhaqsiinqcCfsCduQreCJ9+XRS03C0ANfcddajffqhzRPtyQ2CdoSdSI5fhcPLaTvMNW0j9z8dnyfv4FNaw8g2AGEHKp6updvEMacYp9sssZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nvidia.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MHd763xBWW3uZp6HZNQ83kRFtA0dzqlVIWUDIwOcthc=; b=EwYWGY4+RRTDtg2oeiBn/fKFDVR1oKSPwk9mEwJ1kIS0Y0+Bwn47n0rXy+I7JSLo/jtOJi30XDm3qwnzc8l5NXsZi/sTmF5bxoZ1vm7UDUwOeLvbOfamJMOlgE7dPI3v6N5d+spa26L3uUoRn2CmlCc9UTgh5EHHKzPTpI1j1yE= Received: from BL1P223CA0037.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:5b6::14) by CH3PR12MB9147.namprd12.prod.outlook.com (2603:10b6:610:19a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.48.14; Fri, 22 May 2026 04:14:26 +0000 Received: from BL6PEPF0001AB59.namprd02.prod.outlook.com (2603:10b6:208:5b6:cafe::b6) by BL1P223CA0037.outlook.office365.com (2603:10b6:208:5b6::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.48.17 via Frontend Transport; Fri, 22 May 2026 04:14:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by BL6PEPF0001AB59.mail.protection.outlook.com (10.167.241.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.7 via Frontend Transport; Fri, 22 May 2026 04:14:26 +0000 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Thu, 21 May 2026 23:14:26 -0500 Received: from [172.31.184.125] (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Thu, 21 May 2026 23:14:22 -0500 Message-ID: <375744de-2587-477c-ad4a-9eff22a5b4b9@amd.com> Date: Fri, 22 May 2026 09:44:15 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] sched/fair: Restore RCU read lock in set_cpu_sd_state_{busy,idle}() To: Andrea Righi , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot CC: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Marek Szyprowski , References: <20260521205115.1689545-1-arighi@nvidia.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20260521205115.1689545-1-arighi@nvidia.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB59:EE_|CH3PR12MB9147:EE_ X-MS-Office365-Filtering-Correlation-Id: 26078040-1e21-4008-d650-08deb7b89ccf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|1800799024|7416014|376014|82310400026|22082099003|18002099003|56012099003|11063799006; X-Microsoft-Antispam-Message-Info: dBFFVm4T6ifBNvdoZmu3N13EdpBmi0sy2GAjyFW215gnivfCjqJqi6Db+Ab+XgSyR2EVeDkH5sTRpCl9Y6C9pU3vT0oye0T2o9Hy93qTh3vwRT47FUvxtiPJk+o4Lcv9PjzuS8Qb5MvGkUz1B6T6JQuzf4BkS6SsbX+20ZH+4DxtqQPAC9jDa0+J5KNCEt6reLLu3IEGyxOYEcecyiX/ReG6E+I2QSfrYqlqHRJA1TFDd+hd8GJ56OEwdxNH9oV71jQI+NHebXGDFsQxYIA1dt0g1KQJnA1J3u9SwfQ8Ihr7vqlvgK/vJTMzw5Xi//AVNseURjWRnsbdTolPjb2gI9iqWflVJFK0VPnaY5VxDWVR2FkBRXZjigzOIyS0DiCwFT3x1vjcH4fQV0JvisiHQJ82c35bzwsFkvkCdR7dKrhwOfv4qHL7NsQlLze6DG9vjDvf83rtbj7d9LhmsXnDlguyjOlcBgCP06mOLWZH3i3Mxj8H17w0piwkE0Zuurd+/tXGrJgY7TzntP7TixQey97ett+gIHO3DFITFIoEa+VeDLYF4wqi78ANslUxHdyJdVzwRWn88HJvww9p8/plYV9hZqCnnRxOOj1QINwbpOsuuTkQdIBv5MsXIZiWC2wz7XLcXF2vDiv382RhG5CV0SHC4t9xWAMl97aipDFFfbHfDz1v9Ieo0Y/6jyb2O2+fyhnnyqn5oUg9xO6d3iBhC+9e2dpalOghiYwfGNI/R2w= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(1800799024)(7416014)(376014)(82310400026)(22082099003)(18002099003)(56012099003)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: zrhYRjGR+7Yrex4XWOqzMInQ/rOSDLkkDHMtmGUFE9bkq5x04I+DqwNuFYt5ndnQXsZgXGDzB38AcA3hoHJiul2zyt0z9BCggOQ2fw9A6PSmcTzZY/IPCXzau2EowpOQOeLls/zNUe0hgxlBXoRCq8puxtBi0ouPlGLC1oCWfyXLvGPR88jGFf6vnkdWivOSDjcm8Bo/seiOc0b/tbwS17AXuG6aAYmdg4BOSYw7GVgbT6QpZd7QYuPnVoMxdeT0Oj6WDhJB1Jz1NdKEfhtu1/PCw8yK8qmXWZyExS/xNezOYknt7GWqLvtihZLM9KI2gd/53DI9b8ImH8+fxI8RXg9vgHbz8x1R/x0RR8IAsRA8A1BEEU5MUQzynbo3oiYRXfgjmD8n9Bxc2GU5TjJ5JlAJID2V2pVvhSoCYGDL1F9xXdgM2hbR01fWfuaSfLb4 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2026 04:14:26.5480 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 26078040-1e21-4008-d650-08deb7b89ccf X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB59.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9147 Hello Andrea, On 5/22/2026 2:21 AM, Andrea Righi wrote: > @@ -14070,6 +14070,8 @@ static void nohz_balancer_kick(struct rq *rq) > static void set_cpu_sd_state_busy(int cpu) > { > struct sched_domain *sd; > + > + rcu_read_lock(); guard(rcu)() saves on the need for an unlock label but this works fine too. Feel free to include: Reviewed-by: K Prateek Nayak > sd = rcu_dereference_all(per_cpu(sd_llc, cpu)); > > /* -- Thanks and Regards, Prateek