From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10B8E1D5CC9 for ; Fri, 17 Jul 2026 00:31:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784248265; cv=none; b=mOenKQMeY+QHL5Hr1AiRUVBoyvR578j+RZw1K+tjZopJVFMIETSqCkza1SYazwiP6vTvLV8eXJcAJ4NkVnQEd1PQ6Cjj5TyMtoB4WzsP+RyODQ8FuMpcDAeJCZh7sAvY2egOn2ZECxBMwwzA74N9e5fzuQN9qtMrHW1LAXRA8Mg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784248265; c=relaxed/simple; bh=ytJd3IGSAL1N+rwcJpzr/vFDhEwruTPMalUoBQnrxXg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aZUarYw+DbACTZ0g2JCghOWqZ1LyyUEJ3J27bezMvIRkaE5/Fy1KhW9VUxnb7wIBoTeTv5t47r3Jn5yQLatJ1kYlv0RbSOoKAfdBbyvvgOZI7z2Le+ek0S9Linr79bRKTKRtIUYwAWAFNbuZhYtF5rY2QV2YUvXFU+/sVyXKP+w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XVyJOzoP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Miey3vxU; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XVyJOzoP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Miey3vxU" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66GNIxro4076890 for ; Fri, 17 Jul 2026 00:31:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KLhv4uLuj2a0CwkzFlguBw7pHPr92MMB0a10TBLdZz0=; b=XVyJOzoPVLGEGKHk 0Z58+V3wLWE/gQjodIn+fi2m248drcXqjWT+pAqorhGvlYVBAcMhwQJMQ9pBIcwp /EG4KBCaFgdOAJoK21OMH3VHUsMadLsMvTQhRp4u8AFkxpm/ETUnc6RgPm0X+a1a 0jg8lBMZ3i0mb8iwSY1xPN3vLxTJubyEdtSDRQiJLhR0j5uKu8VWAzam2EMtIdfE NonB3MX7vZwb65PD60WwlaRJe7KEfkhH4VVFJfbe6woGqcuvfTgNvemdaMA3LsWT Hpl9w85km2Dx3l1ow87/iVr9Fcs5FCUQLlJRMivDZwk64F71Cj/6ZFvof4hZwsSA sntTjA== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fevkv3jn2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 00:31:02 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c9fe4c5eb39so5126765a12.1 for ; Thu, 16 Jul 2026 17:31:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784248262; x=1784853062; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=KLhv4uLuj2a0CwkzFlguBw7pHPr92MMB0a10TBLdZz0=; b=Miey3vxUv6zQ6J0Haibc7hKwD68G8G9VLkpGEj0ilooVTAmx8slIP4ykQGVslskxEP Vefp5xkfp0PTs7HBGln6WwvnXjSG+WJaX45Kzn3V6/Z0MPf971Hg3yHFJKJb8Er24qlz X1ridboB0+pG7umPK1rvjAw5NzIG+EX82PEK1qeHzJzH4jhpkZl3jsfwwqzPzk914EA/ /7oYdC2lLvYE6/Tj181997DGJ/9alojpdjR/h2CxB2CLN7PH4xVSBnPyt0WY+IzlbBhe DgZcbr7rh3Is75g2kCHHjOB3s+1+9jSy2v7jI4r/XFRhflL/Jv3/iHP6U8le5Epf/JLj Nbsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784248262; x=1784853062; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=KLhv4uLuj2a0CwkzFlguBw7pHPr92MMB0a10TBLdZz0=; b=UnRs9gQLKZw126qqHspkG8dgN1Cs4iwjJo/Yu31XG9L1GNJYIOWzz8O0zeMLUaTRpw FTRqEaLYO9drpRXqc5QR0lLlGxl4w7wSxTehoD6LoetZSiY0nLxX1fjBKF1CorhsQZFs 9xBqsT4p491Xc+c4D4cquPaHTRfBY1v2p/Nl7qza2a3n9+cPhwtVtWitojXFKwUNth0/ Ece9bTrp+hkLsmv3CWGhWrwArYf+dqqMZlXgKuRk0en4LZXty6H1Vep5Yat4hPCKS7IT SAg4hvMKXFTLbl1FP7nwOsGvXB0+rP6V14a4Ey09cYHaZRXtdDv3M7vyNZuJ6Luc71NJ JY/Q== X-Forwarded-Encrypted: i=1; AHgh+Rpu1Y1wzApRnBgUwTQnSRAAPI4DikMcIRwBKWlui38bf6pY8dW0ugdoh8R9sLUnoZlBSy+GZIwSjkIJnsg=@vger.kernel.org X-Gm-Message-State: AOJu0YxMcJxwWkb/ur1nr7VAnDhrGA2aqHO1pj4uB/RBl/zfoB1MLAuQ WOqwqnYTJDVDxS+Jnk4GpdgA9nIvTOXreUge5CdH5mVcS7flopJohhSiWMOFIdprYR/QHBUzqVP ufMJDEgdtypa+oiN8as4bp3RqNM9Xr5TfHJeltuwdM5dnDcYwrS737FT3iT09o69ix6o= X-Gm-Gg: AfdE7cmLB1CeI0J5kfQOwYxg3SdTElMlvXLff2C4s5IDg6+9E6tnx3v9T0UecXYfv6U vxJEUJrV+wR1pD5IpNMX0MR1CrbnLCFqRj9776sgRWJkI5CacLakfkBkifnE6AFZE7TF6eBxzge dyqsqLeHq2qPlCjUxmrnnR7F1f4fTM7s8PaqIqKr5dMR5V7/21ioWV6rmdi2PIV83owS/TNi8aw wd/4DwPHq4x3ld5YiLeG6JHHLGFfvCXM2xxuJozK/mNONhq3XGJlOZWWqyh44v/qxM8wTBTs6lx 4N498vloYjwH11TZIr/RMKrncBMgzTI0YzvHsPlUo/GQPrAYATA4Xq4RNMH5VPn30G6N2Q/RVEo +MDupHKwWdg9Y355eGI3tuwLvegYzlCB2CsxUoTDJ/mLZxVKu+3sW1SDB07ZULwhsBpHA X-Received: by 2002:a05:6a20:cc0b:b0:3a3:a9c4:3d60 with SMTP id adf61e73a8af0-3c3ad7ac045mr262471637.27.1784248261596; Thu, 16 Jul 2026 17:31:01 -0700 (PDT) X-Received: by 2002:a05:6a20:cc0b:b0:3a3:a9c4:3d60 with SMTP id adf61e73a8af0-3c3ad7ac045mr262407637.27.1784248260974; Thu, 16 Jul 2026 17:31:00 -0700 (PDT) Received: from [192.168.1.7] ([122.177.244.170]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cb519de26a5sm37551a12.22.2026.07.16.17.30.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jul 2026 17:31:00 -0700 (PDT) Message-ID: <3763d264-e958-4a2a-ad7b-204e6af37655@oss.qualcomm.com> Date: Fri, 17 Jul 2026 06:00:55 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/4] arm64: dts: qcom: Enable USB controllers on Shikra IQS platform To: Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley References: <20260716-shikra-usb-dt-v3-v3-0-13f73a0571bb@oss.qualcomm.com> <20260716-shikra-usb-dt-v3-v3-4-13f73a0571bb@oss.qualcomm.com> <606db992-446c-4601-805a-d86d0fb74110@oss.qualcomm.com> Content-Language: en-US From: Krishna Kurapati In-Reply-To: <606db992-446c-4601-805a-d86d0fb74110@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDAwMyBTYWx0ZWRfX/d0V+V7o2Yz6 875EYOv42zBgTMRwPsdrEz5DKdxSMAEEqHZvjHrqLOI9nBe3XxIiu2wlZMcIc3VgZpXmpqF3jCv 36XdUqn4Z5p/iMiwTV4lue6q5rODayTFLE4G3bdiqpcSxjrr6gcde2Kr4Yb59YdXytmqzaz5UDL yGWD3C3gBRGFiTWyUr4QsqSyMDEjJvb7iEYPv8jf43plHHhI9ZkUlVZF3pDrHV5cf/2bhflwv8H Vbrcn5EKeVwOYIPCB434PbtyYEq/r+SRLz3HnoPCr7Ljxg+fxXx3JRc6yEMF1FKCKYl8kCZeOGn dpAFcx830YkSDC2C6pNZYP8diSCQ4fdu8aGiFtEgeF3o5H/V0PaLjdgOzeyaqmgSmOUR32gDs60 PuPtvNtngSBUlMZt+b5M+5JkfFKoaRQMbdpI5dxo3jBLJMNayX9PMbYR3lxgsLIEWawkkO0pce9 ZusgzgZxzLoVcWcQcvA== X-Authority-Analysis: v=2.4 cv=WrEb99fv c=1 sm=1 tr=0 ts=6a5977c6 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=HtVcTGqVJrL9f/+MTxaKuA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=KWuMA8URoD_tUPs-JecA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-GUID: pxHk5H90SVsWmoERms_60puVZAZY8D4f X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDAwMyBTYWx0ZWRfX3sW6qiF4t543 ogpqRfznRNrc8sdb5KSNCOlR8FtUyFb0hQ6OOGW/1cpv0eCzIapdsIj8Xd2IdDJp/pE/DqExJS5 3XZiw4Y2PxFnw12oaPn/sklSCDvyoiY= X-Proofpoint-ORIG-GUID: pxHk5H90SVsWmoERms_60puVZAZY8D4f X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-16_08,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 priorityscore=1501 adultscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170003 On 7/16/2026 11:10 PM, Konrad Dybcio wrote: > On 7/16/26 6:29 PM, Krishna Kurapati wrote: >> Enable both usb controllers in device mode on Shikra IQS platform. >> >> Signed-off-by: Krishna Kurapati >> --- >> arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts | 35 +++++++++++++++++++++++++++++ >> 1 file changed, 35 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts b/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts >> index 3003a47bd759..2d4e34ec3b82 100644 >> --- a/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts >> +++ b/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts >> @@ -38,3 +38,38 @@ &sdhc_1 { >> >> status = "okay"; >> }; >> + >> +&usb_1 { >> + dr_mode = "peripheral"; > > Why does this one have to be peripheral if the other boards are otg? > Actually I missed adding dr_mode as peripheral for other boards. I put in commit message that I want them to work in device mode but missed adding dr_mode property. Since the default behavior is peripheral mode, i saw no functional issue while testing. Shall I send v2 with either removing dr mode here in iqs or adding it in cqs/cqm ? > [...] > >> +&usb_2 { >> + dr_mode = "peripheral"; >> + >> + status = "okay"; > > And why do the other boards lack the secondary USB? As mentioned in cover letter, on pure upstream build, I validated both controllers on iqs platform and only primary controller on cqs/cqm platform on a remote access setup. Regards, Krishna,