mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Khushit Shah <khushit.shah@nutanix.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: "seanjc@google.com" <seanjc@google.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Shaju Abraham <shaju.abraham@nutanix.com>
Subject: Re: [BUG] [KVM/VMX] Level triggered interrupts mishandled on Windows w/ nested virt(Credential Guard) when using split irqchip
Date: Tue, 9 Sep 2025 10:34:10 +0000	[thread overview]
Message-ID: <376ABCC7-CF9A-4E29-9CC7-0E3BEE082119@nutanix.com> (raw)
In-Reply-To: <87wm69dvbu.fsf@redhat.com>

Thank you for the pointers, Vitaly!

> On 8 Sep 2025, at 5:12 PM, Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
> 
>> Thanks you for the comments Vitaly!
>> 
>>> On 8 Sep 2025, at 2:35 PM, Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
>>> 
>>> Is there a specific reason to not enable any Hyper-V enlightenments for
>>> your guest? For nested cases, features like Enightended VMCS
>>> ('hv-evmcs'), 'hv-vapic', 'hv-apicv', ... can change Windows's behavior
>>> a lot. I'd even suggest you start with 'hv-passthrough' to see if the
>>> slowness goes away and if yes, then try to find the required set of
>>> options you can use in your setup.
>> 
>> 
>> Actually in production we use an extensive set of cpu features exposed to the guest, still the issue persists, 
>> With the following hv-* options also the issue is present:
>>       hypervisor=on,hv-time=on,hv-relaxed=on,hv-vapic=on,hv-spinlocks=0x2000,hv-vpindex=on,hv-runtime=on,hv-synic=on, 
>>       hv-stimer=on,hv-tlbflush=on,hv-ipi=on,hv-evmcs=on
>> 
> 
> Try adding 'hv-apicv' (AKA 'hv-avic') to the list too (not to be
> confused with 'hv-vapic’)


I tried with hv-apicv=on, the issue still persists. 

> Oh, this is next level) Do you know if the issue reproduces with newer
> Windows, e.g. 2025?

The latest I can try on is Win11 24H2, I will try and update here.

> Also, I've just recalled I fixed (well, 'workarounded') an issue similar
> to yours a while ago in QEMU:
> 
> commit 958a01dab8e02fc49f4fd619fad8c82a1108afdb
> Author: Vitaly Kuznetsov <vkuznets@redhat.com>
> Date:   Tue Apr 2 10:02:15 2019 +0200
> 
>    ioapic: allow buggy guests mishandling level-triggered interrupts to make progress
> 
> maybe something has changed and it doesn't work anymore?

This is really interesting, we are facing a very similar issue, but the interrupt storm only occurs when using split-irqchip. 
Using kernel-irqchip, we do not even see consecutive level triggered interrupts of the same vector. From the logs it is 
clear that somehow with kernel-irqchip, L1 passes the interrupt to L2 to service, but with split-irqchip, L1 EOI’s without 
servicing the interrupt. As it is working properly on kernel-irqchip, we can’t really point it as an Hyper-V issue. AFAIK, 
kernel-irqchip setting should be transparent to the guest, can you think of anything that can change this?

Regards,
Khushit

  reply	other threads:[~2025-09-09 10:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-05 15:26 Khushit Shah
2025-09-08  9:05 ` Vitaly Kuznetsov
2025-09-08 11:19   ` Khushit Shah
2025-09-08 11:42     ` Vitaly Kuznetsov
2025-09-09 10:34       ` Khushit Shah [this message]
2025-09-10  8:34         ` Vitaly Kuznetsov
2025-09-10  9:39           ` David Woodhouse
2025-09-18 16:05             ` Khushit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=376ABCC7-CF9A-4E29-9CC7-0E3BEE082119@nutanix.com \
    --to=khushit.shah@nutanix.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=shaju.abraham@nutanix.com \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®