From: James Bottomley <jejb@linux.ibm.com>
To: lijinlin <lijinlin3@huawei.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
martin.petersen@oracle.com
Cc: linfeilong@huawei.com, liuzhiqiang26@huawei.com
Subject: Re: scsi: Add diagnostic log for scsi device reset
Date: Thu, 07 Jan 2021 08:49:07 -0800 [thread overview]
Message-ID: <3770e4f3025e48759ad64513a457f1276031d900.camel@linux.ibm.com> (raw)
In-Reply-To: <c391120e-897a-0ee1-d01a-0defe504d6df@huawei.com>
On Thu, 2021-01-07 at 19:43 +0800, lijinlin wrote:
[...]
> - SCSI_LOG_ERROR_RECOVERY(3,
> + if (bdr_scmd->request && bdr_scmd->request->rq_disk)
> sdev_printk(KERN_INFO, sdev,
> - "%s: Sending BDR\n", current-
> >comm));
> + "[%s] Sending device reset\n",
> + bdr_scmd->request->rq_disk-
> >disk_name);
Not everything is a SCSI disk. If we apply this patch, we lose traces
for any non-disk device that get reset ... for tapes this can be really
important to know.
James
prev parent reply other threads:[~2021-01-07 16:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 11:43 lijinlin
2021-01-07 16:49 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3770e4f3025e48759ad64513a457f1276031d900.camel@linux.ibm.com \
--to=jejb@linux.ibm.com \
--cc=lijinlin3@huawei.com \
--cc=linfeilong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=liuzhiqiang26@huawei.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®