From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750971AbcFDKn6 (ORCPT ); Sat, 4 Jun 2016 06:43:58 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:55203 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750916AbcFDKnx (ORCPT ); Sat, 4 Jun 2016 06:43:53 -0400 From: Arnd Bergmann To: Binoy Jayan Cc: Greg Kroah-Hartman , Larry Finger , Jakub Sitnicki , driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] *** rtl8188eu: Replace semaphores with mutexes or completions *** Date: Fri, 03 Jun 2016 12:06:58 +0200 Message-ID: <3772927.FqV0tunLfN@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1464947943-2008-1-git-send-email-binoy.jayan@linaro.org> References: <1464947943-2008-1-git-send-email-binoy.jayan@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:j5XCNL33X8Jjrp2b15wRjIUhJ7B4/XzWg/pDDE7wF1itmxL08al H0dANbd4JlPUNrKRRHVrFVv7RvbpISG2pRO8vr40/h6T/xevvcKS6wfH8x4kG+TpCOEviF5 2zKtkj34lzny9tBPgmhUYpQaMYwhiPRbeI4hBhWVNaTOvoKoB23nef3QAK5GEhMzik7W14i FgscFmwju9lW0HhvvHL5w== X-UI-Out-Filterresults: notjunk:1;V01:K0:g9XkGZWAL3A=:6/2w7TjmXPJsp9YHgJisGB tfVpjdloQ5Sgz2OWTHbOZom8YRIgvd0ACNhDPEW9TtUgiGGZO2QtK8yjk/MfYQbuUPacXODwi lFRIOZDzm/zPxIq84cbYvg3N8r1BsSYuLQtR2491/1DMWv8UnJnA5y7WUlhqLlZzzF3JQFa5c Qg9oYnJqZKjhD1IOCLbqfzRbyFsZ6Qg9RhYtnwBWm/2qdD1cO4NceD2pRXRxEkFekwt5iX6hj q1yJRJpJUyPe3PGm4Pkz2N8BF4FnYCyPT3GvCjPMCB+KAZa5db93i62alpPx2WcxhF/05AItC LJMQIPOydgNbdgd2rJJ1jttD4EaRf5EklcVwUyVuPETG9xkf3/gZcZB8/FQ+ehvxtxmPMjGv3 Xrs8Wi+xwX/edMIRupEaJv4rJ1v2LAq1R0+Gi2yYt4AmEchUDz/fKhVf+9RPR/8lWkPOnUDo4 3Ip6VQJSjiufTJUUDuOTgvrYKOMZSkUYi1roRLv622WLNuHsys1Dt+7/Vgkw7Appg8hoJ82Ed xbeIkMu4Oj6/H2WqGT70i60xqCN8BJH4wZSHU6sSNYa34uU0uOMfDt89eqczxQXO7tS9I0OEZ QiXjGN1pkL4ZJNgJj0O1GZtSOW2S4U01KgD+EdyewroDZ8rA5mcGiCeSTq+sZbGrNMmYTntQn nENeBVDh7s+y+GQrK8rJX5aEe71DRkwbIijlPDYKxj3QFoomRCA9LS3CmTmJHVZpes5ngH4Vk LcaWZIDyIh7kVV/2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, June 3, 2016 3:28:59 PM CEST Binoy Jayan wrote: > > These are a set of patches which removes semaphores from: > > drivers/staging/rtl8188eu > > These are part of a bigger effort to eliminate all semaphores > from the linux kernel. > > They build correctly (individually and as a whole). > NB: I have not tested this as I do not have the following hardware: > > "Realtek RTL8188EU Wireless LAN NIC driver" > > The patches all look good to me. Patch three again could use some information describing that it replaces an interruptible semaphore with an uninterruptible mutex, fixing a bug in the process. BTW, there is no need to list the dependencies in each patch when posting a series, as the default assumption is that they need to be applied in sequence. Reviewed-by: Arnd Bergmann