From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753233AbdDKS2z (ORCPT ); Tue, 11 Apr 2017 14:28:55 -0400 Received: from mout.web.de ([212.227.17.11]:59505 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752610AbdDKS2v (ORCPT ); Tue, 11 Apr 2017 14:28:51 -0400 Subject: [PATCH 1/2] tty-goldfish: Use kcalloc() in goldfish_tty_create_driver() From: SF Markus Elfring To: Greg Kroah-Hartman , Jiri Slaby Cc: LKML , kernel-janitors@vger.kernel.org References: <53ab1654-e0ef-1227-cef2-32dbedcdc124@users.sourceforge.net> Message-ID: <3778b45c-f58c-b38a-51c3-5acb6bc55f68@users.sourceforge.net> Date: Tue, 11 Apr 2017 20:28:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <53ab1654-e0ef-1227-cef2-32dbedcdc124@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:521/jSjF7xqj0DMLta6SMFfPpyGub5DwpvoPLnJ+x7+5Y65VvKH XhyuHmFVnTNn4EDaOStmS0kzOhnocq07iv2pZrQiXBowtedNqOpQrd4Ug5C0j0Fpq781ZvR ATJ6+49h+YZ1F50trvHmIFsQ+ie6Girp6Me/dvP1oaEuodjKzBSG7nC/Cm2Y0mI6VYAIvDO npG1h7IbsvlMN+ZmA+9pw== X-UI-Out-Filterresults: notjunk:1;V01:K0:rm2ZVaSFN9A=:QzlJs3yLhto1jfDNvcD1Op Ojsuj+d2iiNE+tXliVm0rq2CJFZaogsdleVKKEi6jQtrvxSDjtVpsxeCCJ+cr9nPm/+H7MX35 A9T3I1WOLizm48mGeGYX9wLMc6k0Qj3eDjMeOlgWiHLxmaQpYqtwH+J252mXd4miHTBpfBdWE eXJtbIrbL4+EopL2mwyrnjRT1KRQlbgcEieSxvLAIMKr2Lp6/nsUmwS4+cKCuCBMu5q0YproD 2MOQ0XTgMDZIKgQRDOLxff5jIUZTK47k2ip5P+XrohMbl1363CV9z2n4CONn/TErCpTOA+wdR 6rb9Gr7fxqv3OQ2DQqKtOIpx/e0EdImMmbKf7NUg4toHcMGNRC3yONkAgLtkGw2gjq7q8tBaV vqDw145aFXmRcPmIeqGjf524I6gRHl6npnK9nsjW4s+kfBDrbc4b9B+OuHWjhQDAs7mea/aIT NGRXrHGjlPaWYR4Kio+RxaIJQeqPuGUmbxTYQu1sC68ZA7ehsArHyGUrwOkZlC+89I8paJRtI SJeSTSdbxPFjyq1yCoiuusACX0/59jU3i1uyq/oTvjkDD+qLhf+kxMHZyE9e+4EukB+WZPhHz wqT9ru+96AKcRDj3fHcjHGTeW4Puqa2LrRYjFTBYcw/CiJ0qAUw9lsixsFhkbCNPEbTzQMimL mxD18EpZiEVTfNQ4j6FDmjzw7RwzDQ7t6alJ0D2JJ6vJg31afOyoKCCKZE5pttKq6LYffPpGi r2ZJNQGR3n88OU3XaTS9/nEaUvwTQ/6/U+j2l7Pzll50dQFIt9i5SmkFaiwTc97Uzp+50+nOG TR2aT78 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 11 Apr 2017 20:00:23 +0200 A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kcalloc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/tty/goldfish.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c index 996bd473dd03..b92c3312ecd2 100644 --- a/drivers/tty/goldfish.c +++ b/drivers/tty/goldfish.c @@ -180,8 +180,8 @@ static int goldfish_tty_create_driver(void) int ret; struct tty_driver *tty; - goldfish_ttys = kzalloc(sizeof(*goldfish_ttys) * - goldfish_tty_line_count, GFP_KERNEL); + goldfish_ttys = kcalloc(goldfish_tty_line_count, sizeof(*goldfish_ttys), + GFP_KERNEL); if (goldfish_ttys == NULL) { ret = -ENOMEM; goto err_alloc_goldfish_ttys_failed; -- 2.12.2