From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750951AbVHIWme (ORCPT ); Tue, 9 Aug 2005 18:42:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750952AbVHIWme (ORCPT ); Tue, 9 Aug 2005 18:42:34 -0400 Received: from az33egw01.freescale.net ([192.88.158.102]:43983 "EHLO az33egw01.freescale.net") by vger.kernel.org with ESMTP id S1750929AbVHIWmd (ORCPT ); Tue, 9 Aug 2005 18:42:33 -0400 In-Reply-To: <20050809150131.7eac43ad.akpm@osdl.org> References: <20050809150131.7eac43ad.akpm@osdl.org> Mime-Version: 1.0 (Apple Message framework v733) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <3779A304-7AFC-4476-B0FC-794BD0351270@freescale.com> Cc: "Gala Kumar K.-galak" , , , "McClintock Matthew-R56630" Content-Transfer-Encoding: 7bit From: Kumar Gala Subject: Re: [PATCH] ppc32: Added support for the Book-E style Watchdog Timer Date: Tue, 9 Aug 2005 17:42:31 -0500 To: Andrew Morton X-Mailer: Apple Mail (2.733) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Aug 9, 2005, at 5:01 PM, Andrew Morton wrote: > Kumar Gala wrote: > >> >> PowerPC 40x and Book-E processors support a watchdog timer at the >> > processor > >> core level. The timer has implementation dependent timeout >> > frequencies > >> that can be configured by software. >> >> One the first Watchdog timeout we get a critical exception. It is >> > left > >> to board specific code to determine what should happen at this point. >> > If > >> nothing is done and another timeout period expires the processor may >> attempt to reset the machine. >> >> Command line parameters: >> wdt=0 : disable watchdog (default) >> wdt=1 : enable watchdog >> >> wdt_period=N : N sets the value of the Watchdog Timer Period. >> >> The Watchdog Timer Period meaning is implementation specific. Check >> User Manual for the processor for more details. >> >> This patch is based off of work done by Takeharu Kato. >> >> ... >> >> +#ifdef CONFIG_BOOKE_WDT >> +/* Checks wdt=x and wdt_period=xx command-line option */ >> +int __init early_parse_wdt(char *p) >> +{ >> + extern u32 wdt_enable; >> + >> + if (p && strncmp(p, "0", 1) != 0) >> + wdt_enable = 1; >> + >> + return 0; >> +} >> +early_param("wdt", early_parse_wdt); >> + >> +int __init early_parse_wdt_period (char *p) >> +{ >> + extern u32 wdt_period; >> + >> + if (p) >> + wdt_period = simple_strtoul(p, NULL, 0); >> + >> + return 0; >> +} >> > > > Would prefer to see the declaration of wdt_period in a header file, > please. > > But beware that wdt_enable() is already a static symbol in a couple of > watchdog drivers. It might be best to rename the ppc global to > something > less generic-sounding while you're there. Ok, will make these changes and send an updated patch. - kumar