From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9ED72CA8 for ; Tue, 24 Jun 2025 16:15:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750781757; cv=none; b=aMLDnYboL10Bds6gWpbmEeVPMp5L/+AsioDJU/wOoCNB4qIwQ/4CvPsKLZ5Hg0ZX+WFjHKhGH61uDMh3sAS2ib2guO9aQVIsSA8ThdmHL1oWZkZMkhu7yPXcDUeInTYP2DwS0eMWi/vdkC01yUckjZNFyRwGeVsDQ6KpRuxzCes= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750781757; c=relaxed/simple; bh=cnqRmP3MWftqLsVV3rIWse2EOfNLNh9JhYIyXhzOGog=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dKSF4ojy8vdpsbtAz5+mph8OTl90eBuvTY2BXxSuBxAYMDylSBQ1fVtDHwD2UMxEhRozSRjLBMHIC4BtkLlKq9CVawMHDA5BtMs9Tkg3/ixxlAZvgrlh0MbKDxPC/Qn1h2fk6E5TmKc1X7u2+KjTxOG7ZGjAFNmimonv/SDUDJ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VJP8ug+t; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VJP8ug+t" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55O8wVo2014954 for ; Tue, 24 Jun 2025 16:15:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Qyfhlor21ICWZh+rc4+fdzgPyjA2dUWzPSk1D9SVOxw=; b=VJP8ug+t6fivQjJ9 2HdIITE3R/FvdMiFv/sFzLfYQdjlR6LZfI0tk+12LkzUfCaWvffmwc90exzRsxKK UnvVLM0QdfIFKK+CvwZyvict5EgEX4l+GIzBh+GhR8MSXn2oiaR4/+EXpwiN/sQa e4l8j0Y9W72UPEnouis0Zg28oux4KNQ2zXElHUE+oSMvlgF9qw74nBZ46+2+rqnb TOdKOpXc0klR2Ak36eoxs8eTTBQvXx/CjBDtfPduiIA4CSIorzhA+cINUYInl5ee Y+H4INM1M28qQRnvek+Qna+bQ6Mc0dwgilAqPxMJroBoYT5qmIF94fsCByFje5pz EdjfSA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47f2rpw12c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 24 Jun 2025 16:15:54 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2356ce66d7cso71969585ad.1 for ; Tue, 24 Jun 2025 09:15:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750781753; x=1751386553; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Qyfhlor21ICWZh+rc4+fdzgPyjA2dUWzPSk1D9SVOxw=; b=VW/L8vWaBOROFdChMN2L2BIJMArOd9YdyBiTFVFZdm3lxKHSv5O0ZK64/xt1EmO1EE FYt9IU0aN3afJRkWYh2J+w1n7diav5UM9Mi09mNLtbYhPwSEEnDol1jWcYOpOWw+bNpK tYrvscVajw8xj4l6RokHj6CUCaa2hb1Zm6pfxFfwyTkRaCFVFwtPgkIjOyfROfl7n3i2 PyzbSTMdSmndJZfy4KPUFVxW31/5oUEbaqkpoPSjNrI68/57bDAlajv/bY8PUbZMlSPz 1rKuVHpht8SNwmGh2BJp5yUSR0fEcGvpeLBx3qFbhtIM3zOyAfAEFsNVyV7F2NFi8DEt CV/A== X-Forwarded-Encrypted: i=1; AJvYcCViipxJX0YE9H5CJm0/Gw1m3oOhqGHMsLuLJMgy5/fFaHntaLSvqqP90OSGTYBdQ6SD33AoRbR7MOqNiVg=@vger.kernel.org X-Gm-Message-State: AOJu0YxSSQon5TvdevFpJyDEx0tBKEQxx70FBaWqsQy0kYyntlojJLqI 5CYDOXfjFkv8SASXw/HFldu0W2tEY3pG/utT+SaWqeJoJIeLn6DymJeo+GjppLezTT4K62NVIQ8 ipD8BqNDdGBnAK3TAwI1Cl/fxG7eKz0OxRYfjd5dN4gEQMdbCOfB2ZDxtsX4NLwkRC5q9mChmYn Y= X-Gm-Gg: ASbGnct71UUf49/n7NL10YGyf1Yxj/vr352AAAh8aqUeVlLIu51Emrh2avTMMMt6Kax xymjunHfZlx1X2Ave9BEMbv6JR5C/qbTlEyGQk+ux6eR4IA3wQ2unIXVQmMwDQMKDKAwS/6T52o /bx+ydZXecboZoK8bynGXf3sq36b0Fe6cQX6dimPH6bkPrXuernAJJlIrY6y+SgXgn+tg3ZPr/J /Up4EkV+HvQYHEOjjkBPd1u1HpX5KtvwDBkTEMwdcgPGhd+hIEX1baOR3634y6Cup2EG2n5gwZm Smel4sw1EpC6T691fYZNl+OFBUAI4rj4SeJQjfT48V6Uo+5AiIpbLI2dsjkE4DCXSpTScxInYVM ojkgcMNCJ/tDLgxQ= X-Received: by 2002:a17:902:fc44:b0:234:e655:a632 with SMTP id d9443c01a7336-237d9b19e2cmr287442545ad.51.1750781752988; Tue, 24 Jun 2025 09:15:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH3GDtY6uAafIPWUwLJ9fdR1mlv1odipIGVPfHXlQOfWlJDASFtqBzLLuEVdFTlA964kKvR6g== X-Received: by 2002:a17:902:fc44:b0:234:e655:a632 with SMTP id d9443c01a7336-237d9b19e2cmr287442015ad.51.1750781752475; Tue, 24 Jun 2025 09:15:52 -0700 (PDT) Received: from [192.168.1.111] (c-73-202-227-126.hsd1.ca.comcast.net. [73.202.227.126]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-237d8695440sm113338745ad.185.2025.06.24.09.15.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jun 2025 09:15:52 -0700 (PDT) Message-ID: <377affe8-fa88-4ade-9cf8-aaeaaabee679@oss.qualcomm.com> Date: Tue, 24 Jun 2025 09:15:51 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: ath11k: fix suspend use-after-free after probe failure To: Johan Hovold , Johan Hovold Cc: Jeff Johnson , linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org, Konrad Dybcio , Baochen Qiang References: <20250624082022.15469-1-johan+linaro@kernel.org> <43b978a5-c1c3-450d-8340-dc1a6dddc884@oss.qualcomm.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: <43b978a5-c1c3-450d-8340-dc1a6dddc884@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=NdDm13D4 c=1 sm=1 tr=0 ts=685acf3a cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=e70TP3dOR9hTogukJ0528Q==:17 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=VwQbUJbxAAAA:8 a=qSSGdmx9Lv0nWuJ4rdQA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjI0MDEzNiBTYWx0ZWRfX2T6I2XmLEtTX /+X+3ERbirpzTHdIBKl4zeBQLuK3/i0m/zdPnunwl4vPpNAINDxHseQIhgRrBZhS54jhm6tsnNV s6aDEAAwTc0mOrG24UqQnjFtkdAeIBW0tVQUyhjEFRjNULW2L+Godj+aigyTi3aLUoB/CwAePt4 5+UIUnFzM/Y6aEcXnponn4DvMGLUsgNGfAXe+0om4NaSWHEAnZoTXHe8UnHX3jaAH7qkioeAlsi jDk/5pAeWbcFpKEUm7UXXZfrxPuxAIjuZfnAG6FpMN8rKFN9tumuFVEYakl3YWLkX0NLv8SRA08 yGSynaFExJ/hvQYxCRWV/eZnZJ9OVHVE+22rhAx+ydfMc2poFohwb9SKFPfJcnf487dC5eReoCI YF3joHioH7bk8FE2tu6zAK7cewn7M3rkaoE8oQCaO7v5gwsQ7dw6utIXkFfOUph2J1Eeo+5d X-Proofpoint-ORIG-GUID: UdeyvGbCH3sisyO8RMILip-OmST_AfGq X-Proofpoint-GUID: UdeyvGbCH3sisyO8RMILip-OmST_AfGq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-24_06,2025-06-23_07,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 suspectscore=0 mlxlogscore=999 adultscore=0 clxscore=1015 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506240136 On 6/24/2025 8:11 AM, Jeff Johnson wrote: > On 6/24/2025 1:32 AM, Johan Hovold wrote: >> On Tue, Jun 24, 2025 at 10:20:22AM +0200, Johan Hovold wrote: >>> Make sure to deregister the PM notifier to avoid a use-after-free on >>> suspend in case core initialisation fails (e.g. due to missing >>> firmware). >> >> Not sure it matters in this case, but forgot to include: >> >> Tested-on: WCN6855 hw2.0 WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.41 > > I'll add that. > I'll also change the Link: to Closes: per checkpatch: > > WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report Please check pending patch: https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=pending&id=2418079880408c5ae0b2a93f72af044eaff18cb6