From: Marek Vasut <marex@denx.de>
To: Alexandre Torgue <alexandre.torgue@st.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <marc.zyngier@arm.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: stm32: Add level interrupt support to gpio irq chip
Date: Mon, 10 Feb 2020 19:39:02 +0100 [thread overview]
Message-ID: <377b0895-aaeb-b12e-cad7-469332787b4e@denx.de> (raw)
In-Reply-To: <20200210134901.1939-3-alexandre.torgue@st.com>
On 2/10/20 2:49 PM, Alexandre Torgue wrote:
> This patch adds level interrupt support to gpio irq chip.
>
> GPIO hardware block is directly linked to EXTI block but EXTI handles
> external interrupts only on edge. To be able to handle GPIO interrupt on
> level a "hack" is done in gpio irq chip: parent interrupt (exti irq chip)
> is retriggered following interrupt type and gpio line value.
>
> Signed-off-by: Alexandre Torgue <alexandre.torgue@st.com>
>
> diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c
> index 2d5e0435af0a..04e1b062c20e 100644
> --- a/drivers/pinctrl/stm32/pinctrl-stm32.c
> +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c
> @@ -89,6 +89,7 @@ struct stm32_gpio_bank {
> struct pinctrl_gpio_range range;
> struct fwnode_handle *fwnode;
> struct irq_domain *domain;
> + u32 irq_type[STM32_GPIO_PINS_PER_BANK];
You might want reverse xmas tree order here.
> u32 bank_nr;
> u32 bank_ioport_nr;
> u32 pin_backup[STM32_GPIO_PINS_PER_BANK];
> @@ -303,6 +304,48 @@ static const struct gpio_chip stm32_gpio_template = {
> .get_direction = stm32_gpio_get_direction,
> };
>
> +void stm32_gpio_irq_eoi(struct irq_data *d)
> +{
> + struct stm32_gpio_bank *bank = d->domain->host_data;
> + int line;
> +
> + irq_chip_eoi_parent(d);
> +
> + /* If level interrupt type then retrig */
> + line = stm32_gpio_get(&bank->gpio_chip, d->hwirq);
> + if ((line == 0 && bank->irq_type[d->hwirq] == IRQ_TYPE_LEVEL_LOW) ||
> + (line == 1 && bank->irq_type[d->hwirq] == IRQ_TYPE_LEVEL_HIGH))
> + irq_chip_retrigger_hierarchy(d);
> +};
> +
> +static int stm32_gpio_set_type(struct irq_data *d, unsigned int type)
> +{
> + struct stm32_gpio_bank *bank = d->domain->host_data;
> + u32 parent_type;
> +
> + bank->irq_type[d->hwirq] = type;
> +
> + switch (type) {
> + case IRQ_TYPE_EDGE_RISING:
> + case IRQ_TYPE_EDGE_FALLING:
> + case IRQ_TYPE_EDGE_BOTH:
> + parent_type = type;
> + break;
> + case IRQ_TYPE_LEVEL_HIGH:
> + parent_type = IRQ_TYPE_EDGE_RISING;
> + break;
> + case IRQ_TYPE_LEVEL_LOW:
> + parent_type = IRQ_TYPE_EDGE_FALLING;
> + break;
> + default:
> + return -EINVAL;
> + }
> +
> + irq_chip_set_type_parent(d, parent_type);
irq_chip_set_type_parent() returns error code, shouldn't that be handled?
Otherwise, tested on STM32MP1 with KSZ8851-16MLL NIC.
next prev parent reply other threads:[~2020-02-10 18:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 13:48 [PATCH 0/2] Add GPIO level-sensitive interrupt support Alexandre Torgue
2020-02-10 13:49 ` [PATCH 1/2] irqchip/stm32: Add irq retrigger support Alexandre Torgue
2020-02-10 13:49 ` [PATCH 2/2] pinctrl: stm32: Add level interrupt support to gpio irq chip Alexandre Torgue
2020-02-10 18:39 ` Marek Vasut [this message]
2020-02-11 10:08 ` Alexandre Torgue
2020-02-19 11:19 ` Marc Zyngier
2020-02-19 11:30 ` Alexandre Torgue
2020-02-19 11:39 ` Marc Zyngier
2020-02-19 11:48 ` Alexandre Torgue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=377b0895-aaeb-b12e-cad7-469332787b4e@denx.de \
--to=marex@denx.de \
--cc=alexandre.torgue@st.com \
--cc=jason@lakedaemon.net \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®