From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751567AbdJEN6O (ORCPT <rfc822;w@1wt.eu>);
        Thu, 5 Oct 2017 09:58:14 -0400
Received: from esa2.dell-outbound.iphmx.com ([68.232.149.220]:37273 "EHLO
        esa2.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751310AbdJEN6N (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 5 Oct 2017 09:58:13 -0400
From: <Mario.Limonciello@dell.com>
X-LoopCount0: from 10.166.132.190
X-IronPort-AV: E=Sophos;i="5.42,481,1500958800"; 
   d="scan'208";a="69605137"
X-DLP: DLP_GlobalPCIDSS
To: <andy.shevchenko@gmail.com>
CC: <dvhart@infradead.org>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <luto@kernel.org>,
        <quasisec@google.com>, <pali.rohar@gmail.com>, <rjw@rjwysocki.net>,
        <mjg59@google.com>, <hch@lst.de>, <greg@kroah.com>
Subject: RE: [PATCH v4 08/14] platform/x86: dell-smbios: Add a sysfs interface
 for SMBIOS tokens
Thread-Topic: [PATCH v4 08/14] platform/x86: dell-smbios: Add a sysfs
 interface for SMBIOS tokens
Thread-Index: AQHTPWLw1ZF2YxFxNU29GMZ5MXliDqLVRuOAgAAB/0A=
Date: Thu, 5 Oct 2017 13:58:11 +0000
Message-ID: <377f8d466565498aa50d8e39a0caf08d@ausx13mpc120.AMER.DELL.COM>
References: <cover.1507156392.git.mario.limonciello@dell.com>
 <0af6d03ee32bd5c1529a38de008aa94c03331d7e.1507156392.git.mario.limonciello@dell.com>
 <CAHp75VdT5Dofm+O4cVfADhZu_PFB345-VNbc8os_c4qDaegB-w@mail.gmail.com>
In-Reply-To: <CAHp75VdT5Dofm+O4cVfADhZu_PFB345-VNbc8os_c4qDaegB-w@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.143.18.86]
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id v95DwKEg030829

> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]
> Sent: Thursday, October 5, 2017 3:50 AM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: dvhart@infradead.org; LKML <linux-kernel@vger.kernel.org>; Platform Driver
> <platform-driver-x86@vger.kernel.org>; Andy Lutomirski <luto@kernel.org>;
> quasisec@google.com; Pali Rohár <pali.rohar@gmail.com>; Rafael J. Wysocki
> <rjw@rjwysocki.net>; mjg59@google.com; Christoph Hellwig <hch@lst.de>;
> Greg KH <greg@kroah.com>
> Subject: Re: [PATCH v4 08/14] platform/x86: dell-smbios: Add a sysfs interface for
> SMBIOS tokens
> 
> On Thu, Oct 5, 2017 at 1:48 AM, Mario Limonciello
> <mario.limonciello@dell.com> wrote:
> > Currently userspace tools can access system tokens via the dcdbas
> > kernel module and a SMI call that will cause the platform to execute
> > SMM code.
> >
> > With a goal in mind of deprecating the dcdbas kernel module a different
> > method for accessing these tokens from userspace needs to be created.
> >
> > This is intentionally marked to only be readable as root as it can
> > contain sensitive information about the platform's configuration.
> >
> > MAINTAINERS was missing for this driver.  Add myself and Pali to
> > maintainers list for it.
> >
> > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> 
> > Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> 
> To be clear I just suggested the output format in ->show() callback.

Andy, do you mean you would prefer not to be attributed in the description,
or should I be clearer that was your suggestion?