From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751401AbdLITLb (ORCPT ); Sat, 9 Dec 2017 14:11:31 -0500 Received: from mout.web.de ([212.227.15.14]:64721 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751002AbdLITL1 (ORCPT ); Sat, 9 Dec 2017 14:11:27 -0500 Subject: [PATCH 1/3] serial: ifx6x60: Delete an error message for a failed memory allocation in ifx_spi_spi_probe() From: SF Markus Elfring To: linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby Cc: LKML , kernel-janitors@vger.kernel.org References: <992f55e5-961d-79ea-a6cd-441ceb3ad058@users.sourceforge.net> Message-ID: <378523b8-0fd4-2bc0-03f8-fa57e60e95e0@users.sourceforge.net> Date: Sat, 9 Dec 2017 20:11:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <992f55e5-961d-79ea-a6cd-441ceb3ad058@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:5ARL5T7kBZgmIn8FKTnv5pjsRJMqtbtqRb+NJ5tCjraGXF3iEFa StHl42mHW6CUTI308aTUHgaJRFoiPgWzY1Ixvsb3xsZoeXLL2djL9dH1MOWBc/O/4SFszcV uMEefPLt3lV4gvJ1xcLd1kReMQjbYzxEkRN7WC3DinYycqnHSeOC8H/uIsCKLqaEUgnNmu/ d64L0sfU2FVBF0vIRN1ow== X-UI-Out-Filterresults: notjunk:1;V01:K0:h9jkVsmsVfA=:EDJ6IfE1W4j02ZA0L4rq0j sdhADhx+GIiD6E6lkzP/Wf81fnhIaWgE0LxLtpqupORvI8t3eLoq3Y9eg6DVVr6dV7aRk1uyH oKDDv4yxZFASKzoP+PNNaobVjNfHhL7Q+HhzXoqpCP4yDZX9fclJV6aCaT14k8ViEJ3hK7cKQ zGAgmkEO5FTj09YpKL1eSdW7A7iXPX1/loydtn+S2D+4yAMmP6If25KE+22jgk6gjqRiLzfef Nai+E5flzm2LiAj064TsZYZzrUl6q8ecwET8oCm9sAVqq2HDXe7B/DLmq3kzPZwiWgL2hdtzV yESgtbYCviiV9cgg84vzOKW37uWqPBbu+g9mGHNJzv1jc5/LRTj85uKgzH182MIXr8ceT5lT2 FvVVByolt9bm+b2tzorGXzjDeMSZRhVSNOjXl29xc2g/IO3T1gZZOGjc3TEJUhwsSesFxwMf3 K/CQdBgqkj8DrmnCh+V747yFCElKM4FM8dFMRdFh/PhPpslfrhukP85Pii42gxT69lIz+iZEs N4pfKDiqmAcE+OY+N90gc9klch4Ud0j0/aJoKaI7ZK/6/7VUCSBj10DUHRrI/H7gEzdqRlpV3 cYVWz3deZimHB9yvJPxIlYHMTBbrSt9UmtCNfMovTmUN2p+IAbAJuOPheNt4ekX7Y/G9r8G81 UISospTVJcFRDdEnQNcTB9H1LrYGzzDqx+oLvYW4EFAmd1CXeGe/UL6o8jXNYwokXjb60qqGC hLGJl/BK63zr5ypJ111OLFW/ENLS32ZTeccqQxDfQAMBJOLI6pA9D9DxlBI0ggyZrPlRXnAWi wheQlMaXBpwdsnxMSZaDvOZkH3+fmkSaQfYkQoOC6RgjmTOH6c= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 9 Dec 2017 19:20:37 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/tty/serial/ifx6x60.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/ifx6x60.c b/drivers/tty/serial/ifx6x60.c index 473f4f81d690..832751479f41 100644 --- a/drivers/tty/serial/ifx6x60.c +++ b/drivers/tty/serial/ifx6x60.c @@ -1006,10 +1006,9 @@ static int ifx_spi_spi_probe(struct spi_device *spi) /* initialize structure to hold our device variables */ ifx_dev = kzalloc(sizeof(struct ifx_spi_device), GFP_KERNEL); - if (!ifx_dev) { - dev_err(&spi->dev, "spi device allocation failed"); + if (!ifx_dev) return -ENOMEM; - } + saved_ifx_dev = ifx_dev; ifx_dev->spi_dev = spi; clear_bit(IFX_SPI_STATE_IO_IN_PROGRESS, &ifx_dev->flags); -- 2.15.1