From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B18561E0E0A for ; Mon, 20 Jan 2025 19:33:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737401586; cv=none; b=ioGYDw+oxb/5WIdGgZQn0zpWMh5OdnwpeUvoX1De7CpmpKw0WTm3rU3OIoi8HDhnpi6s+Mz44Vp8LLvlt3uS6q3oHlGUV8GpYDAXWL90uDMBL8zzPlIBfFRUV10mRrjudCY7RutAVy1LfA9d89x224m7vBUwdKCIRH804CUJPs0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737401586; c=relaxed/simple; bh=AmIAL6AIVKOlRcURd9TsFKB6ojp9tZ3qP4eO/qhwloo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uOTcXdKm4K/bnxxoBfprLdrFV2Zbp4qj3xFMQ9V3MLKWjuXqs+RY0OsRv56cZgJIIj1+rUVkn7mEwmIhBfnk0pqiDKajwUkfEBAYgp4v3G2FbC0SkN6G6HymUfIFfw8J55IXTIBdQ4HLw2i5p8qIsxFD50gUVPeA3zmczZ9i1mQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=M4qEI0A8; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="M4qEI0A8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737401583; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=W6fLJg5b3Ho/Rd1m8EJ5l5kMGMWa70B4YP5YSznSDco=; b=M4qEI0A8Zsw6WuwbNA8eaKaPViwy4jBe61MgWyW8CZhfaZ55yAKi8IByri5nLR8Gy4Q9Vr 8QhhWKLYeGGLprOwG+HpIh3oFESCbZEXPSKMkK9wWbyVcou4/MORCZ1xD1LEnauoCs/6AD 0vMYgQJM6CQTzH1ZDQQk+zXvfPiXm3o= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-592-Q2CWZIGwPFyjfb89bgUoHg-1; Mon, 20 Jan 2025 14:33:02 -0500 X-MC-Unique: Q2CWZIGwPFyjfb89bgUoHg-1 X-Mimecast-MFC-AGG-ID: Q2CWZIGwPFyjfb89bgUoHg Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-38bf5ef17b2so2758774f8f.0 for ; Mon, 20 Jan 2025 11:33:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737401581; x=1738006381; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=W6fLJg5b3Ho/Rd1m8EJ5l5kMGMWa70B4YP5YSznSDco=; b=rn+/ROtT66znIVNuv5feg7cQiWaf/5Qj1BR6bpqMGCn7TPli0HfSozIm7qa01g/WDn 8fncd9xXZe5U1H8hhm2WvkjqUg1Tbdb+W6qcoFR+eNrc+J8yOJamL7Xjui1HPNEm/qIK l4SexhILuwGg482jlCYbB9rYQ+pGyC7XJhQdKi4w4iIBE8Veh/9o2m9fhQQjYQ4GBe2j BDO9H51+x4tye27z22xFd2rqnbGSwceX6Pbb0U21pZgFf6aHwn58Bw2/1ZyzMUd1dRBV Y/N/u7VxlYfQfbSM63NSgWCLu6QQNrryt9qPFbOElU3HJ6vXkWN7T0VTJD1Yo/RD9K2H t+yw== X-Gm-Message-State: AOJu0YzOEK1SgeJVJ4Z9omU/IC3IkEvKCSuo3eFyqu60zMAGFbBBN5XI c2YkRIJsUGzpmrlo0QmGA7jljwGJsnEMLj2ssSGuHDiAKago9RlTtQV3I/hhvO/23J+bC74JHoP 336F7g/M1eYHxZ6OHwvzOUm+sSkLFT4TgMj2AMO55Y5f/GQi5q07OeYbgJb58VA== X-Gm-Gg: ASbGncsuyQpiM0M9uzVKstx0CQ3w8+T1Yw1XM5sR4ddN/KQiyl1m+ulrrwmEIc8SBqi VNLbiUbbd0aU6hAHwVV/nNXOIUZ6OG17+VXKtE8Xkpg7523UTXptl9WIWKbARzkfwaEMhdsNmvx i0zI1sWRvqNOEM8uCVVwxJqBUKCTTw34d0EKDsTTym14tOI28BDPcBk8oYlK6w8z9w1TKO3t1di HjMVwHRrjXjpSo4CLAlm6z8YaXPuc/5pkSP5GU2OhfFpJU3tvQ3s3wppHXHHOQ+z7hrkqTAzBzq Jsm1DmNxp1fBbMj96qp2jpEktyJJWaBeiZh2KTmzePK69jDqpyrx/jSvag+fFkg6uNf6ZfD8u6Z F5TUe5zqfPy4WpmqO2d5qCQ== X-Received: by 2002:a5d:64a1:0:b0:385:de8d:c0f5 with SMTP id ffacd0b85a97d-38bf577ffacmr14906901f8f.16.1737401581013; Mon, 20 Jan 2025 11:33:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IHWOCo/H2RdPRvlgDCOUzYOTWSEh09OdcDEvYhIS8HvBiVVf+OLUrUvCdEwGtdLCFpeRO8qQQ== X-Received: by 2002:a5d:64a1:0:b0:385:de8d:c0f5 with SMTP id ffacd0b85a97d-38bf577ffacmr14906872f8f.16.1737401580619; Mon, 20 Jan 2025 11:33:00 -0800 (PST) Received: from ?IPV6:2003:cb:c72e:e400:431d:9c08:5611:693c? (p200300cbc72ee400431d9c085611693c.dip0.t-ipconnect.de. [2003:cb:c72e:e400:431d:9c08:5611:693c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf32845e8sm11477196f8f.97.2025.01.20.11.32.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 11:32:59 -0800 (PST) Message-ID: <378ab76e-6f31-4ef4-b4bc-7c78cc307875@redhat.com> Date: Mon, 20 Jan 2025 20:32:57 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 01/12] x86/mm: make MMU_GATHER_RCU_TABLE_FREE unconditional To: Rik van Riel , x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com References: <20250120024104.1924753-1-riel@surriel.com> <20250120024104.1924753-2-riel@surriel.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250120024104.1924753-2-riel@surriel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20.01.25 03:40, Rik van Riel wrote: > Currently x86 uses CONFIG_MMU_GATHER_TABLE_FREE when using > paravirt, and not when running on bare metal. > > There is no real good reason to do things differently for > each setup. Make them all the same. > > Currently get_user_pages_fast synchronizes against page table > freeing in two different ways: > - on bare metal, by blocking IRQs, which block TLB flush IPIs > - on paravirt, with MMU_GATHER_RCU_TABLE_FREE Right, worth noting the latter also right now relies on the blocking of IRQs that is in place, because they implicitly block the RCU sync. Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb