From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D49C01804A; Wed, 4 Jun 2025 09:12:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749028356; cv=none; b=k4OSf5xlbhnubEc6W8dZ17ClT8xS3rTczTqi1Hsc+Pe5aKj5HW23gOyglxpb60YrnnBRDg60FHoAGkSJT5JVj37DoqXZ9InavaeRWQB7ZW00lDhK9qDtzT05YM9Mh+m+QaoIRFQtgvJUqU9nl4B0F/LARKx2NlcXTTUd8wFFTl0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749028356; c=relaxed/simple; bh=zZpo6mK8tf383MWZB/POECNU1sIuN6ckveroVl8Bdjs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=pYZFCmlIZnuuSL9bicR8bQcCYLOFxwdDHXmxLuysQVQJkTXgNg1h2/sVKyYC+U4w1pxr8GHY+GxAKjLu8M41+XbYYgaIRy5zfsnFv/9S7NVyb0M/NtZjOkCdn+xORYG9r277xgBF292ZKOyVxvwajW6wFIHJNQsPENC41mWYx3g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=NjH7h2yj; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="NjH7h2yj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1749028355; x=1780564355; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=zZpo6mK8tf383MWZB/POECNU1sIuN6ckveroVl8Bdjs=; b=NjH7h2yjdi/R4va01KIQhQp8Qtn3vr6k2kD3NA4kM90WpAG0Ny5go8EB kiPjvB2n5lq4fVDjcc2M5+2Qon9F2GVUdC1/NOTleLDtgLezFM1yI/8b4 j6t3HWZkqoXlkb4qU3+Rrw/VlylNxXstYcFxWr7QeSoAQgCiPHG4nzqDk o38cEmfzT92APYI20YkljTbSJjx/Gzs1jjSi4pfvwZqd37+pAza+nED9F 1OuTYlwx5wOjFctPVqsnfjFW551NRFkAiTAzwMBBu6JPvMDG85qVrCitb xnFC/XLzAStJo14+P05AqcQiPJKc1RZxRrVjBe9CzQRXqPKqzBk16UUFH g==; X-CSE-ConnectionGUID: O6FMRUQpTNCOEGGw2ITzWQ== X-CSE-MsgGUID: uuzZd4vAT1KqpGzbKcpmaw== X-IronPort-AV: E=McAfee;i="6700,10204,11453"; a="51245016" X-IronPort-AV: E=Sophos;i="6.16,208,1744095600"; d="scan'208";a="51245016" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2025 02:12:34 -0700 X-CSE-ConnectionGUID: 6KQ7jSotTlyHgRT2Bv6ztA== X-CSE-MsgGUID: YHZD5V2FShW3vSBzcpE+kg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,208,1744095600"; d="scan'208";a="149915958" Received: from abityuts-desk.ger.corp.intel.com (HELO localhost) ([10.245.245.101]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2025 02:12:27 -0700 From: Jani Nikula To: Jeff Layton , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin Cc: Kuniyuki Iwashima , Qasim Ijaz , Nathan Chancellor , Andrew Lunn , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Jeff Layton Subject: Re: [PATCH v12 03/10] ref_tracker: add a top level debugfs directory for ref_tracker In-Reply-To: <20250529-reftrack-dbgfs-v12-3-11b93c0c0b6e@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20250529-reftrack-dbgfs-v12-0-11b93c0c0b6e@kernel.org> <20250529-reftrack-dbgfs-v12-3-11b93c0c0b6e@kernel.org> Date: Wed, 04 Jun 2025 12:12:25 +0300 Message-ID: <378d6754aad9991b859a5c2136f4a4211e9fafea@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Thu, 29 May 2025, Jeff Layton wrote: > Add a new "ref_tracker" directory in debugfs. Each individual refcount > tracker can register files under there to display info about > currently-held references. > > Reviewed-by: Andrew Lunn > Signed-off-by: Jeff Layton > --- > lib/ref_tracker.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/lib/ref_tracker.c b/lib/ref_tracker.c > index de71439e12a3bab6456910986fa611dfbdd97980..d374e5273e1497cac0d70c02c282baa2c3ab63fe 100644 > --- a/lib/ref_tracker.c > +++ b/lib/ref_tracker.c > @@ -273,3 +273,16 @@ int ref_tracker_free(struct ref_tracker_dir *dir, > return 0; > } > EXPORT_SYMBOL_GPL(ref_tracker_free); > + > +#ifdef CONFIG_DEBUG_FS > +#include > + > +static struct dentry *ref_tracker_debug_dir = (struct dentry *)-ENOENT; Nitpick, please prefer ERR_PTR(-ENOENT) over casting inline. BR, Jani. > + > +static int __init ref_tracker_debugfs_init(void) > +{ > + ref_tracker_debug_dir = debugfs_create_dir("ref_tracker", NULL); > + return 0; > +} > +late_initcall(ref_tracker_debugfs_init); > +#endif /* CONFIG_DEBUG_FS */ -- Jani Nikula, Intel