From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752873AbdJPMTG (ORCPT ); Mon, 16 Oct 2017 08:19:06 -0400 Received: from mout.web.de ([212.227.17.11]:54424 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752153AbdJPMSX (ORCPT ); Mon, 16 Oct 2017 08:18:23 -0400 Subject: [PATCH 1/3] char/pcmcia: Delete an error message for a failed memory allocation in mgslpc_probe() From: SF Markus Elfring To: "David S. Miller" , Jarod Wilson , Johannes Berg , Stephen Hemminger , kernel-janitors@vger.kernel.org Cc: LKML References: <5e693086-a995-81ad-4a3f-cf8ab2bac454@users.sourceforge.net> Message-ID: <378e6889-d956-af80-7885-4bc8c6500d1f@users.sourceforge.net> Date: Mon, 16 Oct 2017 14:18:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <5e693086-a995-81ad-4a3f-cf8ab2bac454@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:05CIuzSnV7P9QUF6uTc76oHLHZDiVPk9DvSykZwKytHxKxyic2t nZx/EVyNWO0kJmcr6KU+sIEHRqkHYdKZaR0xCJ3SV/yfMP8CtNUkqvAZEVI3dmdC41ajNeY kU1Di9EQA9lk7gCrSZqFMB8jl0kYVI5H9jjOlP+TieXPUJg6pGsTIwU5aWmmR36pBgTiDV6 N1nU6HZPSZXVX4upcko6Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:kk2G56QlGOQ=:TJuwaQOhQ4w+TTOLD+KNOV t2CqwiDdFypnDepiWzShQXIZI9h+2akRIe/5whXKlg2NQJ2k7f/hWkwpIvPwABeqa5jPxAwFO bQysBOnF+tbgJvqqB9W78xGqoujpsGtm3rLF3w1ddiqad8B44Yj1ma4xuzQhHg0fcZqzGlouM 5j0NJBg9Oo/rC9uza0f7UVTGf9pikzRljlzEjmd2uhN3JVnmut/1VRCzmgQYhp8z58IqKJJD2 /zTI6vGaCiAZEc3cqVudn4ptrr2uRO/lG8PF3PwB79EsFwPAXgK24FJwkgAvHCeZTPSmZZdWi Svd5kFtcxVLHZlK2LcTR/hhkof8WOPa0xKm/z9A1uigP1SKhqRs1AMrjGOpwjgdZuhCReCHa5 mcfdk21c3tnQC3ccNhbF6WEfQzkI2zUDnPAZxeR5ChsOg2lIMheWUWwzGkZXx/+XsU2sczqYo oBRe6kHMc8/wCfdRPxDHTFh2fdTj+fSm6FWEEvPe7GOe+Y+ecwfxwnU7W1oUdQ8mAURUitAI5 mEBp1PKwy218Es6hEI8rdQcnHyjSWh5M0tLqPL1WDmIAMgGJyjTI/wU3EaXz49PwNXY0jpRID ttZnx9xbeSoidoHDJc0C+y5Cxjkc7+Gp6Xop5vjOeTaCcE2z9ysPE4Dr4ekdBMbJpXI1+Zz2W nWl3wt3d3T2P0H8AJq32ajx/xzjnEk6B8Qpug/TErZ+7ZvU1kqmMLjdeSqI0lOnsbpuX13Tlc RFhS5Mv5YE0nuUYLgCkuV38b+kgFwiN+kEOBhoWiHup09bAJHatbCwXSzMh2HdixORMQRsD3u Ag4C8lpycBwSbFwGhVGw2Vohqv5tuwKR148R2F5FN8517bavS8= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 16 Oct 2017 11:46:38 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/char/pcmcia/synclink_cs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c index 62be953e5fb0..4db7eda2e7f2 100644 --- a/drivers/char/pcmcia/synclink_cs.c +++ b/drivers/char/pcmcia/synclink_cs.c @@ -520,10 +520,8 @@ static int mgslpc_probe(struct pcmcia_device *link) printk("mgslpc_attach\n"); info = kzalloc(sizeof(MGSLPC_INFO), GFP_KERNEL); - if (!info) { - printk("Error can't allocate device instance data\n"); + if (!info) return -ENOMEM; - } info->magic = MGSLPC_MAGIC; tty_port_init(&info->port); -- 2.14.2