From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753817AbbJINQb (ORCPT ); Fri, 9 Oct 2015 09:16:31 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:59113 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754966AbbJINQ1 (ORCPT ); Fri, 9 Oct 2015 09:16:27 -0400 From: Arnd Bergmann To: kbuild test robot Cc: kbuild-all@01.org, Pablo Neira Ayuso , Patrick McHardy , Jozsef Kadlecsik , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org, "Eric W. Biederman" , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH] netfilter: turn NF_HOOK into an inline function Date: Fri, 09 Oct 2015 15:15:59 +0200 Message-ID: <37905061.HAWoCKur8L@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <201510092113.o4u2vjMD%fengguang.wu@intel.com> References: <201510092113.o4u2vjMD%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:IB+/alyFg2cSmHK9+cGDIM3UvlW3hhgvzJ4T4qenTYhIOO3GHfQ 1M/qzQyO/0SPAh6dDf+7RcY6MOqDwRoIjABw0SgqeVLV0Qa7Yg/nTqBuCaz1kP5uLT4P+iQ 4YLth4aE3CSB+Rt2hfuWsrRLlTUKruHcZ6ECzhNc2jm897EPJImWzDtYwcWcq7rqq2c3T/C L/Az+WEbWwraPtMBQrObQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:Y4vRiL68QsM=:dkRrSg0N5d/5ROPnka8l7Y yaObVfwgvfzGkXNNGmyPWMBK4C3CUZK+9cXa7PoPTt5FE5BBongkYrjDHPhM9Tsctj0jIIA9X pD9yaj8e2gWSc2v6RnGYDHtWengHur1EW2/u38bSJeDw+Idh+w1jTcbDOkaI2lR+ybIxGmhqw CGXtXJgcdKn6gw0nLCICI60PSgREYPpsQfGGFgXPqcLK/Uu6W66V//ynff0XCM/aJNKGyntlj XSrzR9YmdUrujNaTHl1pz9X9c7eXrVm76Jm8oCHbySh4/WisG3nhc+vVHKXlp8GNuziJ2Yqvv qs+lN10DJuh8kWwHPuXhB9/igHFQodXMYpKxIG2js6ybSpN9SVSSU0PjF85X4olHe0HmgDLMn TEV3AIXD6uK9S73SGkSXOckIZ25R9QIIAtJPexEJTWm4w3B+64YyvDTY6ovOYgpVM0ziDAvUf hGUDRk1N8rN0c7wIoB5pIxBoNVrlh/XSMWZgR5oAT1SIQ9KlFTSy2V0qFyDFg47hQ7LKuTppQ qeqbitSsqx3UCU7eLF9KTLaTuwap8xanoHJSPr1OfBaJAvzc54Mg2S+wJmvZsF6MrIfJw5lgg 2j5rh2JTpf8q9b2VMfbOq1/pe9l+0bGexdCjnh4z1YOw7BtV3sm443P3LMk+3S44HbIpdK3CP kad9YI2UXorrTLN/6GeHIa4J3qNDCYJttv04ZPfXzdEAtgiwaBauQHZE1+9PaC+OLzJx6x7vZ ARysUfUcAO7z64X7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 09 October 2015 21:03:57 kbuild test robot wrote: > ^1da177e Linus Torvalds 2005-04-16 818 cb->rt_flags &= ~DN_RT_F_IE; > ^1da177e Linus Torvalds 2005-04-16 819 if (rt->rt_flags & RTCF_DOREDIRECT) > ^1da177e Linus Torvalds 2005-04-16 820 cb->rt_flags |= DN_RT_F_IE; > ^1da177e Linus Torvalds 2005-04-16 821 > 29a26a56 Eric W. Biederman 2015-09-15 822 return NF_HOOK(NFPROTO_DECNET, NF_DN_FORWARD, > 29a26a56 Eric W. Biederman 2015-09-15 @823 &init_net, NULL, skb, dev, skb->dev, > 8f40b161 David S. Miller 2011-07-17 824 dn_to_neigh_output); > ^1da177e Linus Torvalds 2005-04-16 825 > ^1da177e Linus Torvalds 2005-04-16 826 drop: > Ah, right. The 'dev' variable here is declared as #ifdef CONFIG_NETFILTER struct net_device *dev = skb->dev; #endif Apparently because the code produced the same warning as the ipv6 code. Removing the #ifdef here would make that code nicer and let us use my patch. Alternatively we could put the same #ifdef into IPV6 and not use the inline function. Any opinions? Arnd