From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Praveen Talari <praveen.talari@oss.qualcomm.com>,
Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Mukesh Kumar Savaliya <mukesh.savaliya@oss.qualcomm.com>,
Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
bjorn.andersson@oss.qualcomm.com,
dmitry.baryshkov@oss.qualcomm.com
Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com,
aniket.randive@oss.qualcomm.com,
chandana.chiluveru@oss.qualcomm.com,
jyothi.seerapu@oss.qualcomm.com
Subject: Re: [PATCH v4 12/13] i2c: qcom-geni: Store of_device_id data in driver private struct
Date: Wed, 4 Feb 2026 14:47:43 +0100 [thread overview]
Message-ID: <37905097-ec5a-4922-a34a-7cf0ddce33f4@oss.qualcomm.com> (raw)
In-Reply-To: <cf2b7624-eaf9-4ba3-9b2e-81be3adbb53f@oss.qualcomm.com>
On 2/4/26 6:04 AM, Praveen Talari wrote:
> Hi Konrad,
>
> On 2/3/2026 5:55 PM, Konrad Dybcio wrote:
>> On 2/2/26 7:09 PM, Praveen Talari wrote:
>>> To avoid repeatedly fetching and checking platform data across various
>>> functions, store the struct of_device_id data directly in the i2c
>>> private structure. This change enhances code maintainability and reduces
>>> redundancy.
>>>
>>> Acked-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>
>>> Signed-off-by: Praveen Talari <praveen.talari@oss.qualcomm.com>
>>> ---
>>
>> [...]
>>
>>> - desc = device_get_match_data(&pdev->dev);
>>> + gi2c->dev_data = device_get_match_data(&pdev->dev);
>>
>> Because you dereference it unconditionally later, this should be
>> null-checked
>
> Initially this was added, but based on Bjorn’s comment like there is no possibility of getting a null value here since we are already adding the platform data to compatibles
The ACPI match entries don't have it, which I think gives a good
example of how easy this may be overlooked
Konrad
next prev parent reply other threads:[~2026-02-04 13:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 18:09 [PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms Praveen Talari
2026-02-02 18:09 ` [PATCH v4 01/13] soc: qcom: geni-se: Refactor geni_icc_get() and make qup-memory ICC path optional Praveen Talari
2026-02-02 18:09 ` [PATCH v4 02/13] soc: qcom: geni-se: Add geni_icc_set_bw_ab() function Praveen Talari
2026-02-02 18:09 ` [PATCH v4 03/13] soc: qcom: geni-se: Introduce helper API for resource initialization Praveen Talari
2026-02-03 12:12 ` Konrad Dybcio
2026-02-02 18:09 ` [PATCH v4 04/13] soc: qcom: geni-se: Handle core clk in geni_se_clks_off() and geni_se_clks_on() Praveen Talari
2026-02-03 12:14 ` Konrad Dybcio
2026-02-02 18:09 ` [PATCH v4 05/13] soc: qcom: geni-se: Add resources activation/deactivation helpers Praveen Talari
2026-02-03 12:20 ` Konrad Dybcio
2026-02-04 5:18 ` Praveen Talari
2026-02-02 18:09 ` [PATCH v4 06/13] soc: qcom: geni-se: Introduce helper API for attaching power domains Praveen Talari
2026-02-03 12:23 ` Konrad Dybcio
2026-02-04 5:10 ` Praveen Talari
2026-02-02 18:09 ` [PATCH v4 07/13] soc: qcom: geni-se: Introduce helper APIs for performance control Praveen Talari
2026-02-02 18:09 ` [PATCH v4 08/13] dt-bindings: i2c: Describe SA8255p Praveen Talari
2026-02-02 18:09 ` [PATCH v4 09/13] i2c: qcom-geni: Isolate serial engine setup Praveen Talari
2026-02-03 12:42 ` Konrad Dybcio
2026-02-02 18:09 ` [PATCH v4 10/13] i2c: qcom-geni: Move resource initialization to separate function Praveen Talari
2026-02-03 12:46 ` Konrad Dybcio
2026-02-02 18:09 ` [PATCH v4 11/13] i2c: qcom-geni: Use resources helper APIs in runtime PM functions Praveen Talari
2026-02-03 12:48 ` Konrad Dybcio
2026-02-04 5:06 ` Praveen Talari
2026-02-04 13:44 ` Konrad Dybcio
2026-02-04 16:31 ` Praveen Talari
2026-02-02 18:09 ` [PATCH v4 12/13] i2c: qcom-geni: Store of_device_id data in driver private struct Praveen Talari
2026-02-03 12:25 ` Konrad Dybcio
2026-02-04 5:04 ` Praveen Talari
2026-02-04 13:47 ` Konrad Dybcio [this message]
2026-02-04 16:32 ` Praveen Talari
2026-02-02 18:09 ` [PATCH v4 13/13] i2c: qcom-geni: Enable I2C on SA8255p Qualcomm platforms Praveen Talari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37905097-ec5a-4922-a34a-7cf0ddce33f4@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=aniket.randive@oss.qualcomm.com \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=chandana.chiluveru@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=jyothi.seerapu@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mukesh.savaliya@oss.qualcomm.com \
--cc=prasad.sodagudi@oss.qualcomm.com \
--cc=praveen.talari@oss.qualcomm.com \
--cc=quic_vtanuku@quicinc.com \
--cc=robh@kernel.org \
--cc=viken.dadhaniya@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®